mbox series

[0/2] Ftrace direct call samples improvements

Message ID 20230427140700.625241-1-revest@chromium.org
Headers
Series Ftrace direct call samples improvements |

Message

Florent Revest April 27, 2023, 2:06 p.m. UTC 
  This series is a subset of [1] that didn't go through the arm64 tree.

- The first patch fixes a small bug when a direct call sample is loaded on x86
- The second patch adds arm64 support to all direct calls samples

They are sent together because the second one depends on the first one.

This series applies cleanly on Linus's master branch. It needs the first two
patches of [1] which, at the time of writing, don't seem to have made it to the
trace/linux-trace tree but I suppose they could be pulled from Linus's master

1: https://lore.kernel.org/bpf/20230405180250.2046566-1-revest@chromium.org/

Florent Revest (2):
  samples: ftrace: Save required argument registers in sample
    trampolines
  arm64: ftrace: Add direct call trampoline samples support

 arch/arm64/Kconfig                          |  2 ++
 samples/ftrace/ftrace-direct-modify.c       | 34 ++++++++++++++++++
 samples/ftrace/ftrace-direct-multi-modify.c | 40 +++++++++++++++++++++
 samples/ftrace/ftrace-direct-multi.c        | 24 +++++++++++++
 samples/ftrace/ftrace-direct-too.c          | 40 +++++++++++++++++----
 samples/ftrace/ftrace-direct.c              | 24 +++++++++++++
 6 files changed, 158 insertions(+), 6 deletions(-)

Comments

Steven Rostedt June 9, 2023, 8:20 p.m. UTC | #1 
On Thu, 27 Apr 2023 16:06:58 +0200
Florent Revest <revest@chromium.org> wrote:

> This series is a subset of [1] that didn't go through the arm64 tree.
> 
> - The first patch fixes a small bug when a direct call sample is loaded on x86
> - The second patch adds arm64 support to all direct calls samples
> 
> They are sent together because the second one depends on the first one.
> 
> This series applies cleanly on Linus's master branch. It needs the first two
> patches of [1] which, at the time of writing, don't seem to have made it to the
> trace/linux-trace tree but I suppose they could be pulled from Linus's master
> 
> 1: https://lore.kernel.org/bpf/20230405180250.2046566-1-revest@chromium.org/
> 
> Florent Revest (2):
>   samples: ftrace: Save required argument registers in sample
>     trampolines
>   arm64: ftrace: Add direct call trampoline samples support

Is this going through the arm64 tree, or should it go through mine?

-- Steve


> 
>  arch/arm64/Kconfig                          |  2 ++
>  samples/ftrace/ftrace-direct-modify.c       | 34 ++++++++++++++++++
>  samples/ftrace/ftrace-direct-multi-modify.c | 40 +++++++++++++++++++++
>  samples/ftrace/ftrace-direct-multi.c        | 24 +++++++++++++
>  samples/ftrace/ftrace-direct-too.c          | 40 +++++++++++++++++----
>  samples/ftrace/ftrace-direct.c              | 24 +++++++++++++
>  6 files changed, 158 insertions(+), 6 deletions(-)
>
Catalin Marinas June 10, 2023, 8:28 a.m. UTC | #2 
On Fri, Jun 09, 2023 at 04:20:46PM -0400, Steven Rostedt wrote:
> On Thu, 27 Apr 2023 16:06:58 +0200
> Florent Revest <revest@chromium.org> wrote:
> 
> > This series is a subset of [1] that didn't go through the arm64 tree.
> > 
> > - The first patch fixes a small bug when a direct call sample is loaded on x86
> > - The second patch adds arm64 support to all direct calls samples
> > 
> > They are sent together because the second one depends on the first one.
> > 
> > This series applies cleanly on Linus's master branch. It needs the first two
> > patches of [1] which, at the time of writing, don't seem to have made it to the
> > trace/linux-trace tree but I suppose they could be pulled from Linus's master
> > 
> > 1: https://lore.kernel.org/bpf/20230405180250.2046566-1-revest@chromium.org/
> > 
> > Florent Revest (2):
> >   samples: ftrace: Save required argument registers in sample
> >     trampolines
> >   arm64: ftrace: Add direct call trampoline samples support
> 
> Is this going through the arm64 tree, or should it go through mine?

Feel free to take it through your tree.

Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Steven Rostedt July 10, 2023, 9:40 p.m. UTC | #3 
On Sat, 10 Jun 2023 09:28:36 +0100
Catalin Marinas <catalin.marinas@arm.com> wrote:

> > Is this going through the arm64 tree, or should it go through mine?  
> 
> Feel free to take it through your tree.
> 
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>

I think I missed your email and let this drop. I'll add it now. As it's
sample code, it should still be OK to add to the rc releases.

-- Steve