mbox series

[v9,0/5] spi: dw: DW SPI DMA Driver updates

Message ID 20230427123314.1997152-1-joychakr@google.com
Headers
Series spi: dw: DW SPI DMA Driver updates |

Message

Joy Chakraborty April 27, 2023, 12:33 p.m. UTC 
  This Patch series adds support for 32 bits per word trasfers using DMA
and some defensive checks around dma controller capabilities.
---
V1 Changes : Add support for AxSize=4 bytes to support 32bits/word.
---
V1->V2 Changes : Add dma capability check to make sure address widths
are supported.
---
V2->V3 Changes : Split changes , add DMA direction check and other
cosmetic chnages.
---
V3->V4 Changes : Fix Sparce Warning
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303270715.w9sMJhIh-lkp@intel.com/
---
V4->V5 Changes : Preserve reverse xmas Tree order, move direction
check before initalisation of further capabilities, remove zero
initialisations, remove error OR'ing.
---
V5->V6 Changes :
	-Remove case of n_bytes=3 using 4_bytes buswidth
	-Avoid forward decaration
	-Break capability check patch into 2
	-round n_bytes to power of 2 ( Bug Fix)
	-Add more explanation in commit text.
---
V6->V7 Changes : Remove extra spaces, refer to functions in commit as
func()
---
V7->V8 Changes : Minor commment updates in patch 4/5
---
V8->V9 Changes : Minor formatting changes in patch 5/5
---

Joy Chakraborty (5):
  spi: dw: Add 32 bpw support to SPI DW DMA driver
  spi: dw: Move dw_spi_can_dma()
  spi: dw: Add DMA directional capability check
  spi: dw: Add DMA address widths capability check
  spi: dw: Round of n_bytes to power of 2

 drivers/spi/spi-dw-core.c |  5 ++-
 drivers/spi/spi-dw-dma.c  | 76 +++++++++++++++++++++++++++++----------
 drivers/spi/spi-dw.h      |  1 +
 3 files changed, 63 insertions(+), 19 deletions(-)

Comments

Serge Semin May 1, 2023, 5:14 p.m. UTC | #1 
@Mark, @Andy

On Thu, Apr 27, 2023 at 12:33:09PM +0000, Joy Chakraborty wrote:
> This Patch series adds support for 32 bits per word trasfers using DMA
> and some defensive checks around dma controller capabilities.

I've done with reviewing and testing the series. My tags are already
added to the patch logs. @Andy do you still have any comments about
the updated patchset? If none, @Mark please merge it in if you are ok
with the changes.

-Serge(y)

> ---
> V1 Changes : Add support for AxSize=4 bytes to support 32bits/word.
> ---
> V1->V2 Changes : Add dma capability check to make sure address widths
> are supported.
> ---
> V2->V3 Changes : Split changes , add DMA direction check and other
> cosmetic chnages.
> ---
> V3->V4 Changes : Fix Sparce Warning
> | Reported-by: kernel test robot <lkp@intel.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202303270715.w9sMJhIh-lkp@intel.com/
> ---
> V4->V5 Changes : Preserve reverse xmas Tree order, move direction
> check before initalisation of further capabilities, remove zero
> initialisations, remove error OR'ing.
> ---
> V5->V6 Changes :
> 	-Remove case of n_bytes=3 using 4_bytes buswidth
> 	-Avoid forward decaration
> 	-Break capability check patch into 2
> 	-round n_bytes to power of 2 ( Bug Fix)
> 	-Add more explanation in commit text.
> ---
> V6->V7 Changes : Remove extra spaces, refer to functions in commit as
> func()
> ---
> V7->V8 Changes : Minor commment updates in patch 4/5
> ---
> V8->V9 Changes : Minor formatting changes in patch 5/5
> ---
> 
> Joy Chakraborty (5):
>   spi: dw: Add 32 bpw support to SPI DW DMA driver
>   spi: dw: Move dw_spi_can_dma()
>   spi: dw: Add DMA directional capability check
>   spi: dw: Add DMA address widths capability check
>   spi: dw: Round of n_bytes to power of 2
> 
>  drivers/spi/spi-dw-core.c |  5 ++-
>  drivers/spi/spi-dw-dma.c  | 76 +++++++++++++++++++++++++++++----------
>  drivers/spi/spi-dw.h      |  1 +
>  3 files changed, 63 insertions(+), 19 deletions(-)
> 
> -- 
> 2.40.1.495.gc816e09b53d-goog
>
Mark Brown May 1, 2023, 11:58 p.m. UTC | #2 
On Mon, May 01, 2023 at 08:14:09PM +0300, Serge Semin wrote:
> @Mark, @Andy

Just as a note please don't add random characters to the start of the
name, for whatever reason it really annoys me.

> I've done with reviewing and testing the series. My tags are already
> added to the patch logs. @Andy do you still have any comments about
> the updated patchset? If none, @Mark please merge it in if you are ok
> with the changes.

We're still in the merge window right now.
Serge Semin May 2, 2023, 12:44 a.m. UTC | #3 
On Tue, May 02, 2023 at 08:58:33AM +0900, Mark Brown wrote:
> On Mon, May 01, 2023 at 08:14:09PM +0300, Serge Semin wrote:
> > @Mark, @Andy
> 
> Just as a note please don't add random characters to the start of the
> name, for whatever reason it really annoys me.

Ok.

> 
> > I've done with reviewing and testing the series. My tags are already
> > added to the patch logs. @Andy do you still have any comments about
> > the updated patchset? If none, @Mark please merge it in if you are ok
> > with the changes.
> 
> We're still in the merge window right now.

Ah, right. I absolutely forgot about that. Sorry for bothering. Let's
wait for the merge window to be closed then.

-Serge(y)