From patchwork Wed Apr 26 14:44:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fei Shao X-Patchwork-Id: 8684 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp309141vqo; Wed, 26 Apr 2023 08:04:51 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5vV1VOb8IDEmGlpTQJqa0rIo8DLelHbq62U6xzLQTJY4HVFBC1O23KXCYpvUFm9XenBjPB X-Received: by 2002:a17:902:e809:b0:1a6:46d7:77f0 with SMTP id u9-20020a170902e80900b001a646d777f0mr3451120plg.0.1682521491114; Wed, 26 Apr 2023 08:04:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682521491; cv=none; d=google.com; s=arc-20160816; b=LBzsIcFEJbxps5vJF8rqveMEs7JAVZb8D+YlgqkS39LuKYfReY6P5aAPjmYuyCf4Kz lHN3G+598CJHMuhu6uO+p5pusMbkXFqL/uEtVc5UsVyPxKvPCzgZV8hbJ82iPCyCADhd bQcdX0Ga8QWzjqniTe8g6eFBpUr3ch9K5KWI2g5eL+hIoYxlEHmiMqKr7fh1CZ2PDzFW 9N58WlElz0lZvvB3Cg/xS35wKB73Y1+vLgjLypLJFS+Q0p/FAvsCI2hLeRvrOjU40IW4 1JOEZF7eEXcmf6j8A6AVOAmwi6Suf2ltF78go2/yIjHk24cZJedx8uZ4PmYzSwnpikMM Oc9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=RMNClM9ik+szOvJOLzfRpbcMxADOReFPHjEqSl9MgW0=; b=AwxYmU2yCekXYOa8lOM4lut4R17Jjxl+tN5SAzrh+ibiPTzgIAhDlgTEwQEghhd89/ kO8+SUzJyEmdTQJ7CUvHPxACmA+iIGo2V6DGwnqlalNRtWld9qAHvnb6fMTjtHRVP/2e T/7O9uEoppjdCX07RrNR6AxEKpFykGNYNEdvD3BYT4/4DHYcVe7WEshwJfd6/1lh/yks XN9nsTHCpyQEf7fCC3q+X/0+8Xbx3P2VMbn7uNIDVa8n6W4IP9jl8z/LUCyQx/TUFxfE 2dP2rtNM65Xyo5IQ03E9SaTz0nKOEzu/j5H7kZFHewlBTNQVPKe9NRAuZ61n4y35tYto iuiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=T1qwsRZg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b18-20020a170902d51200b001a9265e6fdasi17775287plg.268.2023.04.26.08.04.35; Wed, 26 Apr 2023 08:04:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=T1qwsRZg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241494AbjDZOoj (ORCPT + 99 others); Wed, 26 Apr 2023 10:44:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241500AbjDZOoe (ORCPT ); Wed, 26 Apr 2023 10:44:34 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8D67769A for ; Wed, 26 Apr 2023 07:44:31 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-63d4595d60fso43795247b3a.0 for ; Wed, 26 Apr 2023 07:44:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1682520271; x=1685112271; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=RMNClM9ik+szOvJOLzfRpbcMxADOReFPHjEqSl9MgW0=; b=T1qwsRZgAaz7PgyfGME8hLTr+BlhLPS7hZWDSk7H9HG+U/in5nh4UEAeuL4awFu7Kh vvYQ74hjznhzvQQZ6ipUybRF6I83VVUuO8PQrWmuojfajIXZcwe72Vn8Bp6qakLrEUeT MSl0I6qTjgjLGXWar+a/gXZSDsWsiIMMymcxk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682520271; x=1685112271; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RMNClM9ik+szOvJOLzfRpbcMxADOReFPHjEqSl9MgW0=; b=c9IuypwjUFmXJMqC7+Cl3xFi9AFLBA9FC2IRhb/6gCgbob3PG7PGTxwqAYuHMujnfv deoJ5n/eVJ0B9Qk8j9eaoHPF0I/NarZhZrHQ4FY40XmQZq7+uU/Ne59ynTurrjQgQ9Aj fmv9w9kS33q7GW3l5goscAAcP2H3YOL2/NqC3pmP2c8xo37MT7HccOV77iJzoAoyaNvv B0c2lFm/HdCYGoZwluXTkxEnSnXO/xm6VV6ve5Y80WcpvWw7c9DsMVHV5uM8hJYTBWqX dQOrXioxMoqAiLy5cCZxH3pOvyU4oBFjtDim6G6YuwwOHYhP2PZirDjQ0nSPLe/mFPHP mVVA== X-Gm-Message-State: AC+VfDyDyFX/NYJWLCTWrUtR+5RaCzbgTwux5rb1iUEWFHiF5W4kJYYP riP4zGZGpcnMeRAtHraoHBnrrA== X-Received: by 2002:a05:6a21:9993:b0:ee:bcf3:be0c with SMTP id ve19-20020a056a21999300b000eebcf3be0cmr3657144pzb.0.1682520271275; Wed, 26 Apr 2023 07:44:31 -0700 (PDT) Received: from fshao-glinux.tpe.corp.google.com ([2401:fa00:1:10:dcf6:797f:140d:6d]) by smtp.gmail.com with ESMTPSA id f17-20020a631011000000b00502f20aa4desm8750495pgl.70.2023.04.26.07.44.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Apr 2023 07:44:30 -0700 (PDT) From: Fei Shao To: Jeff LaBundy , Douglas Anderson , Benjamin Tissoires , Rob Herring Cc: linux-mediatek , Fei Shao , Dmitry Torokhov , Jiri Kosina , Krzysztof Kozlowski , Matthias Kaehlcke , Stephen Kitt , devicetree@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 0/2] Fix Goodix touchscreen power leakage for MT8186 boards Date: Wed, 26 Apr 2023 22:44:20 +0800 Message-ID: <20230426144423.2820826-1-fshao@chromium.org> X-Mailer: git-send-email 2.40.1.495.gc816e09b53d-goog MIME-Version: 1.0 X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764232374120250457?= X-GMAIL-MSGID: =?utf-8?q?1764251655138121123?= These changes are based on the series in [1], which modified the i2c-hid-of-goodix driver and removed the workaround for a power leakage issue, so the issue revisits on Mediatek MT8186 boards (Steelix). The root cause is that the touchscreen can be powered in different ways depending on the hardware designs, and it's not as easy to come up with a solution that is both simple and elegant for all the known designs. To address the issue, I ended up adding a new boolean property for the driver so that we can control the power up/down sequence depending on that. Adding a new property might not be the cleanest approach for this, but at least the intention would be easy enough to understand, and it introduces relatively small change to the code and fully preserves the original control flow. I hope this is something acceptable, and I'm open to any better approaches. [1] https://lore.kernel.org/all/20230207024816.525938-1-dianders@chromium.org/ Changes in v3: - In power-down, only skip the GPIO but not the regulator calls if the flag is set Changes in v2: - Use a more accurate property name and with "goodix," prefix. - Do not change the regulator_enable logic during power-up. Fei Shao (2): dt-bindings: input: goodix: Add "goodix,no-reset-during-suspend" property HID: i2c-hid: goodix: Add support for "goodix,no-reset-during-suspend" property .../bindings/input/goodix,gt7375p.yaml | 9 +++++++++ drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 16 +++++++++++++++- 2 files changed, 24 insertions(+), 1 deletion(-)