From patchwork Wed Apr 26 09:32:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fei Shao X-Patchwork-Id: 8669 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp122858vqo; Wed, 26 Apr 2023 02:58:23 -0700 (PDT) X-Google-Smtp-Source: AKy350ZoX66HE8ly8afKzrR0DY6Tp61SGxBUa1fBZsnjbJ/DFcSQvLDgiPIkpOXzgDjDpPVy+Yjl X-Received: by 2002:a05:6a20:c187:b0:da:be69:a046 with SMTP id bg7-20020a056a20c18700b000dabe69a046mr23325802pzb.51.1682503103113; Wed, 26 Apr 2023 02:58:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682503103; cv=none; d=google.com; s=arc-20160816; b=jNWYPb/img/int5h+VE4R9b1Sia1Lewql3NAYtcAgiqAASJ3vjZ2wWpGMrzGriN89s 3Ws4X+TdkvkOT6c8Yx9ygWjkF08lectjcVlHPAHa7citVCi9WpkSsfdUQVfwO/KVY9U2 Xokf2gGUeM1tOw+eRchN4ATYb+6cypuQogMpcuSy9NJqG5W/3+n9tFh/SAK68RDX7pcL OtYJN98Xzr3md1XhoQavytIa/A/G3JVFtauQyqmwbw7tf85pj/GIhWtoMnC60YEnNf3d 4pzgW1zShHkjtpGG3OnPo8npfCW/eh1DxJg7poKbGSLbxV6ELWcmBYKT2pheuyG44n+z jJAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=tiC1EixoNe9TvcsXGi4HMFFCigO3LAC2XK4QXXLhOuY=; b=NQOQZMTPVyb89NgXQOHEwTPcvPSCCVmpFxDiNQmRlIJUN6sQOyn8B4LVI8PHuOrTdZ P5SvpXRDmmei0tddsHdROSKAK7fTVzU9Bs9hjtC6eNMDqFZxsRZI37yVJcK/sEf0ycVH a4J+KTtvqd3GFFr8f3ouIa4LhvHPQTQj2NCgxdqTeJsjkD2TB8Z2kak4UzRuwI1vEfa6 Ay1vFZa/YzXbZzaFPsnOfa/2yt0JSR3FHM+ptsDsefjnRP/iKufPZ5+mb/KfpK95Vg/h DCCS6KiTXYMLNtgSpyMnMdg9YdG+8KJAxGg0Oz4z3AKK/vMEmoSXI7xuZM8kJrVkhi2f qREw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="N/4d2/dn"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c6-20020a056a00008600b0063b679c6a06si15908259pfj.226.2023.04.26.02.58.10; Wed, 26 Apr 2023 02:58:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="N/4d2/dn"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240327AbjDZJdl (ORCPT + 99 others); Wed, 26 Apr 2023 05:33:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239936AbjDZJdh (ORCPT ); Wed, 26 Apr 2023 05:33:37 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D71CC10EB for ; Wed, 26 Apr 2023 02:33:35 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-63b50a02bffso5671470b3a.2 for ; Wed, 26 Apr 2023 02:33:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1682501615; x=1685093615; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=tiC1EixoNe9TvcsXGi4HMFFCigO3LAC2XK4QXXLhOuY=; b=N/4d2/dnYSkhGgmo1yEJ21nMJwso80TVv1R2jKDFELl94n03lMwt6NogcEwg1IsE6c kSjyQUDyCFg3pECB7tQBBB3Q1iX4k7l08KYKz/UoU9ccAOok4Svwduyt0D01gNr1L2Ma LvwNagl9VKFmb+/D6nQBPH3LJbb40OXlhjzlE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682501615; x=1685093615; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tiC1EixoNe9TvcsXGi4HMFFCigO3LAC2XK4QXXLhOuY=; b=OMbUZjvC584tyZWXjbkkcXevMSC8k99e1GFt1rqI7jJ3BM3iR+djjLafWuT4uG1Fyd 5p3NmKThxtYsE2RXMgAPKFh3BaQNMNMnCKRLF0jbAKaXVPAoSbdKv/OMZYaPuJPM1cZp JO61XBn0xduVRNlaGXFJSJBUo+tnnimyVXn2B33rFW8ikkb8OUL3HRHRTrRN6AkTtNrZ tg4QHCxWPlPRKT5CWULhiBFvxlNCs2aWmQLWF1l9jIjioYf8z3SYWB994b3TAygovEtV t5bQeELW1mvfvpuYTBvCqGYCMZ8tCHpzUtKUv9nTjV//L3qVbF5noJUUzafQ/sWTqUMq jr1A== X-Gm-Message-State: AAQBX9cUI3nF+QMBV9tCeHwlOz2oU6ESUTNU+7qroxsnt82tUjjmt0wq dDYgnjinpc5lk5tx+BG1pMS29w== X-Received: by 2002:a05:6a00:10cc:b0:63a:cefa:9d44 with SMTP id d12-20020a056a0010cc00b0063acefa9d44mr23043975pfu.14.1682501615312; Wed, 26 Apr 2023 02:33:35 -0700 (PDT) Received: from fshao-glinux.tpe.corp.google.com ([2401:fa00:1:10:dcf6:797f:140d:6d]) by smtp.gmail.com with ESMTPSA id g1-20020a056a00078100b005810c4286d6sm10730075pfu.0.2023.04.26.02.33.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Apr 2023 02:33:34 -0700 (PDT) From: Fei Shao To: Jeff LaBundy , Douglas Anderson , Benjamin Tissoires , Rob Herring Cc: linux-mediatek , Fei Shao , Dmitry Torokhov , Jiri Kosina , Krzysztof Kozlowski , Matthias Kaehlcke , Stephen Kitt , devicetree@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 0/2] Fix Goodix touchscreen power leakage for MT8186 boards Date: Wed, 26 Apr 2023 17:32:28 +0800 Message-ID: <20230426093231.1466984-1-fshao@chromium.org> X-Mailer: git-send-email 2.40.1.495.gc816e09b53d-goog MIME-Version: 1.0 X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764232374120250457?= X-GMAIL-MSGID: =?utf-8?q?1764232374120250457?= These changes are based on the series in [1], which modified the i2c-hid-of-goodix driver and removed the workaround for a power leakage issue, so the issue revisits on Mediatek MT8186 boards (Steelix). The root cause is that the touchscreen can be powered in different ways depending on the hardware designs, and it's not as easy to come up with a solution that is both simple and elegant for all the known designs. To address the issue, I ended up adding a new boolean property for the driver so that we can control the power up/down sequence depending on that. Adding a new property might not be the cleanest approach for this, but at least the intention would be easy enough to understand, and it introduces relatively small change to the code and fully preserves the original control flow. I hope this is something acceptable, and I'm open to any better approaches. [1] https://lore.kernel.org/all/20230207024816.525938-1-dianders@chromium.org/ Changes in v2: - Use a more accurate property name and with "goodix," prefix. - Do not change the regulator_enable logic during power-up. Fei Shao (2): dt-bindings: input: goodix: Add "goodix,no-reset-during-suspend" property HID: i2c-hid: goodix: Add support for "goodix,no-reset-during-suspend" property .../bindings/input/goodix,gt7375p.yaml | 9 +++++++ drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 26 +++++++++++++++++++ 2 files changed, 35 insertions(+)