mbox series

[v7,0/2] drm/i915: Hugepage manager and test for MTL

Message ID 20230425-hugepage-migrate-v7-0-fa6605a986c9@intel.com
Headers
Series drm/i915: Hugepage manager and test for MTL |

Message

Andrzej Hajda April 26, 2023, 3:14 p.m. UTC 
  This patchset patches sent by Jonathan and Andi, with 
addressed CI failures:
1. Fixed checking alignment of 64K pages on both Pre-Gen12 and Gen12.
2. Fixed start alignment of 2M pages.

Regards
Andrzej

Jonathan Cavitt (2):
  drm/i915: Migrate platform-dependent mock hugepage selftests to live
  drm/i915: Use correct huge page manager for MTL

.../gpu/drm/i915/gem/selftests/huge_pages.c   | 88 +++++++++++++++----
 drivers/gpu/drm/i915/gt/gen8_ppgtt.c          |  3 +-
 2 files changed, 71 insertions(+), 20 deletions(-)

Cc: intel-gfx@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org
Cc: Jonathan Cavitt <jonathan.cavitt@intel.com>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>

Comments

Cavitt, Jonathan April 26, 2023, 3:31 p.m. UTC | #1 
-----Original Message-----
From: Hajda, Andrzej <andrzej.hajda@intel.com> 
Sent: Wednesday, April 26, 2023 8:14 AM
To: intel-gfx@lists.freedesktop.org; linux-kernel@vger.kernel.org; Cavitt, Jonathan <jonathan.cavitt@intel.com>; Hajda, Andrzej <andrzej.hajda@intel.com>; Auld, Matthew <matthew.auld@intel.com>
Subject: [PATCH v7 0/2] drm/i915: Hugepage manager and test for MTL
>
>This patchset patches sent by Jonathan and Andi, with 
>addressed CI failures:
>1. Fixed checking alignment of 64K pages on both Pre-Gen12 and Gen12.
>2. Fixed start alignment of 2M pages.
>
>Regards
>Andrzej
>
>Jonathan Cavitt (2):
>  drm/i915: Migrate platform-dependent mock hugepage selftests to live
>  drm/i915: Use correct huge page manager for MTL
>
>.../gpu/drm/i915/gem/selftests/huge_pages.c   | 88 +++++++++++++++----
> drivers/gpu/drm/i915/gt/gen8_ppgtt.c          |  3 +-
> 2 files changed, 71 insertions(+), 20 deletions(-)
>
>Cc: intel-gfx@lists.freedesktop.org
>Cc: linux-kernel@vger.kernel.org
>Cc: Jonathan Cavitt <jonathan.cavitt@intel.com>
>Cc: Andrzej Hajda <andrzej.hajda@intel.com>
>Cc: Matthew Auld <matthew.auld@intel.com>
>-- 
>2.39.2
>
>---
>Jonathan Cavitt (2):
>      drm/i915: Migrate platform-dependent mock hugepage selftests to live
>      drm/i915: Use correct huge page manager for MTL
>
> drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 105 ++++++++++++++++++------
> drivers/gpu/drm/i915/gt/gen8_ppgtt.c            |   3 +-
> 2 files changed, 82 insertions(+), 26 deletions(-)
>---
>base-commit: 4d0066a1c0763d50b6fb017e27d12b081ce21b57
>change-id: 20230425-hugepage-migrate-1869aaf31a6d
>
>Best regards,
>-- 
>Andrzej Hajda <andrzej.hajda@intel.com>


Just reviewed the changes proper.  It's been a while, so I don't remember everything
about the prior version, but I think I recognized what was changed:

- I wasn't aware a 21 bit alignment was required for 2M page sizes.  I'm glad you caught that.
- The extra debugging/error information will be helpful in the case of a failure.
- Grabbing the per-context VM instead of the ppgtt vm sounds good to me.

Everything here looks amenable.
Acked-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Though, given I'm also one of the signed-off-bys, I don't know if me acking it is exactly above-board.
-Jonathan Cavitt


>
Andrzej Hajda April 26, 2023, 9:36 p.m. UTC | #2 
On 26.04.2023 17:31, Cavitt, Jonathan wrote:
> -----Original Message-----
> From: Hajda, Andrzej <andrzej.hajda@intel.com>
> Sent: Wednesday, April 26, 2023 8:14 AM
> To: intel-gfx@lists.freedesktop.org; linux-kernel@vger.kernel.org; Cavitt, Jonathan <jonathan.cavitt@intel.com>; Hajda, Andrzej <andrzej.hajda@intel.com>; Auld, Matthew <matthew.auld@intel.com>
> Subject: [PATCH v7 0/2] drm/i915: Hugepage manager and test for MTL
>> This patchset patches sent by Jonathan and Andi, with
>> addressed CI failures:
>> 1. Fixed checking alignment of 64K pages on both Pre-Gen12 and Gen12.
>> 2. Fixed start alignment of 2M pages.
>>
>> Regards
>> Andrzej
>>
>> Jonathan Cavitt (2):
>>   drm/i915: Migrate platform-dependent mock hugepage selftests to live
>>   drm/i915: Use correct huge page manager for MTL
>>
>> .../gpu/drm/i915/gem/selftests/huge_pages.c   | 88 +++++++++++++++----
>> drivers/gpu/drm/i915/gt/gen8_ppgtt.c          |  3 +-
>> 2 files changed, 71 insertions(+), 20 deletions(-)
>>
>> Cc: intel-gfx@lists.freedesktop.org
>> Cc: linux-kernel@vger.kernel.org
>> Cc: Jonathan Cavitt <jonathan.cavitt@intel.com>
>> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
>> Cc: Matthew Auld <matthew.auld@intel.com>
>> -- 
>> 2.39.2
>>
>> ---
>> Jonathan Cavitt (2):
>>       drm/i915: Migrate platform-dependent mock hugepage selftests to live
>>       drm/i915: Use correct huge page manager for MTL
>>
>> drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 105 ++++++++++++++++++------
>> drivers/gpu/drm/i915/gt/gen8_ppgtt.c            |   3 +-
>> 2 files changed, 82 insertions(+), 26 deletions(-)
>> ---
>> base-commit: 4d0066a1c0763d50b6fb017e27d12b081ce21b57
>> change-id: 20230425-hugepage-migrate-1869aaf31a6d
>>
>> Best regards,
>> -- 
>> Andrzej Hajda <andrzej.hajda@intel.com>
>
> Just reviewed the changes proper.  It's been a while, so I don't remember everything
> about the prior version, but I think I recognized what was changed:
>
> - I wasn't aware a 21 bit alignment was required for 2M page sizes.  I'm glad you caught that.
> - The extra debugging/error information will be helpful in the case of a failure.
> - Grabbing the per-context VM instead of the ppgtt vm sounds good to me.
>
> Everything here looks amenable.
> Acked-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> Though, given I'm also one of the signed-off-bys, I don't know if me acking it is exactly above-board.
> -Jonathan Cavitt

Thanks for looking at it. CI spotted another issue: 2M pages are 
preferred over old-64K, if former are available.
Fixed version sent.
Regarding tags, I've kept your authorship, s-o-b, and added my 
Co-developed, if it is OK to you I will keep it this way.
If you prefer otherwise let me know.

Regards
Andrzej

>
Cavitt, Jonathan April 26, 2023, 9:39 p.m. UTC | #3 
-----Original Message-----
From: Hajda, Andrzej <andrzej.hajda@intel.com> 
Sent: Wednesday, April 26, 2023 2:37 PM
To: Cavitt, Jonathan <jonathan.cavitt@intel.com>; intel-gfx@lists.freedesktop.org; linux-kernel@vger.kernel.org; Auld, Matthew <matthew.auld@intel.com>
Subject: Re: [PATCH v7 0/2] drm/i915: Hugepage manager and test for MTL
>
>On 26.04.2023 17:31, Cavitt, Jonathan wrote:
>> -----Original Message-----
>> From: Hajda, Andrzej <andrzej.hajda@intel.com>
>> Sent: Wednesday, April 26, 2023 8:14 AM
>> To: intel-gfx@lists.freedesktop.org; linux-kernel@vger.kernel.org; Cavitt, Jonathan <jonathan.cavitt@intel.com>; Hajda, Andrzej <andrzej.hajda@intel.com>; Auld, Matthew <matthew.auld@intel.com>
>> Subject: [PATCH v7 0/2] drm/i915: Hugepage manager and test for MTL
>>> This patchset patches sent by Jonathan and Andi, with
>>> addressed CI failures:
>>> 1. Fixed checking alignment of 64K pages on both Pre-Gen12 and Gen12.
>>> 2. Fixed start alignment of 2M pages.
>>>
>>> Regards
>>> Andrzej
>>>
>>> Jonathan Cavitt (2):
>>>   drm/i915: Migrate platform-dependent mock hugepage selftests to live
>>>   drm/i915: Use correct huge page manager for MTL
>>>
>>> .../gpu/drm/i915/gem/selftests/huge_pages.c   | 88 +++++++++++++++----
>>> drivers/gpu/drm/i915/gt/gen8_ppgtt.c          |  3 +-
>>> 2 files changed, 71 insertions(+), 20 deletions(-)
>>>
>>> Cc: intel-gfx@lists.freedesktop.org
>>> Cc: linux-kernel@vger.kernel.org
>>> Cc: Jonathan Cavitt <jonathan.cavitt@intel.com>
>>> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
>>> Cc: Matthew Auld <matthew.auld@intel.com>
>>> -- 
>>> 2.39.2
>>>
>>> ---
>>> Jonathan Cavitt (2):
>>>       drm/i915: Migrate platform-dependent mock hugepage selftests to live
>>>       drm/i915: Use correct huge page manager for MTL
>>>
>>> drivers/gpu/drm/i915/gem/selftests/huge_pages.c | 105 ++++++++++++++++++------
>>> drivers/gpu/drm/i915/gt/gen8_ppgtt.c            |   3 +-
>>> 2 files changed, 82 insertions(+), 26 deletions(-)
>>> ---
>>> base-commit: 4d0066a1c0763d50b6fb017e27d12b081ce21b57
>>> change-id: 20230425-hugepage-migrate-1869aaf31a6d
>>>
>>> Best regards,
>>> -- 
>>> Andrzej Hajda <andrzej.hajda@intel.com>
>>
>> Just reviewed the changes proper.  It's been a while, so I don't remember everything
>> about the prior version, but I think I recognized what was changed:
>>
>> - I wasn't aware a 21 bit alignment was required for 2M page sizes.  I'm glad you caught that.
>> - The extra debugging/error information will be helpful in the case of a failure.
>> - Grabbing the per-context VM instead of the ppgtt vm sounds good to me.
>>
>> Everything here looks amenable.
>> Acked-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
>> Though, given I'm also one of the signed-off-bys, I don't know if me acking it is exactly above-board.
>> -Jonathan Cavitt
>
>Thanks for looking at it. CI spotted another issue: 2M pages are 
>preferred over old-64K, if former are available.
>Fixed version sent.
>Regarding tags, I've kept your authorship, s-o-b, and added my 
>Co-developed, if it is OK to you I will keep it this way.
>If you prefer otherwise let me know.

That is entirely acceptable!  Thank you for your time.
-Jonathan Cavitt

>
>Regards
>Andrzej
>
>>
>
>