From patchwork Mon Apr 24 13:35:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 8599 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2760449vqo; Mon, 24 Apr 2023 06:53:15 -0700 (PDT) X-Google-Smtp-Source: AKy350b73hBF/b/JYLUC/pdQBYMHqa+eJ25QjVc5iLf10t8RpaIcHoXfCOaFFPCDkZBsj6okwu+R X-Received: by 2002:a05:6a20:4281:b0:f0:7ac1:ea61 with SMTP id o1-20020a056a20428100b000f07ac1ea61mr18535540pzj.6.1682344395188; Mon, 24 Apr 2023 06:53:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682344395; cv=none; d=google.com; s=arc-20160816; b=BC+l/KzlyRurlo9UAn6LOfaBciukrFrjRmM+Guwmlvs286IFMjq91Ca9uIXFmI28VA ZavQtjtOE+92bAJApVeSbcovV9OWnojs58iiK54ouBXNmmUyQGdJ8SIzQ9Xlg+rSjSj9 HT0LsV65Ljs8V7893hUo3X1Ffwx66aiThWzNW28WztF+bQ9UTZ3SJ0l9pfFS7JIwqblH +L4tQ5fV2MnIpDA2924IJHgZ3zq4wTLro8F5mi+6ANuzHuFsbBgA9bgn0Zy5i78MYJTK kqEHNU21/o1xUroS07uJ+mHHMVj/hPgZLhQ0O5owm0+Vs4vEw5Z/SM6SNSHt8lHBnkBR cs/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=AA3YEyFAmBd+TNpZ+PwN1MVwsAOH+GXGPlxXoNzFjD4=; b=F6BEPx4etBvsDHjCr9gD6tq77rMvv+Vr9+6rfdwPv0PblVIxXyURs255JBb2+rzTyj eZH0SuXZwQzVM6bnw7IvsJUpfbBJ61rh1U7hFMuWqGQFjER0gRMM58AvdJrGngPiE/c0 0IqmWXauQ5QSckSCXce0is4szLCTxrI4CAAg3p8JDCvDfw04I06ffnqeJVoR92mbcNCA nF1Orhye7cuhlKerfuCbDF3gVfUgzkLpIrjYNPxrAOqT6+IeOOG/Q1Q6P2fs17k3A5N/ bi3jNsikV1RReog8BV0a5khDz4buowSSSNQ7I+a5nst1Nkdq/w8c909pmP+crMhuq7a3 joug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=c63FNuRh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r20-20020a6560d4000000b0050bdfdf4a66si10418728pgv.147.2023.04.24.06.53.01; Mon, 24 Apr 2023 06:53:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=c63FNuRh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232638AbjDXNgB (ORCPT + 99 others); Mon, 24 Apr 2023 09:36:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232613AbjDXNfp (ORCPT ); Mon, 24 Apr 2023 09:35:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FF1C86A9; Mon, 24 Apr 2023 06:35:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 29EB5623DF; Mon, 24 Apr 2023 13:35:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82BC0C433A7; Mon, 24 Apr 2023 13:35:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682343335; bh=y75lIJf876GxKiQkHIBiRfNRr/Wh0exyC294HWMMYSY=; h=From:To:Cc:Subject:Date:From; b=c63FNuRh+ltANDc9x1c2RV4jMvPfo8O4kXdC8p/oHFQtXWMmmBTdsV+i1QB2weBhs y3SNmnOoaww2SMmteRuoOGkdquo4UWnhvUd7SJa0OqjocVFJeDqsELAR5AEDYFQbbR aqcCqgaY1AmwCSnSo3qnSdE7y9mzWeVcZc1lq8J2rOoyfFof6WRn8gclL59ibAUbuU sRy8HwSdYGEc2fRqD25vYpzOi0wKMq1BxUbi2dy/WkGv6QTTja8LK5asLZbhUiIIwi 5mEt+540mtlNEL8FG8E+6rEpXNLu7frMwAhubw8MhiuB4pwt4Aa1oYOZGrlT017+UK seWfrKpO9w6qA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pqwMB-0003kG-EN; Mon, 24 Apr 2023 15:35:52 +0200 From: Johan Hovold To: Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz Cc: Matthias Kaehlcke , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Johan Hovold Subject: [PATCH 0/2] Bluetooth: fix bdaddr quirks Date: Mon, 24 Apr 2023 15:35:40 +0200 Message-Id: <20230424133542.14383-1-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764065956548677649?= X-GMAIL-MSGID: =?utf-8?q?1764065956548677649?= These patches fixes a couple of issues with the two bdaddr quirks: The first one allows HCI_QUIRK_INVALID_BDADDR to be used with HCI_QUIRK_NON_PERSISTENT_SETUP. The second patch restores the original semantics of the HCI_QUIRK_USE_BDADDR_PROPERTY so that the controller is marked as unconfigured when no device address is specified in the devicetree (as the quirk is documented to work). This specifically makes sure that Qualcomm HCI controllers such as wcn6855 found on the Lenovo X13s are marked as unconfigured until user space has provided a valid address. Long term, the HCI_QUIRK_USE_BDADDR_PROPERTY should probably be dropped in favour of HCI_QUIRK_INVALID_BDADDR and always checking the devicetree property. Johan Johan Hovold (2): Bluetooth: fix invalid-bdaddr quirk for non-persistent setup Bluetooth: fix use-bdaddr-property quirk net/bluetooth/hci_sync.c | 30 +++++++++++------------------- 1 file changed, 11 insertions(+), 19 deletions(-)