From patchwork Mon Apr 24 12:48:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 8595 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2719300vqo; Mon, 24 Apr 2023 05:51:23 -0700 (PDT) X-Google-Smtp-Source: AKy350aZIvgsAwODHjperHsC4zS0QSOKikDuUxkXBzNQeCS8gUanbC2YaWXt3viiOYSCVTuaKbx9 X-Received: by 2002:a05:6a20:9185:b0:ef:a31b:af86 with SMTP id v5-20020a056a20918500b000efa31baf86mr17975241pzd.27.1682340682664; Mon, 24 Apr 2023 05:51:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682340682; cv=none; d=google.com; s=arc-20160816; b=kYmFsx5KzXGaDxzz1E2tRShVng+iHRuF7d3jO4GqUKU+OpM9Ets8yB1CASBw/AWhiv I9etA2vP2rCJpwpg7gRt8LlHNGIFkxAYKRUfxNYeG+NI/mFtPd6mVEa4PbWXjmU5xdfo 3aFSJfs0IhoEQQC6rrYI01wqe1ibY+M8VqfaIcU5AF+03zbUb7siMKt+ewtQLL6Dk/PR ajsLknZlX0CFPOfo93Sx6cZYemwukzaFo2upJlXX7KwXpkTMFuSdIzAIZO9nq6xSXW/u S8ssnSMNHzP2exlTUM1va2xojHYvE9e3XhQVRvajwWk+CaFyQwr9oPHVWhZKG1SeUYKZ kAPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=iFzF5bUK9c1BXSxMHdmktnQX4oHFbua65Z/dD3B7nOc=; b=CrpiFeaJmMct7dtihEnRT60ZBBvnObIsW1LfuW+fm0q5gDHU2tOmcZZBpFC4/OsBuN CfkNJs5nGah6GwbnuXZfnWxgeEb5De38zc4s/grPWpGHnhkR9Pi8Dy4SGEo+IvGLzcn+ GHjkbApHjBXwlaoML57UlE3kYUlF06s1YHvM4DE1FmD/Mlx7t/bzPOKjkTDdN3GPUU2Z jSkHFUOeabEJTqF8bYVNWXtMqFVFwVF6cl2ivgFjot6iBACtovAg4ltqN4MY0ojFA8+L cLUhHA/9jPQlMKs1BNgMNgj2bDJFChkaNhNUNSVS7bSK4EuXAGtkrALk18e5FDqqPsj5 PW8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VwaRvpwo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f11-20020aa79d8b000000b0063c56f195b5si11123314pfq.122.2023.04.24.05.51.10; Mon, 24 Apr 2023 05:51:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VwaRvpwo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231785AbjDXMuX (ORCPT + 99 others); Mon, 24 Apr 2023 08:50:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231293AbjDXMuV (ORCPT ); Mon, 24 Apr 2023 08:50:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C721749FF; Mon, 24 Apr 2023 05:50:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5BF5E61557; Mon, 24 Apr 2023 12:50:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAE56C4339C; Mon, 24 Apr 2023 12:50:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682340602; bh=0rJK3cwH3zFbaELWMscdo/xtWlXrXcTBDQUPOZjTeYg=; h=From:To:Cc:Subject:Date:From; b=VwaRvpwo89ywpoBeHmigT77cjaiQaz879A1GWXTurHnrnMFNh+osJZx8itQC0NDCV L6rWHOnmMCdpctxCfJ8TwKdOnjoC+cRQ5jRidq7pvyII5V6kjFLvJLsb/jYsUFsPJA 9JLLJOPRu1A+uR+Zv6EUCaAkHMfrHOXATaBotY95rRiiYjiRYh8XDtDbLt2ZMnKNU0 m44zALqL6rfoj2PXLD78I3vOErRNE1cWETirEwovQaUrc2b4oWKzXi6x6UI0x8xrq1 PvCi1HSd8XLy2sSej/UHqPS5wtRZTm78plkpdoKKHOmXhG2I7gErUuLJMnRF68Lv+2 B8UHsUexxOoWg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pqve6-0003IV-D8; Mon, 24 Apr 2023 14:50:19 +0200 From: Johan Hovold To: Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Johan Hovold Subject: [PATCH 0/2] Bluetooth: fix debugfs registration Date: Mon, 24 Apr 2023 14:48:50 +0200 Message-Id: <20230424124852.12625-1-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764062063725402722?= X-GMAIL-MSGID: =?utf-8?q?1764062063725402722?= The HCI controller debugfs interface is created during setup or when a controller is configured, but there is nothing preventing a controller from being configured multiple times (e.g. by setting the device address), which results in a host of errors in the logs: debugfs: File 'features' in directory 'hci0' already present! debugfs: File 'manufacturer' in directory 'hci0' already present! debugfs: File 'hci_version' in directory 'hci0' already present! ... debugfs: File 'quirk_simultaneous_discovery' in directory 'hci0' already present! The Qualcomm driver suffers from a related problem for controllers with non-persistent setup. Johan Johan Hovold (2): Bluetooth: fix debugfs registration Bluetooth: hci_qca: fix debugfs registration drivers/bluetooth/hci_qca.c | 6 +++++- include/net/bluetooth/hci.h | 1 + net/bluetooth/hci_sync.c | 3 +++ 3 files changed, 9 insertions(+), 1 deletion(-)