mbox series

[v2,0/2] PCI: pciehp: Add support for native AER and DPC handling on async remove

Message ID 20230418210526.36514-1-Smita.KoralahalliChannabasappa@amd.com
Headers
Series PCI: pciehp: Add support for native AER and DPC handling on async remove |

Message

Smita Koralahalli April 18, 2023, 9:05 p.m. UTC 
  This series of patches adds native support to handle AER and DPC/EDR events
occurred as a side-effect on an async remove.

Link to v1:
https://lore.kernel.org/all/20221101000719.36828-1-Smita.KoralahalliChannabasappa@amd.com/

Smita Koralahalli (2):
  PCI: pciehp: Add support for async hotplug with native AER and DPC/EDR
  PCI: pciehp: Clear the optional capabilities in DEVCTL2 on a hot-plug

 drivers/pci/hotplug/pciehp_pci.c |  1 +
 drivers/pci/pcie/dpc.c           | 50 ++++++++++++++++++++++++++++++++
 2 files changed, 51 insertions(+)

Comments

Smita Koralahalli May 9, 2023, 8:58 p.m. UTC | #1 
Hi,

Could I please get review comments on my patch set? I had re-based it on 
latest tree
in v2 as I did not hear back on my questions in v1.

Thanks,
Smita

On 4/18/2023 2:05 PM, Smita Koralahalli wrote:
> This series of patches adds native support to handle AER and DPC/EDR events
> occurred as a side-effect on an async remove.
>
> Link to v1:
> https://lore.kernel.org/all/20221101000719.36828-1-Smita.KoralahalliChannabasappa@amd.com/
>
> Smita Koralahalli (2):
>    PCI: pciehp: Add support for async hotplug with native AER and DPC/EDR
>    PCI: pciehp: Clear the optional capabilities in DEVCTL2 on a hot-plug
>
>   drivers/pci/hotplug/pciehp_pci.c |  1 +
>   drivers/pci/pcie/dpc.c           | 50 ++++++++++++++++++++++++++++++++
>   2 files changed, 51 insertions(+)
>
Bjorn Helgaas June 12, 2023, 5:54 p.m. UTC | #2 
On Tue, May 09, 2023 at 01:58:37PM -0700, Smita Koralahalli wrote:
> Hi,
> 
> Could I please get review comments on my patch set? I had re-based
> it on latest tree in v2 as I did not hear back on my questions in
> v1.

Thanks for persevering.  It looks like there may still be some ongoing
discussion with Lukas?  And a few of his comments that you plan to
address?  Thanks for looking into the 10-bit tag issue.  I know those
tag widths are non-trivial to handle correctly and it would be good to
clean them up.

Bjorn
Smita Koralahalli June 12, 2023, 7:31 p.m. UTC | #3 
On 6/12/2023 10:54 AM, Bjorn Helgaas wrote:
> On Tue, May 09, 2023 at 01:58:37PM -0700, Smita Koralahalli wrote:
>> Hi,
>>
>> Could I please get review comments on my patch set? I had re-based
>> it on latest tree in v2 as I did not hear back on my questions in
>> v1.
> 
> Thanks for persevering.  It looks like there may still be some ongoing
> discussion with Lukas?  And a few of his comments that you plan to
> address?  Thanks for looking into the 10-bit tag issue.  I know those
> tag widths are non-trivial to handle correctly and it would be good to
> clean them up.
> 
> Bjorn

Yeah. Since we didn't come to a conclusion on how should we attempt 
clearing 10-bit tags and Atomic Op Requestor, I held on preparing v3.

https://lore.kernel.org/all/cc36bb5b-6a4a-258b-6707-4d019154e019@amd.com/

But I can go ahead and send v3 for just the first patch, 
https://lore.kernel.org/all/8ab986f2-6aa5-401a-aa21-e8b21f68eaad@amd.com/ and 
wait on Lukas for 10-bit tag issue.

Thanks,
Smita