Message ID | 20230418190101.696345-1-pranavpp@google.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp3065140vqo; Tue, 18 Apr 2023 12:03:02 -0700 (PDT) X-Google-Smtp-Source: AKy350Y3eYujgL/GSyv0uEkYEJfbMA1lKXIi2wiE0JqdFFMFuA9D/Sn/LY5E8TrUFhyqLC1fKWfR X-Received: by 2002:a17:903:294c:b0:1a1:ca37:5257 with SMTP id li12-20020a170903294c00b001a1ca375257mr2596364plb.7.1681844582352; Tue, 18 Apr 2023 12:03:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681844582; cv=none; d=google.com; s=arc-20160816; b=GYh2tv+auM1CMI7+jc3SZWsUo7j/0TsVjCDaiUoEL0Ij6Sk3FF3SyVuegj47OJMzln DZPWWzT+bEi8hfknf8gGlFeK4JsZJuaRfx0sOE6+zTW+ZGd7IcQi2VdLeE+903GQtUoK WvR/mf3iznsnQLN1IZV1t9v94CKFle2j0jumUG1GwrwriPIroLcLUXynryNySvXAfpdW Vs98ZsXKcdi92eG+NcU8sW8cc1Zn0RT8xviylJHI4wy2asjI04SNm0SWPKimRI5uKBL5 1PPu1frMVDi97s51s941VKSTDSkVr638JH0cWgRFdn96tlmGSPJYJeMzl9nwI/ZgI+eA TJAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:mime-version:date :dkim-signature; bh=AAeeT3p1vaSWYTnW7BRdrG3feIz/DGLDWlUjJoHLVqg=; b=uNzBdpZE2n+3fZcDfZoGZqZbkh4bDw76BRRRQSEoEbDJg/LhQslWCgk3Lolf72/ecD O6rpAj4IHahtpnBLDTpyTtceTHziAE7R5QdFlOPKL/jlIDdyMHl6h6gE9GglXAVAjCOC /F5T2oPWt1BCe87LVhfGgQxaUq1/QXWzxCNt6rWNLzbYBo9xjoLg6laki4LwF1pN+003 Y1hX9XdwCxm73xZ13Dy4uLjKnnn+LVmxL+HyVUVDgKrlGWze1rxZkIR16jSe8HtQciEX thpGSE9++bherP7a0TO0kXT65xprjuH1JnYSTpMP3fj7Bo4SfJPnQgNIISi56p6s/qe7 XDPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=OwcDT7LO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l8-20020a170902f68800b001a6828a19c7si9396218plg.555.2023.04.18.12.02.48; Tue, 18 Apr 2023 12:03:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=OwcDT7LO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231135AbjDRTBv (ORCPT <rfc822;peter110.wang@gmail.com> + 99 others); Tue, 18 Apr 2023 15:01:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231168AbjDRTBt (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 18 Apr 2023 15:01:49 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13D187A80 for <linux-kernel@vger.kernel.org>; Tue, 18 Apr 2023 12:01:48 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-552d922f0faso55364177b3.14 for <linux-kernel@vger.kernel.org>; Tue, 18 Apr 2023 12:01:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1681844507; x=1684436507; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=AAeeT3p1vaSWYTnW7BRdrG3feIz/DGLDWlUjJoHLVqg=; b=OwcDT7LOzlCFAeu0xRaCl7iUIBd5PDxPpFkmbfuqYKYvBTruGDFXFp3O7cfM3AFN0u y5tqel0Qb/FfiyxXiUCJCM7vp9+2nTofXH3eCB0bjBxrKaNRfKYsKIakhNcS1CyAI6Id HugV8UdOjVW8CwD4QuOkKLUkdfhdM/bk6RZoeBOBHb0zhKekacXL1LREoUip2WvdCokp KEPA4SecxTOWXfNVprmQYD04fK+rfDv+RcV0uXpu7jQ5DBnKW7ywivcPjcQE5MpShmLt KkFvYQs+22HIFvBj2ukr/uHMcvoxadq97exOY+QyT9Zj/oH7DCCXXNCg058YV3N58dp4 vVCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681844507; x=1684436507; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=AAeeT3p1vaSWYTnW7BRdrG3feIz/DGLDWlUjJoHLVqg=; b=BVvb76uF/20PGKeguMuferXtdwGwWypaedjzegBmEKZK0wRczdsYUgOAvqbYDcG/qH +Rkmpuv6UNJ5ASmnKfGBie5lXIqrvWMEsgoa7uvHEU3pDouFyWVS5advZnMpGZ96BIo3 Cb2fYEkICOcgrjJvIWHfnJw0jSUJbdOYl+n3jtPeJxd0RwC118bSbFhRwkDodgmiryMQ TIjSbpM8Iff3Qhaneh0gS0CLgwKkUPTEHsdqlyEcXbMZsPwgd7fu4Q8uNcZUsfCpKKOd KeYql0CQrH4bgNGh1lg83oQNrxMevV4mgq4jR138c9Q0ALribB38TSl6Rn6A4VSZSNHo MtaQ== X-Gm-Message-State: AAQBX9dyGWqFhf5ctFfoelvP4Se97btMQomMzIJTA5a6Y5FDNVoG5HBz 6OiziCdLh/KqU50BfowHSiFhKwMaw1dCAg== X-Received: from pranav-first.c.googlers.com ([fda3:e722:ac3:cc00:24:72f4:c0a8:390b]) (user=pranavpp job=sendgmr) by 2002:a0d:ec43:0:b0:541:8285:b25 with SMTP id r3-20020a0dec43000000b0054182850b25mr467702ywn.10.1681844507277; Tue, 18 Apr 2023 12:01:47 -0700 (PDT) Date: Tue, 18 Apr 2023 19:00:55 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.40.0.634.g4ca3ef3211-goog Message-ID: <20230418190101.696345-1-pranavpp@google.com> Subject: [PATCH 0/6] scsi: pm80xx: Enhanced debug logs for HW events From: Pranav Prasad <pranavpp@google.com> To: Jack Wang <jinpu.wang@cloud.ionos.com>, "James E . J . Bottomley" <jejb@linux.ibm.com>, "Martin K . Petersen" <martin.petersen@oracle.com> Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Pranav Prasad <pranavpp@google.com> Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763541864691766675?= X-GMAIL-MSGID: =?utf-8?q?1763541864691766675?= |
Series |
scsi: pm80xx: Enhanced debug logs for HW events
|
|
Message
Pranav Prasad
April 18, 2023, 7 p.m. UTC
This patch series enhances debug logs for pm80xx HW events, and provides a minor fix in the case of a hard reset. The log enhancement involves changing the log severity level to enable logging for HW events which consequently help debug disk discovery issues. 1. Changed log severity level from MSG to EVENT for HW events. Enhanced the HW event logs by adding the phyid. 2. Enabled INIT logging. 3. Log portid along with the PHY_UP event. 4. Print phyid and portid sent as part of device registration request. 5. Log port state during HW events. 6. Update phy_state and phy_attached to correct values after a hard reset. Akshat Jain (5): scsi: pm80xx: Enable init logging scsi: pm80xx: Print port_id in hardware events scsi: pm80xx: Log phyid and portid device register request scsi: pm80xx: Log port state during HW event scsi: pm80xx: Log some HW events by default Changyuan Lyu (1): scsi: pm80xx: Update PHY state after hard reset drivers/scsi/pm8001/pm8001_init.c | 3 +- drivers/scsi/pm8001/pm8001_sas.h | 1 + drivers/scsi/pm8001/pm80xx_hwi.c | 126 +++++++++++++++++++----------- 3 files changed, 85 insertions(+), 45 deletions(-)
Comments
Pranav, > This patch series enhances debug logs for pm80xx HW events, and > provides a minor fix in the case of a hard reset. The log enhancement > involves changing the log severity level to enable logging for HW > events which consequently help debug disk discovery issues. Applied to 6.5/scsi-staging, thanks!
On Tue, 18 Apr 2023 19:00:55 +0000, Pranav Prasad wrote: > This patch series enhances debug logs for pm80xx HW events, and provides > a minor fix in the case of a hard reset. The log enhancement involves > changing the log severity level to enable logging for HW events > which consequently help debug disk discovery issues. > > 1. Changed log severity level from MSG to EVENT for HW events. > Enhanced the HW event logs by adding the phyid. > > [...] Applied to 6.5/scsi-queue, thanks! [1/6] scsi: pm80xx: Log some HW events by default https://git.kernel.org/mkp/scsi/c/b7d26c1d8c51 [2/6] scsi: pm80xx: Enable init logging https://git.kernel.org/mkp/scsi/c/6a516506aad6 [3/6] scsi: pm80xx: Print port_id in HW events https://git.kernel.org/mkp/scsi/c/a6cf6b8bd6e2 [4/6] scsi: pm80xx: Log phy_id and port_id in the device registration request https://git.kernel.org/mkp/scsi/c/5f797120d853 [5/6] scsi: pm80xx: Log port state during HW event https://git.kernel.org/mkp/scsi/c/d309422d7dc6 [6/6] scsi: pm80xx: Update PHY state after hard reset https://git.kernel.org/mkp/scsi/c/3aa65f7e25ac