From patchwork Tue Apr 18 12:49:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fei Shao X-Patchwork-Id: 8364 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2833129vqo; Tue, 18 Apr 2023 06:07:48 -0700 (PDT) X-Google-Smtp-Source: AKy350YDB79tFpO2o+NaI1QhyCuaf7vosgA9apDET/0ddDnxSZ/12v5AhzVJkJMgcsbZv00wN+0H X-Received: by 2002:a05:6a00:2316:b0:63d:2aac:7b88 with SMTP id h22-20020a056a00231600b0063d2aac7b88mr6277448pfh.25.1681823268116; Tue, 18 Apr 2023 06:07:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681823268; cv=none; d=google.com; s=arc-20160816; b=VZ7Dh8NV8wsyVA+wH32eLs8KrwbyJ6SvSIq5HrptW7hpG6/7OHzjzUgiGRpmPkR8qb 4bdM04eRQ4gautg9NGmBfM5rO1PIwVkej8FatY0BtjFgLypLpXcxeo64K88brqu+YxmJ bMz8z5PZmeNvfx145YXLTrDRbJOK3RcWGTOEF2OAz8Jy3mymmk32XA59qNxreNKWmNyp qvWHuikOuiTDHvVfcv2R3eMy2AFtf3K1tPQ02vpxsq160NQwXrUElAfAeVX1ZhsjDvBx 05IDaH07tqgj3nbuQ6WKQjsElQ72+T+PTe0OkvnyqrnUU4zYb1pUFtvA+k3CSeNH/uT2 mBkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=UvYQl2dSNs2drI6x+tVSTFEOpl8Z5ePoGgWVyp9WoW4=; b=Hq1Y3iZyxSAzR3ONbYIy+tPCDMWIgeHJzuGXF+3RBCtzo83gL9Yk2sO4mLLDjZ2yA0 lWpo9J8FjBR/DfZ8G2crAIUfiQ6KyxQeTUjeWTZ/t4jeZcd5qaplj4NCe+ba5i381pla I9IeKJ/Fi4y+eC43yO8mYbwDi/2nRGyXkTE6XBcpLDuDw8r5HUILc3UVaDIWKc2B/BGM gx08V194WXKLc74On/uREfFq7h22yGOCtsR+o5EoFBhBeGjDuOEWjjSWchf96jYJDKBm oDe3Wlq1ZFkQ2PKrUrnUTrjVpTdxUwHT+6B1TVJbHl5rxdn5LDCa1QVjrqXydbK3DQwz qfBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=lO293Bhj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r16-20020a635150000000b005143d5f9ff0si13617379pgl.357.2023.04.18.06.07.24; Tue, 18 Apr 2023 06:07:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=lO293Bhj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232163AbjDRMvA (ORCPT + 99 others); Tue, 18 Apr 2023 08:51:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232050AbjDRMu6 (ORCPT ); Tue, 18 Apr 2023 08:50:58 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1360316B13 for ; Tue, 18 Apr 2023 05:50:45 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id l21so9970085pla.5 for ; Tue, 18 Apr 2023 05:50:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1681822244; x=1684414244; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=UvYQl2dSNs2drI6x+tVSTFEOpl8Z5ePoGgWVyp9WoW4=; b=lO293BhjwNYLclYsjSpzyyLDt218sTOzbWEbdzTmjP4dBWHVcxa87ECW84PUQ2/B5B jBQjO399/tOmeIpg/xIuV/QbyYVsIOx3a6SoDkdh4AOW0IJNhE+whTdu8n7gx4krMy9w zTyAltktrrl8zLKmZZq+3s+/gQGCDL/kNppiU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681822244; x=1684414244; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UvYQl2dSNs2drI6x+tVSTFEOpl8Z5ePoGgWVyp9WoW4=; b=cEaYJITLoQuJhVczc3zutncLtZETaUBEX0s/aF3yFwKfuBvOx0hI2FQSFbYEqiTMX+ b4NIqMitZ+jNNAyXUxwJ+NwuSbGMiU7CA8UEdfFHZZX8YTt+FLa9SgC1EM0A+H6RDf8N ERb9xtKwlnUhDafZxjYUfM5ed0ENQGmtUCR43nog767EmnIUY0/3hpHeLh9eZLvVghwq 050fNLdEVujMBsRdOaFV2hWnlJuNTuMp/OvyzjcAefpV++de0XijcD3emOeq0ljmol06 t90DQxiig4wyotkMS3ayHoQ33EpEC8xXAdUv01PDYkEgyFdB0Y2FOdc1RlVEHAyHNQiu Rgig== X-Gm-Message-State: AAQBX9cpeKN92HvARi27HNymibz6ShLyad9mtTQJkNVH1vfaVyCN8gj+ 8ZVmjEw2vjvt1QI6zM2UmBdEJA== X-Received: by 2002:a05:6a21:32a2:b0:ee:3e4f:eecd with SMTP id yt34-20020a056a2132a200b000ee3e4feecdmr17968088pzb.38.1681822244288; Tue, 18 Apr 2023 05:50:44 -0700 (PDT) Received: from fshao-glinux.tpe.corp.google.com ([2401:fa00:1:10:2fb7:301d:6083:752b]) by smtp.gmail.com with ESMTPSA id v11-20020a62a50b000000b0063afb08afeesm9323733pfm.67.2023.04.18.05.50.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Apr 2023 05:50:43 -0700 (PDT) From: Fei Shao To: Benjamin Tissoires , Douglas Anderson , Rob Herring Cc: linux-mediatek , Fei Shao , Dmitry Torokhov , Jiri Kosina , Krzysztof Kozlowski , Matthias Kaehlcke , Stephen Kitt , devicetree@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/2] Fix Goodix touchscreen power leakage for MT8186 boards Date: Tue, 18 Apr 2023 20:49:50 +0800 Message-ID: <20230418124953.3170028-1-fshao@chromium.org> X-Mailer: git-send-email 2.40.0.634.g4ca3ef3211-goog MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763519514957850826?= X-GMAIL-MSGID: =?utf-8?q?1763519514957850826?= These changes are based on the series in [1], which modified the i2c-hid-of-goodix driver and removed the workaround for a power leakage issue, so the issue revisits on Mediatek MT8186 boards (Steelix). The root cause is that the touchscreen can be powered in different ways depending on the hardware designs, and it's not as easy to come up with a solution that is both simple and elegant for all the known designs. To address the issue, I ended up adding a new boolean property for the driver so that we can control the power up/down sequence depending on that. Adding a new property might not be the cleanest approach for this, but at least the intention would be easy enough to understand, and it introduces relatively small change to the code and fully preserves the original control flow. I hope this is something acceptable, and I'm open to any better approaches. [1] https://lore.kernel.org/all/20230207024816.525938-1-dianders@chromium.org/ Fei Shao (2): dt-bindings: input: goodix: Add powered-in-suspend property HID: i2c-hid: goodix: Add support for powered-in-suspend property .../bindings/input/goodix,gt7375p.yaml | 6 +++ drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 46 ++++++++++++++++--- 2 files changed, 45 insertions(+), 7 deletions(-)