Message ID | 20230418-dpu-drop-useless-for-lookup-v1-0-b9897ceb6f3e@somainline.org |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2466994vqo; Mon, 17 Apr 2023 16:30:25 -0700 (PDT) X-Google-Smtp-Source: AKy350azFbZaUrScLiP6u6//d72OhbgpNrNATJAe3anLKLuTDTnZdIbxTGYgID3DO6SwJHinxdUu X-Received: by 2002:a17:903:234a:b0:1a6:275b:9374 with SMTP id c10-20020a170903234a00b001a6275b9374mr154179plh.67.1681774225260; Mon, 17 Apr 2023 16:30:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681774225; cv=none; d=google.com; s=arc-20160816; b=JboDjWRe/e3qE+e7lzxPCvUYCL+gWxjwTb/A+T3sQ8cZ7p02qafpGkE5rwdTi3sxi9 eJa0FM5Rq60fZnZ3QIjO1W3W0OhHqVh7ICw6RSy4wz3CRRtbEokKkKtsI5RNIX9Ip55L RK4lILNzX7SglF0Y3rVHDd7c4T2yzMgLdM1BuKtI2vZglmFunCchnGKYlL5MPP6K6yty jVBYAvdjwbYF2e2LkYs3n6FGJaxr320Q3XaR3W+rwLcFbr/OE7yLMSnMevhjd+PKQpbh 6ffeE5M49oYeR/ueOWG2jmObpCbFzWLhvwoIPqnatA7fkb4Z4J4dO0GPJp5HrPcBVEvj bIZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:content-transfer-encoding:mime-version :message-id:date:subject:from; bh=NkzNIbZSn9/ADiMdfJfuL/In+usLqHDTuzEin3MYhXs=; b=q3UzIqtxJOmDWNPw6vPZQwfFB3ScvmUWqp6QRQ6TRW0JxPjMXauB6CdK2l9ZuL16Lt MYWvNuzh602Y9rTyBUP4Hy4jR5eqpNg9Tk3OSdj4NHZ5S9WE7YRVsY6I0Nzu9l6t4rn7 dE1bf04oo4L22+NxJNYfdqsDx46k8Y+LNV3iGSmoDGHTk14sBaGasgcQGCJqP1nokZYv uRhlNPfXHISLzliE0rmZIaVS56Pk4MKi4btmAyLZgeOUaqbMvyXlxX1lSWqRDb/gGe8R /V1CzCCIZrEt1skmS1sXcVHhC7DNtWimbv1Gd/nGfLzhgxL/x0CYK0NecZyXKn7cq05+ meHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q11-20020a170902b10b00b001a288c5d34bsi12183994plr.85.2023.04.17.16.30.11; Mon, 17 Apr 2023 16:30:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230231AbjDQXOW (ORCPT <rfc822;leviz.kernel.dev@gmail.com> + 99 others); Mon, 17 Apr 2023 19:14:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229884AbjDQXOU (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 17 Apr 2023 19:14:20 -0400 Received: from relay06.th.seeweb.it (relay06.th.seeweb.it [5.144.164.167]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08B7D3C02; Mon, 17 Apr 2023 16:14:18 -0700 (PDT) Received: from Marijn-Arch-PC.localdomain (94-211-6-86.cable.dynamic.v4.ziggo.nl [94.211.6.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id E6DF73F8AE; Tue, 18 Apr 2023 01:14:16 +0200 (CEST) From: Marijn Suijten <marijn.suijten@somainline.org> Subject: [PATCH 0/3] drm/msm/dpu: Drop useless for-loop HW block lookup Date: Tue, 18 Apr 2023 01:14:15 +0200 Message-Id: <20230418-dpu-drop-useless-for-lookup-v1-0-b9897ceb6f3e@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAMfSPWQC/x2NQQrDIBAAvxL23AWTSmP7lZKD0U2zVFR2sRRC/ l7pceYwc4CSMCk8hgOEPqxccofxMkDYfX4RcuwMk5muxo4OY20YpVRsSolUcSuCqZR3q2idm40 Js7e3O/TC6pVwFZ/D3hu5pdRlFdr4+18+l/P8AQRLlfiCAAAA To: Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch> Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Martin Botka <martin.botka@somainline.org>, Jami Kettunen <jami.kettunen@somainline.org>, Jordan Crouse <jordan@cosmicpenguin.net>, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Marijn Suijten <marijn.suijten@somainline.org> X-Mailer: b4 0.12.2 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763468090147494855?= X-GMAIL-MSGID: =?utf-8?q?1763468090147494855?= |
Series |
drm/msm/dpu: Drop useless for-loop HW block lookup
|
|
Message
Marijn Suijten
April 17, 2023, 11:14 p.m. UTC
Doing a for loop in every DPU HW block driver init to find a catalog entry matching the given ID is rather useless if the init function called by RM already has that catalog entry pointer, and uses exactly its ID to drive this init and for loop. Remove all that machinery to drop quite some lines of unnecessarily-complicated code, and the fallibility that comes with it, by simply giving _init() the catalog entry pointers straight away. Also clean up some unused struct members, and assign a log_mask for WB. --- Marijn Suijten (3): drm/msm/dpu: Drop unused members from HW structs drm/msm/dpu: Assign missing writeback log_mask drm/msm/dpu: Pass catalog pointers directly from RM instead of IDs drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 30 +++-------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 10 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 32 +++--------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h | 11 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c | 38 ++++----------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.h | 12 +++---- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 41 ++++++----------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 13 +++---- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 38 ++++----------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h | 10 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_merge3d.c | 33 +++--------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_merge3d.h | 14 ++++---- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 33 +++--------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 14 ++++---- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 34 +++---------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 10 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.c | 33 +++--------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.h | 11 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c | 33 ++++-------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.h | 16 +++------ drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 17 +++++----- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 18 +++++----- 23 files changed, 127 insertions(+), 376 deletions(-) --- base-commit: 4aa1da8d99724f6c0b762b58a71cee7c5e2e109b change-id: 20230418-dpu-drop-useless-for-lookup-488700c7a469 Best regards,