Message ID | 20230416194624.1258860-1-mmyangfl@gmail.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1721352vqo; Sun, 16 Apr 2023 13:03:44 -0700 (PDT) X-Google-Smtp-Source: AKy350ZcbgRovpIBbbCXFj/zOfNe5qKvERk5PDxwsY6xkZ5NQ0KRqe+7RYEINuy4tvTou6O8UUBA X-Received: by 2002:a05:6a00:244c:b0:63a:65a9:10db with SMTP id d12-20020a056a00244c00b0063a65a910dbmr19193400pfj.7.1681675423873; Sun, 16 Apr 2023 13:03:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681675423; cv=none; d=google.com; s=arc-20160816; b=tVDdlEqX9nwpGxLMk9tB24yc8c1aBJDNXNJKyjxhjO04/Iei8mfNx6CNeay1Vm6pNF nwoTeaJksVAwGovYtc7HGVYp2T+ZfiGQXb/OpjWXySAIHEOyGxCkIGNG0D7bTjFxCGgW kyGRHZ6UIZYvgGvRtMiXkyFQblME3fYhRBufCAcRy4/WGyfP5xJfpH1V2dlSnhTFAbhl oWahBWvP5zb9dcbhEGErxq7L7eFcPLArP41kHioBwhGF9CXLqq0U5clDbYOHUao/waDk bzJbzABwwve7CUk4HFofKlFiryd4GSg0b4YSe+U7ABUoJdW0Ai9343Q2AFTHAELItK8i lw4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Meto6gsXNk91gHx8C0HmnEYuyxHZvVGTyKoqO9PiMNc=; b=T+H/Ztje5ZZu3yMO5G9+W5y3nb8iQoTXKBkXbK1yu2GuAVa/Xn0D18HqW2fo6ABVtn 8BtdFhY0TPLJDhpxjpSbBSjxrmwjyy8bkulmRhNy66eczYXlIWzwR9gI7Vh/xQ41FiGG VtLvk5sKnd/Y11MtTlceIRm5JU/wLqBcWmfheoUj1OiPgv3UIkKLdSFMizcOqBIotFXw qAnB2NcnNsLg2ILtyteEQoe9U1MlKkLBhpCXb/0jcQ71QHf8UNjqvTeIUJ7oRL7gcHUo C4us0bg6tcZekD4/ZFzP7g4kgBRuY+zbBqcn6KRxsyBwYERbnEZDrRcQV/FAHwBsldu2 MdtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=eJYqFrJG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x11-20020aa79a4b000000b0063b8dcfdcdasi1630945pfj.37.2023.04.16.13.03.31; Sun, 16 Apr 2023 13:03:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=eJYqFrJG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229883AbjDPTrb (ORCPT <rfc822;yuanzuo1009@gmail.com> + 99 others); Sun, 16 Apr 2023 15:47:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229810AbjDPTra (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 16 Apr 2023 15:47:30 -0400 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EC7A10F1; Sun, 16 Apr 2023 12:47:21 -0700 (PDT) Received: by mail-pj1-x1035.google.com with SMTP id v9so28746560pjk.0; Sun, 16 Apr 2023 12:47:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681674440; x=1684266440; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Meto6gsXNk91gHx8C0HmnEYuyxHZvVGTyKoqO9PiMNc=; b=eJYqFrJGLk24WuxpY5JuFFW1v/FDUKlryz7xwHJakzKAdUk+S8VU0iiF5MekiOHc5o ur0UALCSXSovdVFI191ofEm/D3GC32OPO80FM+Wl2ols3dif7zxY3rHS4NPa4ErHJ1+e Im5jtiI1cWSha24rQLgrnFOHskXJ7t+6nZsR9DLrzGAEgZlcJqB4d+LaUObadc57YyKk Lk2zAkOK3KOtE/R+8xcoExUwApUmw8NiA+VOC0Ssmdklx0XPTFVNTfPCSE46CxX0BtJg j+lKuwjuySDz3Gq562LEvS4LvcuJiAcH+ymN0qB2auqXrbluYoNCoI83WhOYyhE/Rgoz 0L1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681674440; x=1684266440; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Meto6gsXNk91gHx8C0HmnEYuyxHZvVGTyKoqO9PiMNc=; b=G0kbFytODT+cCwT9UC6ruXTSK0CMPYUfsaLgR307lHjhHnw+FC4Nt8pw5xuCaXphEf bG3iX0ux78emTYYpW/au0grqE0PDNeKC6U+cKdtGyGhzPfOrJskGsYqNdE3IlVubkJWV HalWfWwKaaufOHpsXpywf4oNIxeHuKuXxQh67RHwC360FVYcvJOgRVQ2f+x0TMZ98w9+ nfOiysf5y/AVcAPSoDhJlOE638kNUsrxSXOf7IKa+oWidOkxAgk8lXS3YJp5RVsY96Or 0jRm/MBGzXk1gMYq0hhbWSxQwFCI0p08uKtnK2POmF7dAGY3ixeStMQm//PkUu3xhj+8 qEgA== X-Gm-Message-State: AAQBX9eNat8otMiSjWxlXfeJNbL/g68cqUdF+iW5CsPdil0lFC3fdYoj Izm1zrQrTwkaP9UsIljZMwAVlZr5NAtkvol1CRU= X-Received: by 2002:a17:903:454:b0:1a0:50bd:31c0 with SMTP id iw20-20020a170903045400b001a050bd31c0mr8920831plb.24.1681674440450; Sun, 16 Apr 2023 12:47:20 -0700 (PDT) Received: from d.home.yangfl.dn42 ([104.28.245.201]) by smtp.gmail.com with ESMTPSA id jd9-20020a170903260900b001a69b28f5c5sm4490375plb.222.2023.04.16.12.47.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Apr 2023 12:47:20 -0700 (PDT) From: David Yang <mmyangfl@gmail.com> To: linux-clk@vger.kernel.org Cc: David Yang <mmyangfl@gmail.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Philipp Zabel <p.zabel@pengutronix.de>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 0/4] clk: Add basic register clock controller Date: Mon, 17 Apr 2023 03:46:18 +0800 Message-Id: <20230416194624.1258860-1-mmyangfl@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763355112186390314?= X-GMAIL-MSGID: =?utf-8?q?1763364489387087316?= |
Series |
clk: Add basic register clock controller
|
|
Message
Yangfl
April 16, 2023, 7:46 p.m. UTC
These clocks were provided in `include/linux/clk-provider.h`, but lacks DT bindings. Add DT bindings for them. v2: split clock controller and its clocks v3: * rewrite commit message * rewrite descriptions in dt-bindings to describe the devices * fix format error of dt-bindings Links: v1: https://lore.kernel.org/r/20230414181302.986271-1-mmyangfl@gmail.com v2: https://lore.kernel.org/r/20230416173302.1185683-1-mmyangfl@gmail.com David Yang (4): dt-bindings: clock: Add simple-clock-controller clk: Add simple clock controller dt-bindings: clock: Add gate-clock clk: gate: Add DT binding .../devicetree/bindings/clock/gate-clock.yaml | 59 ++++ .../clock/simple-clock-controller.yaml | 39 +++ drivers/clk/Makefile | 1 + drivers/clk/clk-gate.c | 81 +++++ drivers/clk/clk-of.c | 292 ++++++++++++++++++ drivers/clk/clk-of.h | 26 ++ 6 files changed, 498 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/gate-clock.yaml create mode 100644 Documentation/devicetree/bindings/clock/simple-clock-controller.yaml create mode 100644 drivers/clk/clk-of.c create mode 100644 drivers/clk/clk-of.h base-commit: 7a934f4bd7d6f9da84c8812da3ba42ee10f5778e
Comments
On 16/04/2023 21:46, David Yang wrote: > These clocks were provided in `include/linux/clk-provider.h`, but lacks DT > bindings. Add DT bindings for them. > > v2: split clock controller and its clocks I gave you several comments on v1 and this vague changelog entry suggests you ignored all of it. Implement feedback and respond to each one that you ack it or disagree with it. Best regards, Krzysztof
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 于2023年4月17日周一 14:27写道: > > On 16/04/2023 21:46, David Yang wrote: > > These clocks were provided in `include/linux/clk-provider.h`, but lacks DT > > bindings. Add DT bindings for them. > > > > v2: split clock controller and its clocks > > I gave you several comments on v1 and this vague changelog entry > suggests you ignored all of it. > > Implement feedback and respond to each one that you ack it or disagree > with it. > > > Best regards, > Krzysztof > All issues have been addressed in v3 patch. I omitted details in changelog to reduce redundancy. If that is not the proper way to make response in dt maillist, please let me know. Responses for each comments in v1 and v2 have been sent against original email.
On Tue, Apr 18, 2023 at 02:16:28AM +0800, Yangfl wrote: > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 于2023年4月17日周一 14:27写道: > > > > On 16/04/2023 21:46, David Yang wrote: > > > These clocks were provided in `include/linux/clk-provider.h`, but lacks DT > > > bindings. Add DT bindings for them. > > > > > > v2: split clock controller and its clocks > > > > I gave you several comments on v1 and this vague changelog entry > > suggests you ignored all of it. > > > > Implement feedback and respond to each one that you ack it or disagree > > with it. > > > > > > Best regards, > > Krzysztof > > > > All issues have been addressed in v3 patch. I omitted details in > changelog to reduce redundancy. If that is not the proper way to make > response in dt maillist, please let me know. > > Responses for each comments in v1 and v2 have been sent against original email. Go look at v1 replies. This series is a hard no. Rob