Message ID | 20230416101624.15866-1-aweber.kernel@gmail.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1478576vqo; Sun, 16 Apr 2023 03:19:08 -0700 (PDT) X-Google-Smtp-Source: AKy350YBKzcZqggToVEJf/qzTe6xfbtuEPNw/cZOSB2s9k69LV+3JW922G0taxBBHR/GdcMWdAGv X-Received: by 2002:a17:902:db10:b0:19a:96ea:3850 with SMTP id m16-20020a170902db1000b0019a96ea3850mr10032730plx.17.1681640348463; Sun, 16 Apr 2023 03:19:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681640348; cv=none; d=google.com; s=arc-20160816; b=umuhDaWDQfjjGBx4NjwRC26L4F0r08nnDBy+A0hKocaS8GnfkyVKqlYV8OZ7PeSn1M 1RqhRE/5wp2DSQobMEHGK+BRnHtG/2RlyiUv8I8BSlUV6UhE5VFamihYn2WmyraHTh12 m9A8Ujsr5js1YH4BP7xqAIEabKEWEPEQYSAMgEklhs7TS/Uq3uiaChlu14Yz6BaIkNf5 wfuvnrBh4nG++YnI1G0i6vTULgcpYineZ2kszvpA/asDgYbtP0rtW1hG85X30ws23JdI G/hFMOejZ9xmMviK1xx0UGVEe7mqJuTJhXg4H4cnDesn2eCGp56l7lCfiUFlw4cGElFY D7TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=lMKv1eC7oXKgQg7kmPBpEEYkcLgFu/zreUxyQ3hjVRU=; b=H+c1120uPRsf59HY85iXPJquMqUcQWZFtTLQN2S8bLVC/dVGYzI9iw4hR9rGyZx7oP MhiDuzrWtRPFLpv6QAihXlC+GATdKEzB3xojgN8iKinrvehTmKMqvlsgTi9K0/DARR99 13PdK6Ngfk4YY+jXipvjJBsn6EnsTNWzq2zp8Niu7CqokYAZzCER1YxmA2J8+NvJ4zGr KlyhCIeVIPzucsKvJPKGGpM5/ZXXKJD8jOzRo9A+qHdpU4pGF3wFBhVZd1sXSX8jBSYS VhGHA/qhFzk01G7278+xQnggsSSreaGqJkpWQUhUKNSL6tw6CPbipDyHbHKV30Pu+yqW IcZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=XY2jm6IU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l13-20020a170902d34d00b001a63b9bfd62si8871679plk.461.2023.04.16.03.18.54; Sun, 16 Apr 2023 03:19:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=XY2jm6IU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230064AbjDPKST (ORCPT <rfc822;yuanzuo1009@gmail.com> + 99 others); Sun, 16 Apr 2023 06:18:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229975AbjDPKSL (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 16 Apr 2023 06:18:11 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E31B01991; Sun, 16 Apr 2023 03:18:07 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id xi5so56795845ejb.13; Sun, 16 Apr 2023 03:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681640286; x=1684232286; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lMKv1eC7oXKgQg7kmPBpEEYkcLgFu/zreUxyQ3hjVRU=; b=XY2jm6IUO7nOh7iJmLWXmOyrQaQ2zXMn6pKvFRann89LpKvUgmwOJ4vPQxCYYtgl/r VHL5qEdKbz4cEa32T3mijCoxrubeICJTC1oz9/SCZMyviJQLMi2owVoreb9Buhr4/On6 +o2yhR4LpvZkgSUrbVIEN6JQCj+xh2qQYpvQOaE/rBhfkuXWUlon8FcmuFiI9DUUPlfq GSxXv2IZ3AKkBNmIGQ1qMt92cC07eFOt0Ask8D23d61JCAwY7jtB1ylHQUY+4l+MsSZ6 xPDpywU+Y4gJRduqySkVW4gkcY+GLnvnZArfwxLArMPu+F8KS2LsXiVjNmbrJDBY73Id 5njQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681640286; x=1684232286; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lMKv1eC7oXKgQg7kmPBpEEYkcLgFu/zreUxyQ3hjVRU=; b=DvNs5F6KnRBflBSlj7p/58V+YA30RZ5muGwdj1rgHBUPjyhNLhGC7XqArpG8hxdydU 8BMElQ5bBr2RCu66Bawy/Smd2Pignf9fYXBzAgyhcil4AjFcb6CmJ42zeq71kKA0Bzp0 oBPtsp5dNaAq+3OWk0kuSAIZYgUozNaA7Uu0en8jxMiCyIRabikIT/YDeapVdaVPiEWk Hj5+G2ANr531ixN0+UKl4s5g93OBO/F0TuLLVlZnjq24Njavc05Epi/0IS3oTG2h5Bm7 9w57w0H+WAUr4hARobmduIbOJk+D0SOScK2bplPjMSJ4/xsrd5qC9usEdmDjQ6mJgArU Hf/g== X-Gm-Message-State: AAQBX9fBX2YyNbk263WN+xArFaJoMhP3GBCfWH+9RJKKO8RrFy9+A6+E 2RWce2J3dKpxO9o9I+qLpss= X-Received: by 2002:a17:906:3454:b0:94e:8431:4767 with SMTP id d20-20020a170906345400b0094e84314767mr4666485ejb.38.1681640286211; Sun, 16 Apr 2023 03:18:06 -0700 (PDT) Received: from localhost.my.domain (83.8.121.70.ipv4.supernova.orange.pl. [83.8.121.70]) by smtp.gmail.com with ESMTPSA id r20-20020a056402019400b0050476da5160sm4427443edv.45.2023.04.16.03.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Apr 2023 03:18:05 -0700 (PDT) From: Artur Weber <aweber.kernel@gmail.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: Alim Akhtar <alim.akhtar@samsung.com>, Rob Herring <robh+dt@kernel.org>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Tomasz Figa <tomasz.figa@gmail.com>, Chanwoo Choi <cw00.choi@samsung.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>, soc@kernel.org, Russell King <linux@armlinux.org.uk>, Daniel Lezcano <daniel.lezcano@linaro.org>, Kukjin Kim <kgene@kernel.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, Vinod Koul <vkoul@kernel.org>, Kishon Vijay Abraham I <kishon@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-media@vger.kernel.org, linux-phy@lists.infradead.org, ~postmarketos/upstreaming@lists.sr.ht, Artur Weber <aweber.kernel@gmail.com> Subject: [PATCH 00/12] Re-introduce Exynos4212 support and add Samsung Galaxy Tab 3 8.0 boards Date: Sun, 16 Apr 2023 12:16:12 +0200 Message-Id: <20230416101624.15866-1-aweber.kernel@gmail.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763327709883940596?= X-GMAIL-MSGID: =?utf-8?q?1763327709883940596?= |
Series |
Re-introduce Exynos4212 support and add Samsung Galaxy Tab 3 8.0 boards
|
|
Message
Artur Weber
April 16, 2023, 10:16 a.m. UTC
This patches re-introduces the Exynos4212 platform and adds support
for the Samsung Galaxy Tab 3 8.0 series of tablets that uses it:
- Samsung Galaxy Tab 3 8.0 WiFi (SM-T310/lt01wifi)
- Samsung Galaxy Tab 3 8.0 3G (SM-T311/lt013g)
- Samsung Galaxy Tab 3 8.0 LTE (SM-T315/lt01lte)
What works:
- Display and backlight
- Touchscreen (without touchkeys)
- GPIO buttons, hall sensor
- WiFi and Bluetooth
- USB, fuel gauge, charging (partial)
- Accelerometer and magnetometer
- WiFi model only: light sensor
Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
Artur Weber (12):
dt-bindings: soc: samsung: add Exynos4212 PMU compatible
dt-bindings: clock: add Exynos4212 clock compatible
ARM: exynos: Re-introduce Exynos4212 support
soc: samsung: Re-introduce Exynos4212 support
clk: samsung: Add Exynos4212 compatible to CLKOUT driver
clk: samsung: Re-add support for Exynos4212 CPU clock
Revert "media: exynos4-is: Remove dependency on obsolete SoC support"
Revert "phy: Remove SOC_EXYNOS4212 dep. from PHY_EXYNOS4X12_USB"
ARM: dts: Move common Exynos4x12 definitions to exynos4x12.dtsi
ARM: dts: Re-introduce Exynos4212 DTSI
dt-bindings: arm: samsung: Add Samsung Galaxy Tab3 family boards
ARM: dts: exynos: Add Samsung Galaxy Tab 3 8.0 boards
.../bindings/arm/samsung/samsung-boards.yaml | 10 +
.../bindings/clock/samsung,exynos-clock.yaml | 1 +
.../bindings/soc/samsung/exynos-pmu.yaml | 3 +
arch/arm/boot/dts/Makefile | 3 +
arch/arm/boot/dts/exynos4212-tab3-3g8.dts | 30 +
arch/arm/boot/dts/exynos4212-tab3-lte8.dts | 43 +
arch/arm/boot/dts/exynos4212-tab3-wifi8.dts | 25 +
arch/arm/boot/dts/exynos4212-tab3.dtsi | 1175 +++++++++++++++++
arch/arm/boot/dts/exynos4212.dtsi | 157 +++
arch/arm/boot/dts/exynos4412.dtsi | 645 +--------
...2-pinctrl.dtsi => exynos4x12-pinctrl.dtsi} | 4 +-
arch/arm/boot/dts/exynos4x12.dtsi | 665 ++++++++++
arch/arm/mach-exynos/Kconfig | 5 +
arch/arm/mach-exynos/common.h | 8 +
arch/arm/mach-exynos/exynos.c | 2 +
arch/arm/mach-exynos/firmware.c | 8 +-
arch/arm/mach-exynos/pm.c | 2 +-
arch/arm/mach-exynos/suspend.c | 4 +
drivers/clk/samsung/clk-exynos-clkout.c | 3 +
drivers/clk/samsung/clk-exynos4.c | 44 +-
.../media/platform/samsung/exynos4-is/Kconfig | 2 +-
.../platform/samsung/exynos4-is/fimc-core.c | 2 +-
.../platform/samsung/exynos4-is/fimc-lite.c | 2 +-
drivers/phy/samsung/Kconfig | 2 +-
drivers/soc/samsung/exynos-pmu.c | 9 +
drivers/soc/samsung/exynos-pmu.h | 2 +
drivers/soc/samsung/exynos4-pmu.c | 13 +-
27 files changed, 2213 insertions(+), 656 deletions(-)
create mode 100644 arch/arm/boot/dts/exynos4212-tab3-3g8.dts
create mode 100644 arch/arm/boot/dts/exynos4212-tab3-lte8.dts
create mode 100644 arch/arm/boot/dts/exynos4212-tab3-wifi8.dts
create mode 100644 arch/arm/boot/dts/exynos4212-tab3.dtsi
create mode 100644 arch/arm/boot/dts/exynos4212.dtsi
rename arch/arm/boot/dts/{exynos4412-pinctrl.dtsi => exynos4x12-pinctrl.dtsi} (99%)
create mode 100644 arch/arm/boot/dts/exynos4x12.dtsi
Comments
On 16/04/2023 12:16, Artur Weber wrote: > This patches re-introduces the Exynos4212 platform and adds support > for the Samsung Galaxy Tab 3 8.0 series of tablets that uses it: > > - Samsung Galaxy Tab 3 8.0 WiFi (SM-T310/lt01wifi) > - Samsung Galaxy Tab 3 8.0 3G (SM-T311/lt013g) > - Samsung Galaxy Tab 3 8.0 LTE (SM-T315/lt01lte) > > What works: > > - Display and backlight > - Touchscreen (without touchkeys) > - GPIO buttons, hall sensor > - WiFi and Bluetooth > - USB, fuel gauge, charging (partial) > - Accelerometer and magnetometer > - WiFi model only: light sensor This patchset depends on "[PATCH 0/3] Add Samsung S6D7AA0 panel controller driver" for the display panel support for the Samsung Galaxy 3 8.0 boards. > > Signed-off-by: Artur Weber <aweber.kernel@gmail.com> > > Artur Weber (12): > dt-bindings: soc: samsung: add Exynos4212 PMU compatible > dt-bindings: clock: add Exynos4212 clock compatible > ARM: exynos: Re-introduce Exynos4212 support > soc: samsung: Re-introduce Exynos4212 support > clk: samsung: Add Exynos4212 compatible to CLKOUT driver > clk: samsung: Re-add support for Exynos4212 CPU clock > Revert "media: exynos4-is: Remove dependency on obsolete SoC support" > Revert "phy: Remove SOC_EXYNOS4212 dep. from PHY_EXYNOS4X12_USB" > ARM: dts: Move common Exynos4x12 definitions to exynos4x12.dtsi > ARM: dts: Re-introduce Exynos4212 DTSI > dt-bindings: arm: samsung: Add Samsung Galaxy Tab3 family boards > ARM: dts: exynos: Add Samsung Galaxy Tab 3 8.0 boards > > .../bindings/arm/samsung/samsung-boards.yaml | 10 + > .../bindings/clock/samsung,exynos-clock.yaml | 1 + > .../bindings/soc/samsung/exynos-pmu.yaml | 3 + > arch/arm/boot/dts/Makefile | 3 + > arch/arm/boot/dts/exynos4212-tab3-3g8.dts | 30 + > arch/arm/boot/dts/exynos4212-tab3-lte8.dts | 43 + > arch/arm/boot/dts/exynos4212-tab3-wifi8.dts | 25 + > arch/arm/boot/dts/exynos4212-tab3.dtsi | 1175 +++++++++++++++++ > arch/arm/boot/dts/exynos4212.dtsi | 157 +++ > arch/arm/boot/dts/exynos4412.dtsi | 645 +-------- > ...2-pinctrl.dtsi => exynos4x12-pinctrl.dtsi} | 4 +- > arch/arm/boot/dts/exynos4x12.dtsi | 665 ++++++++++ > arch/arm/mach-exynos/Kconfig | 5 + > arch/arm/mach-exynos/common.h | 8 + > arch/arm/mach-exynos/exynos.c | 2 + > arch/arm/mach-exynos/firmware.c | 8 +- > arch/arm/mach-exynos/pm.c | 2 +- > arch/arm/mach-exynos/suspend.c | 4 + > drivers/clk/samsung/clk-exynos-clkout.c | 3 + > drivers/clk/samsung/clk-exynos4.c | 44 +- > .../media/platform/samsung/exynos4-is/Kconfig | 2 +- > .../platform/samsung/exynos4-is/fimc-core.c | 2 +- > .../platform/samsung/exynos4-is/fimc-lite.c | 2 +- > drivers/phy/samsung/Kconfig | 2 +- > drivers/soc/samsung/exynos-pmu.c | 9 + > drivers/soc/samsung/exynos-pmu.h | 2 + > drivers/soc/samsung/exynos4-pmu.c | 13 +- > 27 files changed, 2213 insertions(+), 656 deletions(-) > create mode 100644 arch/arm/boot/dts/exynos4212-tab3-3g8.dts > create mode 100644 arch/arm/boot/dts/exynos4212-tab3-lte8.dts > create mode 100644 arch/arm/boot/dts/exynos4212-tab3-wifi8.dts > create mode 100644 arch/arm/boot/dts/exynos4212-tab3.dtsi > create mode 100644 arch/arm/boot/dts/exynos4212.dtsi > rename arch/arm/boot/dts/{exynos4412-pinctrl.dtsi => exynos4x12-pinctrl.dtsi} (99%) > create mode 100644 arch/arm/boot/dts/exynos4x12.dtsi >
On 16/04/2023 12:26, Artur Weber wrote: > On 16/04/2023 12:16, Artur Weber wrote: >> This patches re-introduces the Exynos4212 platform and adds support >> for the Samsung Galaxy Tab 3 8.0 series of tablets that uses it: >> >> - Samsung Galaxy Tab 3 8.0 WiFi (SM-T310/lt01wifi) >> - Samsung Galaxy Tab 3 8.0 3G (SM-T311/lt013g) >> - Samsung Galaxy Tab 3 8.0 LTE (SM-T315/lt01lte) >> >> What works: >> >> - Display and backlight >> - Touchscreen (without touchkeys) >> - GPIO buttons, hall sensor >> - WiFi and Bluetooth >> - USB, fuel gauge, charging (partial) >> - Accelerometer and magnetometer >> - WiFi model only: light sensor > > This patchset depends on "[PATCH 0/3] Add Samsung S6D7AA0 panel > controller driver" for the display panel support for the Samsung Galaxy > 3 8.0 boards. Why? DTS and ARM code cannot depend on driver changes. Please rework your patchsets to remove any of such dependencies. Best regards, Krzysztof
On 16/04/2023 12:34, Krzysztof Kozlowski wrote: > On 16/04/2023 12:26, Artur Weber wrote: >> On 16/04/2023 12:16, Artur Weber wrote: >>> This patches re-introduces the Exynos4212 platform and adds support >>> for the Samsung Galaxy Tab 3 8.0 series of tablets that uses it: >>> >>> - Samsung Galaxy Tab 3 8.0 WiFi (SM-T310/lt01wifi) >>> - Samsung Galaxy Tab 3 8.0 3G (SM-T311/lt013g) >>> - Samsung Galaxy Tab 3 8.0 LTE (SM-T315/lt01lte) >>> >>> What works: >>> >>> - Display and backlight >>> - Touchscreen (without touchkeys) >>> - GPIO buttons, hall sensor >>> - WiFi and Bluetooth >>> - USB, fuel gauge, charging (partial) >>> - Accelerometer and magnetometer >>> - WiFi model only: light sensor >> >> This patchset depends on "[PATCH 0/3] Add Samsung S6D7AA0 panel >> controller driver" for the display panel support for the Samsung Galaxy >> 3 8.0 boards. > > Why? DTS and ARM code cannot depend on driver changes. Please rework > your patchsets to remove any of such dependencies. Ah, that makes sense. I'll re-send the patchset in a second with the panel node removed. Best regards Artur Weber
On 16/04/2023 12:49, Artur Weber wrote: > On 16/04/2023 12:34, Krzysztof Kozlowski wrote: >> On 16/04/2023 12:26, Artur Weber wrote: >>> On 16/04/2023 12:16, Artur Weber wrote: >>>> This patches re-introduces the Exynos4212 platform and adds support >>>> for the Samsung Galaxy Tab 3 8.0 series of tablets that uses it: >>>> >>>> - Samsung Galaxy Tab 3 8.0 WiFi (SM-T310/lt01wifi) >>>> - Samsung Galaxy Tab 3 8.0 3G (SM-T311/lt013g) >>>> - Samsung Galaxy Tab 3 8.0 LTE (SM-T315/lt01lte) >>>> >>>> What works: >>>> >>>> - Display and backlight >>>> - Touchscreen (without touchkeys) >>>> - GPIO buttons, hall sensor >>>> - WiFi and Bluetooth >>>> - USB, fuel gauge, charging (partial) >>>> - Accelerometer and magnetometer >>>> - WiFi model only: light sensor >>> >>> This patchset depends on "[PATCH 0/3] Add Samsung S6D7AA0 panel >>> controller driver" for the display panel support for the Samsung Galaxy >>> 3 8.0 boards. >> >> Why? DTS and ARM code cannot depend on driver changes. Please rework >> your patchsets to remove any of such dependencies. > > Ah, that makes sense. I'll re-send the patchset in a second with the > panel node removed. I am sorry, I don't understand. Why would you remove anything from DTS? Are bindings NAKed? Best regards, Krzysztof
On 16/04/2023 12:53, Krzysztof Kozlowski wrote: > On 16/04/2023 12:49, Artur Weber wrote: >> On 16/04/2023 12:34, Krzysztof Kozlowski wrote: >>> On 16/04/2023 12:26, Artur Weber wrote: >>>> On 16/04/2023 12:16, Artur Weber wrote: >>>>> This patches re-introduces the Exynos4212 platform and adds support >>>>> for the Samsung Galaxy Tab 3 8.0 series of tablets that uses it: >>>>> >>>>> - Samsung Galaxy Tab 3 8.0 WiFi (SM-T310/lt01wifi) >>>>> - Samsung Galaxy Tab 3 8.0 3G (SM-T311/lt013g) >>>>> - Samsung Galaxy Tab 3 8.0 LTE (SM-T315/lt01lte) >>>>> >>>>> What works: >>>>> >>>>> - Display and backlight >>>>> - Touchscreen (without touchkeys) >>>>> - GPIO buttons, hall sensor >>>>> - WiFi and Bluetooth >>>>> - USB, fuel gauge, charging (partial) >>>>> - Accelerometer and magnetometer >>>>> - WiFi model only: light sensor >>>> >>>> This patchset depends on "[PATCH 0/3] Add Samsung S6D7AA0 panel >>>> controller driver" for the display panel support for the Samsung Galaxy >>>> 3 8.0 boards. >>> >>> Why? DTS and ARM code cannot depend on driver changes. Please rework >>> your patchsets to remove any of such dependencies. >> >> Ah, that makes sense. I'll re-send the patchset in a second with the >> panel node removed. > > I am sorry, I don't understand. Why would you remove anything from DTS? > Are bindings NAKed? The dependency display panel patchset introduces the panel and its bindings, which in turn are included in the Tab3 DTSI. It was submitted at roughly the same time as this series, and hasn't been fully reviewed or merged as of writing. (I have seen your comments on that patchset, and I will be addressing them shortly.) So the bindings haven't been explicitly ACKed yet (assuming you mean the Acked-by reply). In response to: > Please rework your patchsets to remove any of such dependencies. I suggested that I could remove the panel node from the DTSI for the time being. The intent was to submit it in a separate patch later, once the display is reviewed/merged, and thus actually available in the kernel; this way, the two patches could be reviewed and merged separately. I could instead wait for the display patchset to get reviewed/merged first, then resubmit this series, if that's preferable. I apologize for the confusion. Best regards, Artur Weber
On 16/04/2023 14:37, Artur Weber wrote: > On 16/04/2023 12:53, Krzysztof Kozlowski wrote: >> On 16/04/2023 12:49, Artur Weber wrote: >>> On 16/04/2023 12:34, Krzysztof Kozlowski wrote: >>>> On 16/04/2023 12:26, Artur Weber wrote: >>>>> On 16/04/2023 12:16, Artur Weber wrote: >>>>>> This patches re-introduces the Exynos4212 platform and adds support >>>>>> for the Samsung Galaxy Tab 3 8.0 series of tablets that uses it: >>>>>> >>>>>> - Samsung Galaxy Tab 3 8.0 WiFi (SM-T310/lt01wifi) >>>>>> - Samsung Galaxy Tab 3 8.0 3G (SM-T311/lt013g) >>>>>> - Samsung Galaxy Tab 3 8.0 LTE (SM-T315/lt01lte) >>>>>> >>>>>> What works: >>>>>> >>>>>> - Display and backlight >>>>>> - Touchscreen (without touchkeys) >>>>>> - GPIO buttons, hall sensor >>>>>> - WiFi and Bluetooth >>>>>> - USB, fuel gauge, charging (partial) >>>>>> - Accelerometer and magnetometer >>>>>> - WiFi model only: light sensor >>>>> >>>>> This patchset depends on "[PATCH 0/3] Add Samsung S6D7AA0 panel >>>>> controller driver" for the display panel support for the Samsung Galaxy >>>>> 3 8.0 boards. >>>> >>>> Why? DTS and ARM code cannot depend on driver changes. Please rework >>>> your patchsets to remove any of such dependencies. >>> >>> Ah, that makes sense. I'll re-send the patchset in a second with the >>> panel node removed. >> >> I am sorry, I don't understand. Why would you remove anything from DTS? >> Are bindings NAKed? > > The dependency display panel patchset introduces the panel and its > bindings, which in turn are included in the Tab3 DTSI. It was submitted > at roughly the same time as this series, and hasn't been fully reviewed > or merged as of writing. (I have seen your comments on that patchset, > and I will be addressing them shortly.) So the bindings haven't been > explicitly ACKed yet (assuming you mean the Acked-by reply). So there is no dependency. DTS is (and must be) independent of driver. You need to mention in the patch (under --- ) or cover letter that it uses new bindings which are documented under the given link. > > In response to: > > > Please rework your patchsets to remove any of such dependencies. > > I suggested that I could remove the panel node from the DTSI for the > time being. The intent was to submit it in a separate patch later, once > the display is reviewed/merged, and thus actually available in the > kernel; this way, the two patches could be reviewed and merged separately. No need, there is no dependency. Just remove such remarks from cover letter. Best regards, Krzysztof