From patchwork Fri Apr 14 12:55:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wander Lairson Costa X-Patchwork-Id: 8194 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp374432vqo; Fri, 14 Apr 2023 06:16:36 -0700 (PDT) X-Google-Smtp-Source: AKy350agOz7P2prr6bIhwMMmwUA6AC74UgVZ5jIgcL9XcZqU6VTBEQzqflhJTTKOMGGcwm8Uq3Og X-Received: by 2002:a17:902:e5cb:b0:1a0:5349:6606 with SMTP id u11-20020a170902e5cb00b001a053496606mr3590501plf.56.1681478196399; Fri, 14 Apr 2023 06:16:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681478196; cv=none; d=google.com; s=arc-20160816; b=I69ADJMyNj/8mcgikXPWZw3jWGupMW7N4KZMmImwBL73ECbQyosal9rqU6G7IptiCF vMQJW7uahzozp55sWKfC1baCMrvz2PQAf7eZ7RU2ZZN7vFOgotwbxIYIbZZl39hRDyih ETGtuJXvtI/n6hdOGJM18oFoHEtfNEfBSITOp44zY546DJc7q/AvavYbXU+BgTzNivqK BcAlcbadVzoFNUUa5V5DB7M7zZnXM2DRJ4poWT3KZFffQts6eXqXUrx09Miw1xkxDPcW 1LIwTS5R3HN7lbNVpiQkCrVUkvVCMNE6o1yL/pmBJlj3Z7vI90nFKdO4q3DRrUdSWGCe 4GGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=T997QlX8ulRak2Xfd7UnKYdetFcqQN7kWdIRh6IkroE=; b=Pu/pChRNcYX8z6C4FkCTVFqTZ2ki38CdvoePf1FcGiUtQAUU3Q1pqse9XbnxoHTsic +lIKMv4LGKiSKK0zpb8O/10RwB/6mdlCIhh0DDEvzfG84Cs0PvV3aF5mIdiVCvvTAr66 N9l1dn6WklUV+CWBecU49k4xMV8RPu8yMTjDsu5c8KdHuxh5GDOUnHPg2TrOTKf77JcD 66j4m99ByWiv55gENqpHKoNLOXfWeWWIJCdnlciqNZ9CcBoj4U+QKu4GUXm3NgMj5yqC fQLpouEAAoOKaBBz9bNoyHsQ4rf1GOxu+MunidbjnGwOPUrGxchIBDTLPMnOXS44jZka OiyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Le59vJFe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d5-20020a170902b70500b001a1ce0509c7si4316857pls.16.2023.04.14.06.16.23; Fri, 14 Apr 2023 06:16:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Le59vJFe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229945AbjDNM4v (ORCPT + 99 others); Fri, 14 Apr 2023 08:56:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229689AbjDNM4u (ORCPT ); Fri, 14 Apr 2023 08:56:50 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D50A3AD12 for ; Fri, 14 Apr 2023 05:55:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681476951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=T997QlX8ulRak2Xfd7UnKYdetFcqQN7kWdIRh6IkroE=; b=Le59vJFeScCLIQ5si5heeVOuSrBFGJc+NUwT9CV6DEjyuUrGE2gQ6tABMRMjDRxfdBdZAl Y+2TyVdW1ZouL9VYqxKkShC7GfCEN9fKZnrwD0fmo45at7luXQZQUjrx19mA8mLW1oHYCI JcDKHzGRD0ClZ2f+7YGw2z9Fs/+zE8U= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-423-WmKRPv8DMrCu00hGWtGdsw-1; Fri, 14 Apr 2023 08:55:49 -0400 X-MC-Unique: WmKRPv8DMrCu00hGWtGdsw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ECF8D88F479; Fri, 14 Apr 2023 12:55:45 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.9.8]) by smtp.corp.redhat.com (Postfix) with ESMTP id D1793406AA66; Fri, 14 Apr 2023 12:55:37 +0000 (UTC) From: Wander Lairson Costa To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Will Deacon , Waiman Long , Boqun Feng , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , "Eric W. Biederman" , Wander Lairson Costa , Andrew Morton , Guo Ren , Kefeng Wang , Oleg Nesterov , "Liam R. Howlett" , Vlastimil Babka , Christian Brauner , Andrei Vagin , Shakeel Butt , linux-kernel@vger.kernel.org (open list), linux-perf-users@vger.kernel.org (open list:PERFORMANCE EVENTS SUBSYSTEM) Subject: [PATCH v6 0/3] Introduce put_task_struct_atomic_sleep() Date: Fri, 14 Apr 2023 09:55:26 -0300 Message-Id: <20230414125532.14958-1-wander@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763157681559490170?= X-GMAIL-MSGID: =?utf-8?q?1763157681559490170?= The put_task_struct() function reduces a usage counter and invokes __put_task_struct() when the counter reaches zero. In the case of __put_task_struct(), it indirectly acquires a spinlock, which operates as a sleeping lock under the PREEMPT_RT configuration. As a result, invoking put_task_struct() within an atomic context is not feasible for real-time (RT) kernels. To address this issue, this patch series introduces a new function called put_task_struct_atomic_safe(). When compiled with the PREEMPT_RT configuration, this function defers the call to __put_task_struct() to a process context. Additionally, the patch series rectifies known problematic call sites to ensure smooth functioning. Changelog ========= v1: * Initial implementation fixing the splat. v2: * Isolate the logic in its own function. * Fix two more cases caught in review. v3: * Change __put_task_struct() to handle the issue internally. v4: * Explain why call_rcu() is safe to call from interrupt context. v5: * Explain why __put_task_struct() doesn't conflict with put_task_sruct_rcu_user. v6: * As per Sebastian's review, revert back the implementation of v2 with a distinct function. * Add a check in put_task_struct() to warning when called from a non-sleepable context. * Address more call sites. Wander Lairson Costa (3): sched/core: warn on call put_task_struct in invalid context sched/task: Add the put_task_struct_atomic_safe() function treewide: replace put_task_struct() witht the atomic safe version include/linux/sched/task.h | 45 ++++++++++++++++++++++++++++++++++++++ kernel/events/core.c | 6 ++--- kernel/fork.c | 8 +++++++ kernel/locking/rtmutex.c | 10 ++++----- kernel/sched/core.c | 6 ++--- kernel/sched/deadline.c | 16 +++++++------- kernel/sched/rt.c | 4 ++-- 7 files changed, 74 insertions(+), 21 deletions(-)