From patchwork Thu Apr 13 11:32:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yu Kuai X-Patchwork-Id: 8126 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp964208vqo; Thu, 13 Apr 2023 04:36:42 -0700 (PDT) X-Google-Smtp-Source: AKy350Zd5+ajiJNEY7nlreO2N1Y4qHMt7mvTGgBNImdcqOfjyjXrnB4fQf8YhycVEpI/dZCsxMtO X-Received: by 2002:a17:90b:190b:b0:247:1575:c609 with SMTP id mp11-20020a17090b190b00b002471575c609mr1822008pjb.9.1681385801807; Thu, 13 Apr 2023 04:36:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681385801; cv=none; d=google.com; s=arc-20160816; b=zl2p16IozvRq6lAYKepkqZu6A6W9mA68SwJKI5avJxcIwSSaGqGbNpt/5tuZFcq7QO 3ir6afx6GAlYgIeuClBg4vz/Pw9Qdzq8/MV230TbYYnDxokV1EhUxg9YqUnN1a40SEN5 IQVS6FHNZfC0HiYmYrQLoULw6c8sOm3FrvW/CwRJLyfPVW+55Cry0vGtVDAg9dJ8xWhy NAeWQtHfONddUfKdxR/CnIm5gYgMYH0kRT7qJmEIpG/oWozr1mH/jOdzlE83vqv/oOuL hYRjd6Eju7PFuKkzfjyelFdwij9DPNiI4CqJ4I+ywlznSeX6DiGDDEwyuKUW3DflFO9v xmDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=OPvhrcqjrRYozrA2RT1UL1fKO9i/+NNfyoJx+NZMUYk=; b=qG8zLpDDSuaum2EU3dTPXaXV46zIcpZIQ5jEmttx4PHD/GmapMrIhXEO01SnzOMRLi soDy7jxTHktUMRSWNmZeb0i8yf4w4eXPSRtRlKhC5SLzRr4shjNpgt3ecwnm6MkpriLy Tr97foeWMtkc1+kOckEBRiHMd5WKv12TJwQeFYsEz6G6VujMT+8X3aIznr1QsfpRhbqA HTTPQTU2guu+ah0txCO02uD6rkX8Raqpy6rWcsMN6qCy7R+DOUhR91yZXlUTYqRzWLRx wD/Xdsp4sOVjfrurr/8fILM+QwUQM9ghzwV7SBv+8pIouquAn6R+T+NQ9RZKPDJGkzLk xtCQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id my14-20020a17090b4c8e00b0022bbae722fcsi7119598pjb.1.2023.04.13.04.36.29; Thu, 13 Apr 2023 04:36:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230322AbjDMLd2 (ORCPT + 99 others); Thu, 13 Apr 2023 07:33:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229790AbjDMLd1 (ORCPT ); Thu, 13 Apr 2023 07:33:27 -0400 Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91BED113; Thu, 13 Apr 2023 04:33:25 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4PxyBS2JZNz4f3wgy; Thu, 13 Apr 2023 19:33:20 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.104.67]) by APP4 (Coremail) with SMTP id gCh0CgCH77KA6DdkC6FCHQ--.33135S4; Thu, 13 Apr 2023 19:33:22 +0800 (CST) From: Yu Kuai To: dm-devel@redhat.com, song@kernel.org, logang@deltatee.com Cc: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, yukuai3@huawei.com, yukuai1@huaweicloud.com, yi.zhang@huawei.com, yangerkun@huawei.com Subject: [PATCH -next v6 0/5] md: protect md_thread with rcu Date: Thu, 13 Apr 2023 19:32:12 +0800 Message-Id: <20230413113217.1934353-1-yukuai1@huaweicloud.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-CM-TRANSID: gCh0CgCH77KA6DdkC6FCHQ--.33135S4 X-Coremail-Antispam: 1UD129KBjvJXoW7Cw4rXrW3GF15GFWfGr48JFb_yoW8WF4kpF ZIgF9xZw4UCr43ZFsxZa42ka45G3WrGayUKryxA34ruFy5ur98Jr1UJFy8WF9rWFyfJa9F qF15Jr1DCF1UtaDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUyl14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s 0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xII jxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr 1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxAIw28IcxkI7VAKI48J MxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwV AFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv2 0xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4 v20xvaj40_WFyUJVCq3wCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E 14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfUoOJ5UUUUU X-CM-SenderInfo: 51xn3trlr6x35dzhxuhorxvhhfrp/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KHOP_HELO_FCRDNS, MAY_BE_FORGED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763060798458483735?= X-GMAIL-MSGID: =?utf-8?q?1763060798458483735?= From: Yu Kuai Changes in v6: - remove first patch from v5, and use rcu_asign_pointer() directly from caller. - always use rcu_read_lock/unlock to protect mddev_set_timeout(). Changes in v5: - use rcu_dereference_protected() instead of rcu_access_pointer() where rcu_read_lock/unlock is not required. - add patch 4,5 to handle that bitmap timeout is set multiple times. Changes in v4: - remove patch 2 from v3 - fix sparse errors and warnings from v3, in order to do that, all access to md_thread need to be modified, patch 2-4 is splited to avoid a huge patch. Changes in v3: - remove patch 3 from v2 - use rcu instead of a new lock Changes in v2: - fix a compile error for md-cluster in patch 2 - replace spin_lock/unlock with spin_lock/unlock_irq in patch 5 - don't wake up inside the new lock in md wakeup_thread in patch 5 Yu Kuai (5): md: factor out a helper to wake up md_thread directly dm-raid: remove useless checking in raid_message() md/bitmap: always wake up md_thread in timeout_store md/bitmap: factor out a helper to set timeout md: protect md_thread with rcu drivers/md/dm-raid.c | 4 +- drivers/md/md-bitmap.c | 43 +++++++++++-------- drivers/md/md-cluster.c | 7 ++-- drivers/md/md-multipath.c | 4 +- drivers/md/md.c | 88 +++++++++++++++++++++------------------ drivers/md/md.h | 8 ++-- drivers/md/raid1.c | 7 ++-- drivers/md/raid1.h | 2 +- drivers/md/raid10.c | 21 ++++++---- drivers/md/raid10.h | 2 +- drivers/md/raid5-cache.c | 22 ++++++---- drivers/md/raid5.c | 15 +++---- drivers/md/raid5.h | 2 +- 13 files changed, 126 insertions(+), 99 deletions(-)