From patchwork Wed May 31 00:35:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bobby Eshleman X-Patchwork-Id: 10074 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2562674vqr; Tue, 30 May 2023 18:02:01 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6XI4oicdc3c3ccBR2w2yidEV88AjzmxrYfmyKxGRac3BkvAexDaDeMQvDdB2l5svi5C0eN X-Received: by 2002:a17:903:2349:b0:1ab:253e:6906 with SMTP id c9-20020a170903234900b001ab253e6906mr4285952plh.67.1685494921338; Tue, 30 May 2023 18:02:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685494921; cv=none; d=google.com; s=arc-20160816; b=elKXUTJIUCNBIgmbsNImslSb0TBkO0lZXzgJCZuaHFbZTk1nA56eoJJ3cK50aSinhX Qi/7jkM/NdlnAr2vTFaqrtKCb2C0lfQWgS85hkAST2I+TI10qPS6D/X26OittNd6FXHU dY9OzTGNvDJ5jTGFIXWvhnjGah81+RpTgtxjnfNQ+8xnHXTuhw6aMibgzOc6MI7myKjr fzjYwlRBAbm30poSExfD3B57EeTkGn0UtNRW+4k/lLLwORKUZKo6LXSzht/oTHoupl46 EsY2ZLmnvth06IcO5+oXbwxpwwDYNGAa8n5IQU+I8goXgpejVPPIpIFJt1AfJvk3VlFn OnRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:content-transfer-encoding:mime-version :message-id:date:subject:from:dkim-signature; bh=xyPVmcVtXqwbPWrU4CXncdNHyJXf/QZjqVsNgbEPnro=; b=ca8Saudg/lIhtUfnd1UH4neVRvz+fTnZP9kAyMME4INXw9+aUp5cF2dV11MGZmEDW8 6TbEY4YKF1jo+Fj88gN9jg1bapRWG46zf3DN1/KJxMbQ2eTNozBdGkAxvfdKusw833fc 1bGPKJRiiYORkrJhEzOe5biuGH9pImuDLnwfNQRuf4XSeE4ZaL1wcRYrcB6Cqv/7U1SC 4eqMXx8Ivv/TM8VvgCgvHvdCBkGMcazDeO1UsR6zfRqtHMlgS5XcfB88XuaJ/qHsVIR3 JQ1akc9WWa2NNmaJzlSFzL0nDm5u+0J33TJOm2BYZrd00kfrR7+int/5yWEVZp8YuI43 kqJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance.com header.s=google header.b="M/Ht7dI5"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=bytedance.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u24-20020a170902a61800b001b02fa876c8si2088464plq.514.2023.05.30.18.01.45; Tue, 30 May 2023 18:02:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance.com header.s=google header.b="M/Ht7dI5"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231545AbjEaAfv (ORCPT + 99 others); Tue, 30 May 2023 20:35:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231417AbjEaAfu (ORCPT ); Tue, 30 May 2023 20:35:50 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7338E51 for ; Tue, 30 May 2023 17:35:19 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-64d426e63baso5765801b3a.0 for ; Tue, 30 May 2023 17:35:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1685493308; x=1688085308; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=xyPVmcVtXqwbPWrU4CXncdNHyJXf/QZjqVsNgbEPnro=; b=M/Ht7dI5kR7S3Pp3LWf8jzAkFhfNDqeCqkoON2LR0mY0zoEnUOpxlPGclMHY+tIK6r 4rEvtdl/EVqdTwzEhhakEXmpdKpY0MNeWy20XfvXiVYey9c7KY+gdRqF1tE2VM3BqcDp wxKnTvZpQueVv6yzT1BT3Aq71eK4sURh//HAR4aGbU2uMrHm1anjx9o4t9eDYJRbYqRX EeAxKbe2diiLhXCQDd8zbMMOk3BiWnTJ4KfK4FipReZMzakVgdbTXp/k1reL4ruAquw/ nwdrUBUhomZSb6kgdQ9rQ3cFY7SJa3/xFEN9nCfYfaySK3RtPLXeD6pNrtLQrio8toqT xF/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685493308; x=1688085308; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xyPVmcVtXqwbPWrU4CXncdNHyJXf/QZjqVsNgbEPnro=; b=Tyo4Yb089bNbRe82ojx3vHqprn42lEvcP5UoSfJvhYQP7RjiP6ICrKx4R3RNNbiCsp g7ly/SXdj7pM8Db0/vVt4kNHc5CSnXNuyJ1cieLHr9U5MX8FAU50PCozJuth+zhg7/ti yXzdLwT5BkEZppk6ysa2jh46MC+qbP0XDo3iBv0RcQ/qgNvdxVreq6EXuvlCtFR3L16m DKmH4dxYwjtiqx4WrZ59tAAu/9Gnokk1tUTqF5HXv/+POipLahxPYu9+2DgehklIRUeJ jRGjvKpUByKNa6FhqASmA/JSdr1Lps/i88Hdt00O8LY3NEodhSJC6ivQe9lG5frT0Iuh 274Q== X-Gm-Message-State: AC+VfDyVDdTOrbM5QLeE+OIqizjR+yo+3sXP1HsN8OxGJ76SQupLPWPL jQyq65Nl40k/hw56H7qaq3Uvsg== X-Received: by 2002:a05:6a00:b50:b0:64c:a554:f577 with SMTP id p16-20020a056a000b5000b0064ca554f577mr4877926pfo.11.1685493308503; Tue, 30 May 2023 17:35:08 -0700 (PDT) Received: from [172.17.0.2] (c-67-170-131-147.hsd1.wa.comcast.net. [67.170.131.147]) by smtp.gmail.com with ESMTPSA id j12-20020a62b60c000000b0064cb0845c77sm2151340pff.122.2023.05.30.17.35.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 17:35:08 -0700 (PDT) From: Bobby Eshleman Subject: [PATCH RFC net-next v3 0/8] virtio/vsock: support datagrams Date: Wed, 31 May 2023 00:35:04 +0000 Message-Id: <20230413-b4-vsock-dgram-v3-0-c2414413ef6a@bytedance.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIADiWdmQC/3WOQQrCMBBFryKzdiQmNUVXguAB3EoXSTq2QZpIE kJL6d1Nu3Dn8s3/nzczRAqWIlx2MwTKNlrvCoj9DkyvXEdo28LAGResOgrUFebozRvbLqgBhZa klVSyohOUkVaRUAflTL/OHCV0NKY1+gR62XFzPeFxv623X94U6G1MPkzbL5lvtX/azJEhq8/G1 IZIcrrqKVFbtHQwfoBmWZYvsS2PotwAAAA= To: Stefan Hajnoczi , Stefano Garzarella , "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Bryan Tan , Vishnu Dasa , VMware PV-Drivers Reviewers Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, Bobby Eshleman , Jiang Wang X-Mailer: b4 0.12.2 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767369522845295108?= X-GMAIL-MSGID: =?utf-8?q?1767369522845295108?= Hey all! This series introduces support for datagrams to virtio/vsock. It is a spin-off (and smaller version) of this series from the summer: https://lore.kernel.org/all/cover.1660362668.git.bobby.eshleman@bytedance.com/ Please note that this is an RFC and should not be merged until associated changes are made to the virtio specification, which will follow after discussion from this series. This series first supports datagrams in a basic form for virtio, and then optimizes the sendpath for all transports. The result is a very fast datagram communication protocol that outperforms even UDP on multi-queue virtio-net w/ vhost on a variety of multi-threaded workload samples. For those that are curious, some summary data comparing UDP and VSOCK DGRAM (N=5): vCPUS: 16 virtio-net queues: 16 payload size: 4KB Setup: bare metal + vm (non-nested) UDP: 287.59 MB/s VSOCK DGRAM: 509.2 MB/s Some notes about the implementation... This datagram implementation forces datagrams to self-throttle according to the threshold set by sk_sndbuf. It behaves similar to the credits used by streams in its effect on throughput and memory consumption, but it is not influenced by the receiving socket as credits are. The device drops packets silently. As discussed previously, this series introduces datagrams and defers fairness to future work. See discussion in v2 for more context around datagrams, fairness, and this implementation. Signed-off-by: Bobby Eshleman --- Changes in v3: - Support multi-transport dgram, changing logic in connect/bind to support VMCI case - Support per-pkt transport lookup for sendto() case - Fix dgram_allow() implementation - Fix dgram feature bit number (now it is 3) - Fix binding so dgram and connectible (cid,port) spaces are non-overlapping - RCU protect transport ptr so connect() calls never leave a lockless read of the transport and remote_addr are always in sync - Link to v2: https://lore.kernel.org/r/20230413-b4-vsock-dgram-v2-0-079cc7cee62e@bytedance.com --- Bobby Eshleman (7): vsock/dgram: generalize recvmsg and drop transport->dgram_dequeue vsock: refactor transport lookup code vsock: support multi-transport datagrams vsock: make vsock bind reusable virtio/vsock: add VIRTIO_VSOCK_F_DGRAM feature bit virtio/vsock: support dgrams vsock: Add lockless sendmsg() support Jiang Wang (1): tests: add vsock dgram tests drivers/vhost/vsock.c | 44 ++- include/linux/virtio_vsock.h | 13 +- include/net/af_vsock.h | 53 ++- include/uapi/linux/virtio_vsock.h | 2 + net/vmw_vsock/af_vsock.c | 615 ++++++++++++++++++++++++++------ net/vmw_vsock/diag.c | 10 +- net/vmw_vsock/hyperv_transport.c | 42 ++- net/vmw_vsock/virtio_transport.c | 28 +- net/vmw_vsock/virtio_transport_common.c | 227 +++++++++--- net/vmw_vsock/vmci_transport.c | 152 ++++---- net/vmw_vsock/vsock_bpf.c | 10 +- net/vmw_vsock/vsock_loopback.c | 13 +- tools/testing/vsock/util.c | 105 ++++++ tools/testing/vsock/util.h | 4 + tools/testing/vsock/vsock_test.c | 193 ++++++++++ 15 files changed, 1259 insertions(+), 252 deletions(-) --- base-commit: ed72bd5a6790a0c3747cb32b0427f921bd03bb71 change-id: 20230413-b4-vsock-dgram-3b6eba6a64e5 Best regards,