mbox series

[net-next,0/8] Ocelot/Felix driver cleanup

Message ID 20230412124737.2243527-1-vladimir.oltean@nxp.com
Headers
Series Ocelot/Felix driver cleanup |

Message

Vladimir Oltean April 12, 2023, 12:47 p.m. UTC 
  The cleanup mostly handles the statistics code path - some issues
regarding understandability became apparent after the series
"Fix trainwreck with Ocelot switch statistics counters":
https://lore.kernel.org/netdev/20230321010325.897817-1-vladimir.oltean@nxp.com/

There is also one patch which cleans up a misleading comment
in the DSA felix_setup().

Vladimir Oltean (8):
  net: mscc: ocelot: strengthen type of "u32 reg" in I/O accessors
  net: mscc: ocelot: refactor enum ocelot_reg decoding to helper
  net: mscc: ocelot: debugging print for statistics regions
  net: mscc: ocelot: remove blank line at the end of ocelot_stats.c
  net: dsa: felix: remove confusing/incorrect comment from felix_setup()
  net: mscc: ocelot: strengthen type of "u32 reg" and "u32 base" in
    ocelot_stats.c
  net: mscc: ocelot: strengthen type of "int i" in ocelot_stats.c
  net: mscc: ocelot: fix ineffective WARN_ON() in ocelot_stats.c

 drivers/net/dsa/ocelot/felix.c           |  5 ---
 drivers/net/ethernet/mscc/ocelot.h       |  9 +++++
 drivers/net/ethernet/mscc/ocelot_io.c    | 50 +++++++++++++-----------
 drivers/net/ethernet/mscc/ocelot_stats.c | 42 +++++++++++++-------
 include/soc/mscc/ocelot.h                | 20 +++++-----
 5 files changed, 75 insertions(+), 51 deletions(-)

Comments

Colin Foster April 13, 2023, 12:45 a.m. UTC | #1 
Hi Vladimir,

On Wed, Apr 12, 2023 at 03:47:29PM +0300, Vladimir Oltean wrote:
> The cleanup mostly handles the statistics code path - some issues
> regarding understandability became apparent after the series
> "Fix trainwreck with Ocelot switch statistics counters":
> https://lore.kernel.org/netdev/20230321010325.897817-1-vladimir.oltean@nxp.com/
> 
> There is also one patch which cleans up a misleading comment
> in the DSA felix_setup().

Sorry I won't have access to hardware until next week, so I can't add
any tested-bys. But this whole set is straightforward, it probably
isn't too necessary. Let me know if there's anything you want from me on
this set.


Colin
Vladimir Oltean April 13, 2023, 10:08 a.m. UTC | #2 
Hi Colin,

On Wed, Apr 12, 2023 at 05:45:34PM -0700, Colin Foster wrote:
> Sorry I won't have access to hardware until next week, so I can't add
> any tested-bys. But this whole set is straightforward, it probably
> isn't too necessary. Let me know if there's anything you want from me on
> this set.

I've tested the patches on Felix; hopefully there is no reason why they
would introduce regressions.

I copied you just to make sure you're aware of the changes, because it's
all code you've visited, contributed to, and which has confused you (and
me too).
patchwork-bot+netdevbpf@kernel.org April 14, 2023, 5:20 a.m. UTC | #3 
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 12 Apr 2023 15:47:29 +0300 you wrote:
> The cleanup mostly handles the statistics code path - some issues
> regarding understandability became apparent after the series
> "Fix trainwreck with Ocelot switch statistics counters":
> https://lore.kernel.org/netdev/20230321010325.897817-1-vladimir.oltean@nxp.com/
> 
> There is also one patch which cleans up a misleading comment
> in the DSA felix_setup().
> 
> [...]

Here is the summary with links:
  - [net-next,1/8] net: mscc: ocelot: strengthen type of "u32 reg" in I/O accessors
    https://git.kernel.org/netdev/net-next/c/9ecd05794b8d
  - [net-next,2/8] net: mscc: ocelot: refactor enum ocelot_reg decoding to helper
    https://git.kernel.org/netdev/net-next/c/40cd07cb4261
  - [net-next,3/8] net: mscc: ocelot: debugging print for statistics regions
    https://git.kernel.org/netdev/net-next/c/07de32655bb4
  - [net-next,4/8] net: mscc: ocelot: remove blank line at the end of ocelot_stats.c
    https://git.kernel.org/netdev/net-next/c/93f0f93bbdb9
  - [net-next,5/8] net: dsa: felix: remove confusing/incorrect comment from felix_setup()
    https://git.kernel.org/netdev/net-next/c/a9afc3e41c61
  - [net-next,6/8] net: mscc: ocelot: strengthen type of "u32 reg" and "u32 base" in ocelot_stats.c
    https://git.kernel.org/netdev/net-next/c/eae0b9d15ba6
  - [net-next,7/8] net: mscc: ocelot: strengthen type of "int i" in ocelot_stats.c
    https://git.kernel.org/netdev/net-next/c/6663c01eca1a
  - [net-next,8/8] net: mscc: ocelot: fix ineffective WARN_ON() in ocelot_stats.c
    https://git.kernel.org/netdev/net-next/c/a291399e6354

You are awesome, thank you!