Message ID | 20230412045152.4694-1-zhuyinbo@loongson.cn |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp70819vqo; Tue, 11 Apr 2023 22:02:43 -0700 (PDT) X-Google-Smtp-Source: AKy350YfyTCHsSyGAfBDDcio0rcZ0W8M22vfoc/A0ap58WSlcRJg55voPRUgTas6lJnBtd08XClJ X-Received: by 2002:a05:6402:32f:b0:500:50f6:dd34 with SMTP id q15-20020a056402032f00b0050050f6dd34mr14610936edw.1.1681275762964; Tue, 11 Apr 2023 22:02:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681275762; cv=none; d=google.com; s=arc-20160816; b=B978FP51HyUGWh8bftKFTUK6wxhwJvIydURUvF3VZ3Ebkf/KJCgPUgpLrXlFIaljRo DOiDlaWiHpMF6cRnSHygBKtcfRWbbnD8GiR4vj9YDbXuPthUiJ3hgZkCSUXCD4DqtKOG SZHteLpgQflG95X/oef6AyLdEKZx/TSpgod6FnHErjSqJ7+zgvSTOPQc66/r/kbNXJe7 ze7bjf9EqliHpJw4mQgiFTPXyEa5NTfwmCQxQaBLDFxgk7ZjKE5UvQZqNdZJ9Nr1uhxH 7KIvh8pqx7Xt0uUNGZEma9SNn2qsrag5rhF1Jch5ryqNkmoinUSiRk413QE9sxeYw1Sx zGfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=kvbIQ0+cdgPIdymgbBtUUmUZUGhvqmmgW537wXUMVTo=; b=Gp1MEIogi2iYvltQJigshu7MCWnxhenxa2vQneYViYaLmS4+/fa9onWd1xidYjJ6c8 6WTCK7fU+dJ/dKYID4na78dH6x10a2vT9mpFBjafVKm9njyz4q0w6sx6yDp57V18TZSi MkYsl54Dx0LrZdmd9sOCYSMdNBihHRVg2l6bUHjsCdqRWT5EvrrfAwfQC6d9GVj9vKWG eZQBwddjkp6ByVCMEQVfs7kfkBgWE0Vw2su0Ib0QrnQdxSdXNPqrRcbZmwZD1jVnYDCO FBDzfM79JYQFbE7PkObH5+HG2TDzY58e8FmVPp4QjxLj17SqOldnVbAAyxgDmZbkcDDT RjVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id tf13-20020a1709078d8d00b0094a4000f49dsi3807933ejc.271.2023.04.11.22.02.19; Tue, 11 Apr 2023 22:02:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229626AbjDLEwJ (ORCPT <rfc822;leviz.kernel.dev@gmail.com> + 99 others); Wed, 12 Apr 2023 00:52:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229485AbjDLEwE (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 12 Apr 2023 00:52:04 -0400 Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D17DA3C31; Tue, 11 Apr 2023 21:52:01 -0700 (PDT) Received: from loongson.cn (unknown [10.20.42.35]) by gateway (Coremail) with SMTP id _____8BxMMzwODZkjvQaAA--.41767S3; Wed, 12 Apr 2023 12:52:00 +0800 (CST) Received: from user-pc.202.106.0.20 (unknown [10.20.42.35]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Dxjb7qODZk+RogAA--.60030S2; Wed, 12 Apr 2023 12:51:58 +0800 (CST) From: Yinbo Zhu <zhuyinbo@loongson.cn> To: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jianmin Lv <lvjianmin@loongson.cn>, wanghongliang@loongson.cn, Liu Peibao <liupeibao@loongson.cn>, loongson-kernel@lists.loongnix.cn, Yinbo Zhu <zhuyinbo@loongson.cn> Subject: [PATCH v7 0/2] spi: loongson: add bus driver for the loongson spi Date: Wed, 12 Apr 2023 12:51:50 +0800 Message-Id: <20230412045152.4694-1-zhuyinbo@loongson.cn> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: AQAAf8Dxjb7qODZk+RogAA--.60030S2 X-CM-SenderInfo: 52kx5xhqerqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBjvJXoWxWFy3Zr48trWrJw4UuFW5Awb_yoW5urWUpF W5Cas8Kr4DtF4xArs3Jay7uFyrZ3yrXrZrXay3twsruryDZ34UZr1vqF15ZrZrAFsIvFyx XFyvgrs5Ga4UZwUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUj1kv1TuYvTs0mT0YCTnIWj qI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUIcSsGvfJTRUUU b78Fc2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AKwVWUGVWUXwA2ocxC64 kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28E F7xvwVC0I7IYx2IY6xkF7I0E14v26r4j6F4UM28EF7xvwVC2z280aVAFwI0_Gr1j6F4UJw A2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr1j6F4UJwAS0I0E0xvYzxvE52x082IY62kv0487 Mc804VCY07AIYIkI8VC2zVCFFI0UMc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2 IY67AKxVWUGVWUXwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0 Y48IcxkI7VAKI48JMxAIw28IcxkI7VAKI48JMxAIw28IcVCjz48v1sIEY20_WwCFx2IqxV CFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r10 6r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxV WUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG 6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_Gr UvcSsGvfC2KfnxnUUI43ZEXa7IU1VWlDUUUUU== X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762945414285985064?= X-GMAIL-MSGID: =?utf-8?q?1762945414285985064?= |
Series |
spi: loongson: add bus driver for the loongson spi
|
|
Message
Yinbo Zhu
April 12, 2023, 4:51 a.m. UTC
Loongson platform support spi hardware controller and this series patch was to add spi driver and binding support. Change in v2: 1. This [PATCH v2 1/2] dt-bindings patch need depend on clk patch: https:// lore.kernel.org/all/20230307115022.12846-1-zhuyinbo@loongson.cn/ 2. Remove the clock-names in spi yaml file. 3. Add "loongson,ls7a-spi" compatible in spi yaml file. 4. Add an || COMPILE_TEST and drop && PCI then add some CONFIG_PCI macro to limit some pci code. 5. Make the spi driver top code comment block that use C++ style. 6. Drop spi->max_speed_hz. 7. Add a spin_lock for loongson_spi_setup. 8. Add a timeout and cpu_relax() in loongson_spi_write_read_8bit. 9. Add spi_transfer_one and drop transfer and rework entire spi driver that include some necessary changes. 10. Use module_init replace subsys_initcall. 11. About PM interface that I don't find any issue so I don't add any changes. Change in v3: 1. This [PATCH v3 1/2] dt-bindings patch need depend on clk patch: https:// lore.kernel.org/all/20230323025229.2971-1-zhuyinbo@loongson.cn/ 2. Drop the unused blank line in loongson,ls-spi.yaml file. 3. Replace clock minItems with clock maxItems in yaml file. 4. Separate spi driver into platform module, pci module and core module. 5. Replace DIV_ROUND_UP with DIV_ROUND_UP_ULL to fix compile error "undefined reference to `__aeabi_uldivmod'" and "__udivdi3 undefined" that reported by test robot. 6. Remove the spin lock. 7. Clear the loongson_spi->hz and loongson_spi->mode in setup to fixup the issue that multiple spi device transfer that maybe cause spi was be misconfigured. Change in v4: 1. This [PATCH v4 1/2] dt-bindings patch need depend on clk patch: https:// lore.kernel.org/all/20230323025229.2971-1-zhuyinbo@loongson.cn/ 2. Add "#include <linux/io.h>" in spi-loongson-core.c for fix the compile issue which devm_ioremap no declaration. 3. Add "EXPORT_SYMBOL_GPL(loongson_spi_dev_pm_ops)" in spi-loongson-core.c for fix the compile issue which loongson_spi_dev_pm_ops undefined. Change in v5: 1. Get rid of the clock patch's dependency and open-code the clock IDs. 2. Fixup checkpatch issue that by installed ply and gitpython package locally, but this series of patch's code doesn't have any change. Change in v6: 1. Remove the "#include <dt-bindings/clock/loongson,ls2k-clk.h>" in yaml file. Change in v7: 1. Remove the "loongson,ls7a-spi" and change yaml file name as "loongson,ls2k-spi.yaml". 2. Use module_pci_driver and module_platform_driver to replace module_init and module_exit. 3. Drop ".owner = THIS_MODULE" in spi platform driver. 4. Add devm_spi_alloc_master devm_spi_register_master to simplify code. 5. Add pci_disable_device() in loongson_spi_pci_unregister. Yinbo Zhu (2): dt-bindings: spi: add loongson spi spi: loongson: add bus driver for the loongson spi controller .../bindings/spi/loongson,ls2k-spi.yaml | 41 +++ MAINTAINERS | 10 + drivers/spi/Kconfig | 31 ++ drivers/spi/Makefile | 3 + drivers/spi/spi-loongson-core.c | 292 ++++++++++++++++++ drivers/spi/spi-loongson-pci.c | 72 +++++ drivers/spi/spi-loongson-plat.c | 47 +++ drivers/spi/spi-loongson.h | 41 +++ 8 files changed, 537 insertions(+)
Comments
On 12/04/2023 06:51, Yinbo Zhu wrote: > Loongson platform support spi hardware controller and this series patch > was to add spi driver and binding support. > > Change in v2: > 1. This [PATCH v2 1/2] dt-bindings patch need depend on clk patch: > https:// Can you stop Ccing fake address "loongson-kernel@lists.loongnix.cn"? It does not exist. Remove it from all submissions. Best regards, Krzysztof
在 2023/4/15 上午4:43, Krzysztof Kozlowski 写道: > On 12/04/2023 06:51, Yinbo Zhu wrote: >> Loongson platform support spi hardware controller and this series patch >> was to add spi driver and binding support. >> >> Change in v2: >> 1. This [PATCH v2 1/2] dt-bindings patch need depend on clk patch: >> https:// > > Can you stop Ccing fake address "loongson-kernel@lists.loongnix.cn"? It > does not exist. Remove it from all submissions.Recently, There was some issue with the company's email server, causing this mail list "loongson-kernel@lists.loongnix.cn" to only accept internal emails and not accpet external emails. The company's IT is working to fix this issue. and Ccing this mail list is an internal requirement. I will not send emails to this mail list until this email sever issue is resolved. Thanks. > > Best regards, > Krzysztof >
On 18/04/2023 04:53, zhuyinbo wrote: > > > 在 2023/4/15 上午4:43, Krzysztof Kozlowski 写道: >> On 12/04/2023 06:51, Yinbo Zhu wrote: >>> Loongson platform support spi hardware controller and this series patch >>> was to add spi driver and binding support. >>> >>> Change in v2: >>> 1. This [PATCH v2 1/2] dt-bindings patch need depend on clk patch: >>> https:// >> >> Can you stop Ccing fake address "loongson-kernel@lists.loongnix.cn"? It >> does not exist. Remove it from all submissions.Recently, There was some issue with the company's email server, causing > this mail list "loongson-kernel@lists.loongnix.cn" to only accept > internal emails and not accpet external emails. The company's IT is > working to fix this issue. and Ccing this mail list is an internal > requirement. I will not send emails to this mail list until this email > sever issue is resolved. You can always Bcc it, if you have such requirement. However your internal requirements should not cause my removing all the time multiple bounces... Best regards, Krzysztof
在 2023/4/18 下午3:06, Krzysztof Kozlowski 写道: > On 18/04/2023 04:53, zhuyinbo wrote: >> >> >> 在 2023/4/15 上午4:43, Krzysztof Kozlowski 写道: >>> On 12/04/2023 06:51, Yinbo Zhu wrote: >>>> Loongson platform support spi hardware controller and this series patch >>>> was to add spi driver and binding support. >>>> >>>> Change in v2: >>>> 1. This [PATCH v2 1/2] dt-bindings patch need depend on clk patch: >>>> https:// >>> >>> Can you stop Ccing fake address "loongson-kernel@lists.loongnix.cn"? It >>> does not exist. Remove it from all submissions.Recently, There was some issue with the company's email server, causing >> this mail list "loongson-kernel@lists.loongnix.cn" to only accept >> internal emails and not accpet external emails. The company's IT is >> working to fix this issue. and Ccing this mail list is an internal >> requirement. I will not send emails to this mail list until this email >> sever issue is resolved. > > You can always Bcc it, if you have such requirement. However your > internal requirements should not cause my removing all the time multiple > bounces... > okay, I got it. Thanks. > Best regards, > Krzysztof >
在 2023/4/18 下午3:06, Krzysztof Kozlowski 写道: > On 18/04/2023 04:53, zhuyinbo wrote: >> >> >> 在 2023/4/15 上午4:43, Krzysztof Kozlowski 写道: >>> On 12/04/2023 06:51, Yinbo Zhu wrote: >>>> Loongson platform support spi hardware controller and this series patch >>>> was to add spi driver and binding support. >>>> >>>> Change in v2: >>>> 1. This [PATCH v2 1/2] dt-bindings patch need depend on clk patch: >>>> https:// >>> >>> Can you stop Ccing fake address "loongson-kernel@lists.loongnix.cn"? It >>> does not exist. Remove it from all submissions.Recently, There was some issue with the company's email server, causing >> this mail list "loongson-kernel@lists.loongnix.cn" to only accept >> internal emails and not accpet external emails. The company's IT is >> working to fix this issue. and Ccing this mail list is an internal >> requirement. I will not send emails to this mail list until this email >> sever issue is resolved. > > You can always Bcc it, if you have such requirement. However your > internal requirements should not cause my removing all the time multiple > bounces... The company' IT had fix that mail list server issue and ccing that mail list "loongson-kernel@lists.loongnix.cn" that will not cause your removing all the time multiple bounces. Thanks. > > Best regards, > Krzysztof >