Message ID | 20230409-ipvs-cleanup-v1-0-98cdc242feb0@kernel.org |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1785601vqo; Mon, 10 Apr 2023 02:56:05 -0700 (PDT) X-Google-Smtp-Source: AKy350b96sVYrMVAtrx5ew0/Tz+hUBkuvxmD1aayBAzOluAcr3M5WKvQUzGc6XxnHidFfuip4rh7 X-Received: by 2002:a05:6a20:8f02:b0:e9:14e9:46ee with SMTP id b2-20020a056a208f0200b000e914e946eemr9854631pzk.28.1681120565537; Mon, 10 Apr 2023 02:56:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681120565; cv=none; d=google.com; s=arc-20160816; b=Pq3EJ5VOqFknJkcn+gGROH1GpmBTNgCq13ql2TuaMAjiOEOdjYDrVIWWCXxXWFerIA oEeChBvE3ZXU4LUtq3hW3Lko70/Xodx6yPBfFdmm3BVgnIKG5fe45Bv+0QmvYoT6eXm+ jgxKIuXE0toeDJvmXBuHB44xazHfvJjhofgMlBH1KlLHmON9Pi9qxE64ZQUjoAluozIy 0UC+hdtgCdEH/y9n9yZGKkrtewkizANyhzricRGVhyfqji2Y5OtOY3FcTllYUQKJTgOu WyyJ1/2R+WMbSF/FbDPdfu0XIeV3dSAfaNNqlWSLgI7hGcF5EyxbABYv8mkS0q5mX1JZ ZlOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:content-transfer-encoding:mime-version :message-id:date:subject:from:dkim-signature; bh=MmD8m5qwSItjRrrxKoTXejxIT9pEKFUkZlHMyYPVXVQ=; b=JZk84d9R4kOI0hkPuWom4rqeJFhPor+vQik2isujTrXSe9u7zW7U4xIXmRfKRB79ND aq9sTlKepDheoMF0pHyRX+8Qu3L4W1/0ZNfR1x68Bu9n4bAepw3smKXMUhroFPAh6GnW l4nwllLwVZw2UYpiE/G3gdlA8DNlHaH5sZgKPG8l5PXUII5XUH18DQ8LHqoHuJ3+rvAZ 9Qcb/I6dxUCvX9+O2n+ZTGJG/JPfPckOw8H/Xa5X6QidREm8Bxj0FySA4QLlavU6imbE pyoVZDMJB5ftB8uI+7eqpi+Lwdga3R8Ks4wdkPMZ+V4avgN+4Tu1tiszFkdyjFNK+yR1 62VA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CoX2RYe8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q26-20020a65625a000000b004fab4df6dfdsi9939581pgv.369.2023.04.10.02.55.53; Mon, 10 Apr 2023 02:56:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CoX2RYe8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229612AbjDJJm5 (ORCPT <rfc822;a1648639935@gmail.com> + 99 others); Mon, 10 Apr 2023 05:42:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229504AbjDJJmy (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 10 Apr 2023 05:42:54 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44C7B1FDD; Mon, 10 Apr 2023 02:42:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D4C5861173; Mon, 10 Apr 2023 09:42:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7B68C433EF; Mon, 10 Apr 2023 09:42:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681119772; bh=8mrBnTnoB7t/AMZsj2+xBakPM4atwfooXq/n+Cg7RAQ=; h=From:Subject:Date:To:Cc:From; b=CoX2RYe8cQ2we16K9+P55yWV+r9uxBDPNf0hWTcGUACIfXRRqeDcN1VkZU+6mm+mv AoRfKYjoc2F4JbJ23/gZQ/9JjKsClQi3txlYZ6+/f0BrNv0wy5ckQjOe7Aqjcg/pul +jHotl140CMH4UQy+wOxj8t14N5Xp1S+zWGcM1mQvxCjqY40tzXn5od0JzuAgHb45A /VmOT16YeUmHikK6S1hgYbKnA9SsZDh72reIyMcIg8vloChzQqQE61jjc41sKYfLp2 ntF0OeY+Fd7XCSlOYd6GeKg4wUydE/SxJHXSEmXcfYwfi4J/pYB4c+iTw79bHeHbTW rAvL5dTr6HAmQ== From: Simon Horman <horms@kernel.org> Subject: [PATCH nf-next 0/4] ipvs: Cleanups for v6.4 Date: Mon, 10 Apr 2023 11:42:34 +0200 Message-Id: <20230409-ipvs-cleanup-v1-0-98cdc242feb0@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAAraM2QC/x2NSQrDMAwAvxJ0rsBVupB+pfQgu0ojMKqxkhAI+ XtNjzMwzA4uVcXh0e1QZVXXrzU4nzpIE9tHUN+NgQL14RIG1LI6pixsS8GYBr4S072nG7Qksgv GypamFtmSc5Olyqjb//EEG9Fkm+F1HD8K/rUrfAAAAA== To: Julian Anastasov <ja@ssi.bg> Cc: Pablo Neira Ayuso <pablo@netfilter.org>, Jozsef Kadlecsik <kadlec@netfilter.org>, Florian Westphal <fw@strlen.de>, netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>, David Ahern <dsahern@kernel.org>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, lvs-devel@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org X-Mailer: b4 0.12.2 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762782678264479211?= X-GMAIL-MSGID: =?utf-8?q?1762782678264479211?= |
Series | ipvs: Cleanups for v6.4 | |
Message
Simon Horman
April 10, 2023, 9:42 a.m. UTC
Hi Pablo, this series aims to clean up IPVS in several ways without implementing any functional changes, aside from removing some debugging output. Patch 1/4: Update width of source for ip_vs_sync_con_options The operation is safe, use an annotation to describe it properly. Patch 2/4: Consistently use array_size() in ip_vs_conn_init() It seems better to use helpers consistently. Patch 3/4: Remove {Enter,Leave}Function These seem to be well past their use-by date. Patch 4/4: Correct spelling in comments I can't spell. But codespell helps me these days. All changes: compile tested only! --- Simon Horman (4): ipvs: Update width of source for ip_vs_sync_con_options ipvs: Consistently use array_size() in ip_vs_conn_init() ipvs: Remove {Enter,Leave}Function ipvs: Correct spelling in comments include/net/ip_vs.h | 32 +++++---------------- net/netfilter/ipvs/ip_vs_conn.c | 12 ++++---- net/netfilter/ipvs/ip_vs_core.c | 8 ------ net/netfilter/ipvs/ip_vs_ctl.c | 26 +---------------- net/netfilter/ipvs/ip_vs_sync.c | 7 +---- net/netfilter/ipvs/ip_vs_xmit.c | 62 ++++++----------------------------------- 6 files changed, 23 insertions(+), 124 deletions(-) base-commit: 9b7c68b3911aef84afa4cbfc31bce20f10570d51
Comments
On Mon, Apr 10, 2023 at 11:42:34AM +0200, Simon Horman wrote: > Hi Pablo, > > this series aims to clean up IPVS in several ways without > implementing any functional changes, aside from removing > some debugging output. > > Patch 1/4: Update width of source for ip_vs_sync_con_options > The operation is safe, use an annotation to describe it properly. > > Patch 2/4: Consistently use array_size() in ip_vs_conn_init() > It seems better to use helpers consistently. > > Patch 3/4: Remove {Enter,Leave}Function > These seem to be well past their use-by date. > > Patch 4/4: Correct spelling in comments > I can't spell. But codespell helps me these days. > > All changes: compile tested only! Hi all, Julian pointed out some minor issues which I will address in a v2.