mbox series

[v4,0/6] KVM: selftests: Add "instructions required" testcase

Message ID 20230407233254.957013-1-seanjc@google.com
Headers
Series KVM: selftests: Add "instructions required" testcase |

Message

Sean Christopherson April 7, 2023, 11:32 p.m. UTC 
  This is the selftests portion of Aaron's series[*] to fix incorrect
"instructions required" counting.  The big change from v3 is to use a
common struct to copy counter values to/from the guest instead of smushing
the values into a single 64-bit value.

[*] https://lkml.kernel.org/r/20230307141400.1486314-1-aaronlewis%40google.com

Aaron Lewis (4):
  KVM: selftests: Add a common helper for the PMU event filter guest
    code
  KVM: selftests: Add helpers for PMC asserts in PMU event filter test
  KVM: selftests: Print detailed info in PMU event filter asserts
  KVM: selftests: Test the PMU event "Instructions retired"

Sean Christopherson (2):
  KVM: selftests: Use error codes to signal errors in PMU event filter
    test
  KVM: selftests: Copy full counter values from guest in PMU event
    filter test

 .../kvm/x86_64/pmu_event_filter_test.c        | 252 ++++++++++--------
 1 file changed, 140 insertions(+), 112 deletions(-)


base-commit: b821bf96cf3bed0c1c8d34659299a3a1dc47218d

Comments

Aaron Lewis April 12, 2023, 11:06 p.m. UTC | #1 
On Fri, Apr 7, 2023 at 11:33 PM Sean Christopherson <seanjc@google.com> wrote:
>
> This is the selftests portion of Aaron's series[*] to fix incorrect
> "instructions required" counting.  The big change from v3 is to use a

nit: here and in the subject, s/required/retired/.

> common struct to copy counter values to/from the guest instead of smushing
> the values into a single 64-bit value.
>
> [*] https://lkml.kernel.org/r/20230307141400.1486314-1-aaronlewis%40google.com
>
> Aaron Lewis (4):
>   KVM: selftests: Add a common helper for the PMU event filter guest
>     code
>   KVM: selftests: Add helpers for PMC asserts in PMU event filter test
>   KVM: selftests: Print detailed info in PMU event filter asserts
>   KVM: selftests: Test the PMU event "Instructions retired"
>
> Sean Christopherson (2):
>   KVM: selftests: Use error codes to signal errors in PMU event filter
>     test
>   KVM: selftests: Copy full counter values from guest in PMU event
>     filter test
>
>  .../kvm/x86_64/pmu_event_filter_test.c        | 252 ++++++++++--------
>  1 file changed, 140 insertions(+), 112 deletions(-)
>
>
> base-commit: b821bf96cf3bed0c1c8d34659299a3a1dc47218d
> --
> 2.40.0.577.gac1e443424-goog
>

Fingers crossed that marking this as "plain text" works this time.

Reviewed by: Aaron Lewis <aaronlewis@google.com>
Sean Christopherson April 14, 2023, 8:29 p.m. UTC | #2 
On Fri, 07 Apr 2023 16:32:48 -0700, Sean Christopherson wrote:
> This is the selftests portion of Aaron's series[*] to fix incorrect
> "instructions required" counting.  The big change from v3 is to use a
> common struct to copy counter values to/from the guest instead of smushing
> the values into a single 64-bit value.
> 
> [*] https://lkml.kernel.org/r/20230307141400.1486314-1-aaronlewis%40google.com
> 
> [...]

Applied to kvm-x86 pmu, thanks!

[1/6] KVM: selftests: Add a common helper for the PMU event filter guest code
      https://github.com/kvm-x86/linux/commit/33ef1411a36b
[2/6] KVM: selftests: Add helpers for PMC asserts in PMU event filter test
      https://github.com/kvm-x86/linux/commit/fa32233d51b9
[3/6] KVM: selftests: Print detailed info in PMU event filter asserts
      https://github.com/kvm-x86/linux/commit/c140e93a0c11
[4/6] KVM: selftests: Use error codes to signal errors in PMU event filter test
      https://github.com/kvm-x86/linux/commit/c02c74428288
[5/6] KVM: selftests: Copy full counter values from guest in PMU event filter test
      https://github.com/kvm-x86/linux/commit/e9f322bd2396
[6/6] KVM: selftests: Test the PMU event "Instructions retired"
      https://github.com/kvm-x86/linux/commit/457bd7af1a17

--
https://github.com/kvm-x86/linux/tree/next
https://github.com/kvm-x86/linux/tree/fixes