From patchwork Wed Apr 5 02:21:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 7730 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp11909vqo; Tue, 4 Apr 2023 19:25:06 -0700 (PDT) X-Google-Smtp-Source: AKy350ab5ZgAZs5vdJhLbtagCT6KwOhix8iUDI+A4mhzJs7QhbzV5/Y3+5xL1Ewb2JN8RwhcWMAk X-Received: by 2002:a17:90b:3802:b0:233:c301:32b3 with SMTP id mq2-20020a17090b380200b00233c30132b3mr5077561pjb.3.1680661506180; Tue, 04 Apr 2023 19:25:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680661506; cv=none; d=google.com; s=arc-20160816; b=PwBzJC/tXNa7ITKOFS2BUkx5cPVHHlvRZ4/Yr4YLwmcOaj/PB6xZ6aNiLTmY1YIDaZ 5DjGb8/F3isr2XdQ4W0j4qHDRczvZdjQweEV81I8bs3iRF9ax86gOndtCt7H1oDFB+jn ScTxK8EQrKXxNDKLrQ07zksYwqfTH/afHECUl+4bPR+D+Yd0x85bSR2pEGPI/ezsZAkN wHGbhE6nbNBiOXa/Mrt5SIvitff//Kw4dzIKBvIpVV7GEU7Z5owVlTCwsyh1f7JIhPEQ IMNRIn69JxhkC/LjfDgV+dNbgjxtwjUY0XlesCXY6ZnqxHK0i0eWIqWDpEFrsXhyQd2x NrPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:date:user-agent:message-id; bh=qEhY7G1FPfEsMhC11gjTqM5zf0jS8343LpRoAZsvqN8=; b=vrleX9fzKbbeYXyL7fzBX8W0T8XOkdh3u7GMspEoVxrxlvtJYvfSlKtksFc95orUEM ghiTKOo15VnmPoFk1dKyqdGFBJtyMJzFEGjOke3X/CiOV6OswoEYwr/1bb35rpef6Z3v BGxdAfB7lnHF517b1BKr/F4xjbwkjT0jshbfHvqVaLzSB4ZsM6wjcZGr2vWuq7zs78kU 0ZfXy7LSN7j8XCeGtMf7kXh/GBAx+DBo6Fi4ibFZEFvKdAAqOKFiN9KIr35PTxabP4UU 9gQwJeHUtSw+xOkbm6IYKlqlNRiKa9TqkmQAnmE63OlWCicwcAIR7xjqRFKDEiVGB6YM hLLg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o1-20020a1709026b0100b001a1b9e6289bsi11458222plk.55.2023.04.04.19.24.54; Tue, 04 Apr 2023 19:25:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236711AbjDECXr (ORCPT + 99 others); Tue, 4 Apr 2023 22:23:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233678AbjDECXo (ORCPT ); Tue, 4 Apr 2023 22:23:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEE4B1FE3; Tue, 4 Apr 2023 19:23:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 75D976365A; Wed, 5 Apr 2023 02:23:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8AFAC433D2; Wed, 5 Apr 2023 02:23:42 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.96) (envelope-from ) id 1pjsoH-000hUd-27; Tue, 04 Apr 2023 22:23:41 -0400 Message-ID: <20230405022113.860447811@goodmis.org> User-Agent: quilt/0.66 Date: Tue, 04 Apr 2023 22:21:13 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Andrew Morton , Ross Zwisler Subject: [PATCH 0/2 v2] tracing: Fix ftrace_boot_snapshot command line X-Spam-Status: No, score=-2.1 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762288830874931447?= X-GMAIL-MSGID: =?utf-8?q?1762301319488130594?= While debugging some boot up code, I found that the snapshots were constantly triggering at boot up, even though there was no boot snapshot specified. Looking into it, I found there were too bugs. 1) It would trigger a snapshot on any instance if one was created from the kernel command line. 2) The error handling would only affect the top level instance. So the fact that a snapshot was done on a instance that didn't allocate a buffer triggered a warning written into the top level buffer, and worse yet, disabled the top level buffer. Changes since v1: https://lore.kernel.org/linux-trace-kernel/20230404230011.757302390@goodmis.org/ - My tests failed due to tr->allocated_snapshot only being a field when CONFIG_TRACE_MAX_TRACE is defined. And it doesn't make sense doing any of that logic if it is not, as snapshots depend on that config. This addresses both of the above bugs. Steven Rostedt (Google) (2): tracing: Have tracing_snapshot_instance_cond() write errors to the appropriate instance tracing: Fix ftrace_boot_snapshot command line logic ---- kernel/trace/trace.c | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-)