From patchwork Tue Apr 4 23:00:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 7727 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp209261vqo; Tue, 4 Apr 2023 16:06:36 -0700 (PDT) X-Google-Smtp-Source: AKy350Z1IbKG4Shk8rIUdv6Wn1mzx3FNKN5JHi+p1bwKbf+JwPSzgfC4IsHWu7WjoZbpX9qk5BZ8 X-Received: by 2002:a17:902:f243:b0:1a0:4ebd:15d5 with SMTP id j3-20020a170902f24300b001a04ebd15d5mr3263549plc.67.1680649596018; Tue, 04 Apr 2023 16:06:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680649596; cv=none; d=google.com; s=arc-20160816; b=zA3tx7ouDJIuWMO95oO1mk/prnxlCJqtLq1ooVqOUzFlmubt6mEUCRjnRh4jbdvR6O O0HCH2F6RKPm6f01YEwySvZGYpNkDqCAIncuXryFq0OmIdR8fYR6IEOeAx8K2Gk/Hqbo YqTDiv31rnpZQTydl7JMaAnMPa+AJWyXZGnjFzfO8kBMgUZxUVaCUQUOlTH0nH73iBa5 yCiZfGA1qT2KxBMtNg9ckkxVyEfw23jqf4/P48BtVsKnPpsqVNAi3IQQYJqQK1r5UmXz 10BToqstjLervEND1J7d0hJpQxUEXN5e6hg55tOWpTMo+BTvj1Abu7l/B2tys4o/eR9m ERpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:date:user-agent:message-id; bh=rVrfOdhw3UjTYS6VJmPEJKKY5s/w+A16ZZpXbObtp2Q=; b=NWVzqOMOJF75DrQhuflsvclRa/CoMnEGOj03IQ1DSG6vgr2YUvFVtZFRu21IhtmKee CqXNI4oJzqjObdEMdfo5RbgGyF3u9FBf3c2TTi3i/ObZQwleqRaEBH3A91u/J32gtPUB dmJaVQnRWY1/vYobtKhM2GS192ageCJ4MG0fZx4O5RhtCvhT7sM3vaArvDtl3HjjRyOq DNH5V+IwhUy+BHyS9Hlw0XLLa5xgx+zHST1wZ3yQgQzbRM4vG+bSk07ZpdmqONoMp/e7 ASHC8CUXYdNH/+F9CKfm564FpMQED39FFzXlzdUN8hTVkjN5aWqihzKGC+dOQyWYu+Gy Ouzw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f17-20020a170902ce9100b001a1edb957ecsi11695840plg.515.2023.04.04.16.06.23; Tue, 04 Apr 2023 16:06:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236671AbjDDXDN (ORCPT + 99 others); Tue, 4 Apr 2023 19:03:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236361AbjDDXDM (ORCPT ); Tue, 4 Apr 2023 19:03:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BC02171E; Tue, 4 Apr 2023 16:03:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 39DC96393F; Tue, 4 Apr 2023 23:03:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9CF42C433D2; Tue, 4 Apr 2023 23:03:09 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.96) (envelope-from ) id 1pjpgC-000elE-0r; Tue, 04 Apr 2023 19:03:08 -0400 Message-ID: <20230404230011.757302390@goodmis.org> User-Agent: quilt/0.66 Date: Tue, 04 Apr 2023 19:00:11 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Andrew Morton , Ross Zwisler Subject: [PATCH 0/2] tracing: Fix ftrace_boot_snapshot command line X-Spam-Status: No, score=-4.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762288830874931447?= X-GMAIL-MSGID: =?utf-8?q?1762288830874931447?= While debugging some boot up code, I found that the snapshots were constantly triggering at boot up, even though there was no boot snapshot specified. Looking into it, I found there were too bugs. 1) It would trigger a snapshot on any instance if one was created from the kernel command line. 2) The error handling would only affect the top level instance. So the fact that a snapshot was done on a instance that didn't allocate a buffer triggered a warning written into the top level buffer, and worse yet, disabled the top level buffer. This addresses both of the above bugs. Steven Rostedt (Google) (2): tracing: Have tracing_snapshot_instance_cond() write errors to the appropriate instance tracing: Fix ftrace_boot_snapshot command line logic ---- kernel/trace/trace.c | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-)