Message ID | 20230404145350.45388-1-sebastian.reichel@collabora.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp3090165vqo; Tue, 4 Apr 2023 07:55:44 -0700 (PDT) X-Google-Smtp-Source: AKy350a7rxdLK6wp4CNOWgx2bas1sKfFOI7DYXmKQ1PPBPjFH+vtoSz8vFgcrFOIXCXN5PZIn3ZI X-Received: by 2002:a17:906:95ca:b0:947:7b89:6779 with SMTP id n10-20020a17090695ca00b009477b896779mr2957734ejy.46.1680620144196; Tue, 04 Apr 2023 07:55:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680620144; cv=none; d=google.com; s=arc-20160816; b=dcmUqNf7xaFIyAHpU6fuloXZ0uSujC9ugc0Q88ZauBvxLxbubNLogyhRXkXM+rRu7y uvx00fJpsvtEjuPXPbMRalwingaAqXRwRYlIO72pFuQW+oip+pPbRXPazrnr/dDOxR5i JFjv0T5qcPKjP5AU27UA4mG2+RbSiSXoXLmdGOXaG8V9P4tWLZFO2/VamgQEAgQY+/CX bEyY/YRoY1ODfqj7V+TxBxEX0gd7MiG/sLeOSOQakMyFBaY+Kg8AI1o6dEHfgeK/La83 wV/XaRrd7LBaeGpTyIpPRK2etCc86Ln9gfDKPNYNqIkDc+hMmU7+ECSA8+kfhXNU096R juXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=jQRp1Wvwsh8CZsjyVn6LXHPjX1xpwpcekF64K1Fn0TA=; b=RtPuxSCXK2oB4j85HM6ParZyxgWC3cdHfKS7NPvlxPImtifYXIr3TH6lb/FNtyFTZM y7CK/2QqtuuTzt3wP5u/kl/cMA31m/HcCw9GrY3TneNDVvVzcWKokxTopvibcWTvuBVP 6D8TlsecFkv1/beuRJ8ERUgF3GBOMaRZV0XP6RvYraxKzRsayPCV7vCCP65bNswo0sLj UjgLqiPWRaH5VrukEyLRRCO8J7L37siXQwPwH/wAhExQuBcku07xk4XI+LbZVZ91E88o U1cQ/ud5ipcqyGqy6XCnMVo7XFAejXtTlBsoDSW7subtE72uItwV9ZWNPVjk4VA70WFc tMMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=Vsv11d5K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ke4-20020a17090798e400b009300c219570si1064243ejc.834.2023.04.04.07.55.19; Tue, 04 Apr 2023 07:55:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=Vsv11d5K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232695AbjDDOyB (ORCPT <rfc822;lkml4gm@gmail.com> + 99 others); Tue, 4 Apr 2023 10:54:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231849AbjDDOx5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 4 Apr 2023 10:53:57 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98E2410F9; Tue, 4 Apr 2023 07:53:55 -0700 (PDT) Received: from jupiter.universe (dyndsl-091-248-190-097.ewe-ip-backbone.de [91.248.190.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sre) by madras.collabora.co.uk (Postfix) with ESMTPSA id B1E75660316B; Tue, 4 Apr 2023 15:53:53 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1680620034; bh=Rox0MV0ygtFD00bZWntkUfuFnzpO8a/o2DyaAD/vPW8=; h=From:To:Cc:Subject:Date:From; b=Vsv11d5K+i+BVfjQQnhgzSVMwZ3mnJoWt0/Pl6cMloSAop5WnNDcTfdz5qr/qzqni ax7E+n6yWrXyrKaXOjnLQgeLXrAcg1eHOnvKRu2CppD/qAL+MZXfS+GAItgDEImuH0 b7mLf0OTVXRZzapxfShPSjMdrHEOPWXJRBwn/Uy39qqeeh8QYG4B8vtZUEJxD509UX cfxHW3sRDajr5gz+CJUs6+3+3lceVXOXOJdcbaSG+pcHOfuCZAd+dkQ7b4mHOTC4uq kXvQSP+JryV7tG5kuWOQPLfxw7HpmujJL8F1GExVWUOd/mV8N54hb72psIHJdRDt/W diCbZSvhtAq/w== Received: by jupiter.universe (Postfix, from userid 1000) id B8E334807E1; Tue, 4 Apr 2023 16:53:51 +0200 (CEST) From: Sebastian Reichel <sebastian.reichel@collabora.com> To: Alan Stern <stern@rowland.harvard.edu>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel <sebastian.reichel@collabora.com>, kernel@collabora.com Subject: [PATCHv1 0/3] generic-ohci/ehci: add RK3588 support Date: Tue, 4 Apr 2023 16:53:47 +0200 Message-Id: <20230404145350.45388-1-sebastian.reichel@collabora.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762257948351237334?= X-GMAIL-MSGID: =?utf-8?q?1762257948351237334?= |
Series |
generic-ohci/ehci: add RK3588 support
|
|
Message
Sebastian Reichel
April 4, 2023, 2:53 p.m. UTC
Hi, This increases the max. allowed clocks for generic-ohci from 3 to 4. On RK3588 a total of 4 clocks is required to access the OHCI registers. EHCI already supports 4 clocks. Changes since PATCHv1: * https://lore.kernel.org/all/20230331163148.5863-1-sebastian.reichel@collabora.com/ * Add Alan's Acked-by to the driver patch increasing the clock count * Update bindings, adding rockchip,rk3588-ohci and rockchip,rk3588-ehci compatibles -- Sebastian Sebastian Reichel (3): dt-bindings: usb: Add RK3588 OHCI dt-bindings: usb: Add RK3588 EHCI usb: host: ohci-platform: increase max clock number to 4 .../devicetree/bindings/usb/generic-ehci.yaml | 1 + .../devicetree/bindings/usb/generic-ohci.yaml | 18 ++++++++++++++++-- drivers/usb/host/ohci-platform.c | 2 +- 3 files changed, 18 insertions(+), 3 deletions(-)
Comments
On Tue, Apr 04, 2023 at 04:53:47PM +0200, Sebastian Reichel wrote: > Hi, > > This increases the max. allowed clocks for generic-ohci from 3 to 4. > On RK3588 a total of 4 clocks is required to access the OHCI registers. > EHCI already supports 4 clocks. > > Changes since PATCHv1: > * https://lore.kernel.org/all/20230331163148.5863-1-sebastian.reichel@collabora.com/ > * Add Alan's Acked-by to the driver patch increasing the clock count > * Update bindings, adding rockchip,rk3588-ohci and rockchip,rk3588-ehci compatibles This is "v1" according to the subject line, right? confused, greg k-h
Hi Greg, On Wed, Apr 05, 2023 at 04:49:37PM +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 04, 2023 at 04:53:47PM +0200, Sebastian Reichel wrote: > > Hi, > > > > This increases the max. allowed clocks for generic-ohci from 3 to 4. > > On RK3588 a total of 4 clocks is required to access the OHCI registers. > > EHCI already supports 4 clocks. > > > > Changes since PATCHv1: > > * https://lore.kernel.org/all/20230331163148.5863-1-sebastian.reichel@collabora.com/ > > * Add Alan's Acked-by to the driver patch increasing the clock count > > * Update bindings, adding rockchip,rk3588-ohci and rockchip,rk3588-ehci compatibles > > This is "v1" according to the subject line, right? Well the previous version was also about adding RK3588 support. I did not see anything RK3588 specific and thus used "increase allowed clocks" as subject for the cover letter. Rob's review effectively asked for RK3588 specific compatibles to be added, so this is a v2 of the series with that change included. Since increasing the maximum number of clocks is no longer the dominant content of the series I changed the cover letter's subject. Sorry that this confused you. Greetings, -- Sebastian