From patchwork Tue Apr 4 13:41:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 7701 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp3043492vqo; Tue, 4 Apr 2023 06:49:46 -0700 (PDT) X-Google-Smtp-Source: AKy350Zy8KlqSOHO/IrxUBXOA+wzIeWDwvqCcJKqz7dLHi/LmwoHpxjY6S0Pw/3ZtxhLqwYveB49 X-Received: by 2002:a17:90a:bc85:b0:237:752f:1af0 with SMTP id x5-20020a17090abc8500b00237752f1af0mr2985888pjr.29.1680616186349; Tue, 04 Apr 2023 06:49:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680616186; cv=none; d=google.com; s=arc-20160816; b=xWmyRCddF8ai81M/dro9bJQddPfTkfuNrgOwCf+EQ4eCyGn5fX2BqIUNjWqz4EwtH4 qRDPJrm3RuvO5f8NWli1WTXBreiNfa/6P7G/wuQWubgyBVYrwbJ8wuRZA5hRR9TSmHsJ t4sgfi36+z+kvuUxczEol/6U1Bhu3k+t/VWMSSXAQmnwb/VrHQ+2zi2XyDNBd2PTj3FO qIIfLnO1jVhsrA652eQMJntpjFpQUclzYIhTvco6WDilMWyygszcOYWFH9gN4M4sWXwt NSkWszOG/ZVAKh6vMs3JD7W8wUPn8cUrKY7gq84ZUqRMBu4DXOnBHXrctoy7/ZAJaiD8 MlUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=opZ+kQofwtmsB/bWsOjQhfutLUTBkbdCKlVQSnC2x7E=; b=Na/uxmHaiPohG08Bn6nYBqKMIz+VGzcaS4ZzgN5vGAfWIV9UnTMJR3RH87b9w6N0wT 7mwzVC37u1/mQw8y+3zyT4RRnf1AwHGt7lclJfoWetBCHWYcUbZz7judmbLgAUEIXdkV S+NraWEtYqL856qiCIj84m5jgoP/94D6vdA9kuVbkge7RqsE5bUNQcgrouIu16FFqyzM kjV8gb3Fys7vjLT3f/U6hTX5xS6IWO7QYZJECtnvmCB9mfkEijEKPhVkYQ5a0Vjups+V Skmn6TNLE1Q9Kws3Z+KIs3PJldZcK1anQCVHJjCT3YGzJjq8XgbaG7i/+NXH5fzu03Ku EM4g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k19-20020a170902761300b001a229e52c19si10199252pll.91.2023.04.04.06.49.32; Tue, 04 Apr 2023 06:49:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230364AbjDDNmZ (ORCPT + 99 others); Tue, 4 Apr 2023 09:42:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234493AbjDDNmW (ORCPT ); Tue, 4 Apr 2023 09:42:22 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3550AA; Tue, 4 Apr 2023 06:42:19 -0700 (PDT) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4PrTNn3bhJz67mZc; Tue, 4 Apr 2023 21:38:17 +0800 (CST) Received: from SecurePC-101-06.china.huawei.com (10.122.247.231) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 4 Apr 2023 14:42:15 +0100 From: Jonathan Cameron To: Mark Rutland , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Will Deacon , , , CC: , Dan Williams , Shaokun Zhang , Yicong Yang , Jiucheng Xu , Khuong Dinh , Robert Richter , Atish Patra , Anup Patel , Andy Gross , Bjorn Andersson , Frank Li , Shuai Xue , Vineet Gupta , Shawn Guo , Fenghua Yu , Dave Jiang , Wu Hao , Tom Rix , , Suzuki K Poulose , Liang Kan Subject: [PATCH 00/32] Add parents to struct pmu -> dev Date: Tue, 4 Apr 2023 14:41:53 +0100 Message-ID: <20230404134225.13408-1-Jonathan.Cameron@huawei.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 X-Originating-IP: [10.122.247.231] X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762253797723248337?= X-GMAIL-MSGID: =?utf-8?q?1762253797723248337?= These are the low hanging fruit following GregKH's feedback that all the devices registered via perf_pmu_register() should have parents. Note that this causes potential ABI breakage. It may fall in the category of it isn't breakage if no one notices but I can't be certain of that. Whilst it is arguable that no one should be been accessing PMUs except via the event_source bus, there was documentation suggesting /sys/devices/ for particular PMUs (because it was a shorter path?) The first patch is pulled out of the series: https://lore.kernel.org/linux-cxl/20230327170247.6968-1-Jonathan.Cameron@huawei.com/ [PATCH v3 0/5] CXL 3.0 Performance Monitoring Unit support In that particular case it is very useful to be able to figure out which CXL device the PMU device is associated with and looking at it's parents in the device model as shown with ls -lh /sys/bus/event_sources/devices/ is a very easy way to do this (once it is correctly parented). Addressing all the other instances of struct pmu not covered by this series is likely to be a more complex discussion but unlikely to have an affect on what is proposed here. Documentation updates deliberately 'fixed' in separate patches before changing the path to highlight that using /sys/bus/event_source/devices path is unchanged by this series and that is presumed to be the most common way these files are accessed. Jonathan Cameron (32): perf: Allow a PMU to have a parent perf/hisi-pcie: Assign parent for event_source device Documentation: hisi-pmu: Drop reference to /sys/devices path perf/hisi-uncore: Assign parents for event_source devices Documentation: hns-pmu: Use /sys/bus/event_source/devices paths perf/hisi-hns3: Assign parents for event_source device perf/amlogic: Assign parents for event_source devices perf/arm_cspmu: Assign parents for event_source devices Documentation: xgene-pmu: Use /sys/bus/event_source/devices paths perf/xgene: Assign parents for event_source devices Documentation: thunderx2-pmu: Use /sys/bus/event_source/devices paths perf/thunderx2: Assign parents for event_source devices perf/riscv: Assign parents for event_source devices Documentation: qcom-pmu: Use /sys/bus/event_source/devices paths perf/qcom: Assign parents for event_source devices perf/imx_ddr: Assign parents for event_source devices perf/arm_pmu: Assign parents for event_source devices perf/alibaba_uncore: Assign parents for event_source device perf/arm-cci: Assign parents for event_source device perf/arm-ccn: Assign parents for event_source device perf/arm-cmn: Assign parents for event_source device perf/arm-dmc620: Assign parents for event_source device perf/arm-dsu: Assign parents for event_source device perf/arm-smmuv3: Assign parents for event_source device perf/arm-spe: Assign parents for event_source device arc: Assign parents for event_source devices ARM: imx: Assign parents for mmdc event_source devices dmaengine: idxd: Assign parent for event_source device fpga: dfl: Assign parent for event_source device drivers/nvdimm: Assign parent for event_source device Documentation: ABI + trace: hisi_ptt: update paths to bus/event_source hwtracing: hisi_ptt: Assign parent for event_source device ...i_ptt => sysfs-bus-event_source-devices-hisi_ptt} | 12 ++++++------ Documentation/admin-guide/perf/hisi-pmu.rst | 1 - Documentation/admin-guide/perf/hns3-pmu.rst | 8 ++++---- Documentation/admin-guide/perf/qcom_l2_pmu.rst | 2 +- Documentation/admin-guide/perf/qcom_l3_pmu.rst | 2 +- Documentation/admin-guide/perf/thunderx2-pmu.rst | 2 +- Documentation/admin-guide/perf/xgene-pmu.rst | 2 +- Documentation/trace/hisi-ptt.rst | 4 ++-- MAINTAINERS | 2 +- arch/arc/kernel/perf_event.c | 1 + arch/arm/mach-imx/mmdc.c | 1 + drivers/dma/idxd/perfmon.c | 1 + drivers/fpga/dfl-fme-perf.c | 1 + drivers/hwtracing/ptt/hisi_ptt.c | 1 + drivers/nvdimm/nd_perf.c | 1 + drivers/perf/alibaba_uncore_drw_pmu.c | 1 + drivers/perf/amlogic/meson_ddr_pmu_core.c | 1 + drivers/perf/arm-cci.c | 1 + drivers/perf/arm-ccn.c | 1 + drivers/perf/arm-cmn.c | 1 + drivers/perf/arm_cspmu/arm_cspmu.c | 1 + drivers/perf/arm_dmc620_pmu.c | 1 + drivers/perf/arm_dsu_pmu.c | 1 + drivers/perf/arm_pmu_platform.c | 1 + drivers/perf/arm_smmuv3_pmu.c | 1 + drivers/perf/arm_spe_pmu.c | 1 + drivers/perf/fsl_imx8_ddr_perf.c | 1 + drivers/perf/hisilicon/hisi_pcie_pmu.c | 1 + drivers/perf/hisilicon/hisi_uncore_pmu.c | 1 + drivers/perf/hisilicon/hns3_pmu.c | 1 + drivers/perf/qcom_l2_pmu.c | 1 + drivers/perf/qcom_l3_pmu.c | 1 + drivers/perf/riscv_pmu_legacy.c | 1 + drivers/perf/riscv_pmu_sbi.c | 1 + drivers/perf/thunderx2_pmu.c | 1 + drivers/perf/xgene_pmu.c | 1 + include/linux/perf_event.h | 1 + kernel/events/core.c | 1 + 38 files changed, 46 insertions(+), 18 deletions(-) rename Documentation/ABI/testing/{sysfs-devices-hisi_ptt => sysfs-bus-event_source-devices-hisi_ptt} (83%) Reviewed-by: Greg Kroah-Hartman Reviewed-by: Greg Kroah-Hartman Reviewed-by: Greg Kroah-Hartman