mbox series

[RESEND,0/2] pwm: mtk-disp: Fix backlight configuration at boot

Message ID 20230403133054.319070-1-angelogioacchino.delregno@collabora.com
Headers
Series pwm: mtk-disp: Fix backlight configuration at boot |

Message

AngeloGioacchino Del Regno April 3, 2023, 1:30 p.m. UTC 
  Since the pwm-mtk-disp driver was fixed to get PWM_EN state from the
right register, an old two-wrongs-make-one-right issue emerged: as a
result, MT8192 Asurada Spherion got no backlight at boot unless a
suspend/resume cycle was performed.
Also, the backlight would sometimes not get updated with the requested
value, requiring the user to change it back and forth until it worked.

This series fixes both of the aforementioned issues found on MT8192
and similar issues on MT8183 Chromebooks.

AngeloGioacchino Del Regno (2):
  pwm: mtk-disp: Disable shadow registers before setting backlight
    values
  pwm: mtk-disp: Configure double buffering before reading in
    .get_state()

 drivers/pwm/pwm-mtk-disp.c | 34 +++++++++++++++++++++++-----------
 1 file changed, 23 insertions(+), 11 deletions(-)

Comments

Thierry Reding April 6, 2023, 2:24 p.m. UTC | #1 
On Mon, 3 Apr 2023 15:30:52 +0200, AngeloGioacchino Del Regno wrote:
> Since the pwm-mtk-disp driver was fixed to get PWM_EN state from the
> right register, an old two-wrongs-make-one-right issue emerged: as a
> result, MT8192 Asurada Spherion got no backlight at boot unless a
> suspend/resume cycle was performed.
> Also, the backlight would sometimes not get updated with the requested
> value, requiring the user to change it back and forth until it worked.
> 
> [...]

Applied, thanks!

[1/2] pwm: mtk-disp: Disable shadow registers before setting backlight values
      commit: 36dd7f530ae7d9ce9e853ffb8aa337de65c6600b
[2/2] pwm: mtk-disp: Configure double buffering before reading in .get_state()
      commit: b16c310115f2084b8826a35b77ef42bab6786d9f

Best regards,