From patchwork Mon Apr 3 11:20:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florent Revest X-Patchwork-Id: 7631 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2226008vqo; Mon, 3 Apr 2023 04:26:27 -0700 (PDT) X-Google-Smtp-Source: AKy350YK7Ec/b2J3b4bngv2yOzGl13OhnfYMHwAE6LxuOl8gQ7748JVMK3bll2+kwJGDkSFnCVku X-Received: by 2002:a17:902:d40a:b0:1a0:57dd:b340 with SMTP id b10-20020a170902d40a00b001a057ddb340mr26548898ple.64.1680521186844; Mon, 03 Apr 2023 04:26:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680521186; cv=none; d=google.com; s=arc-20160816; b=R8vErdfavhsE2hBa8CtBSMLo+FhlxVv+SqrZXulnuGpLX7h4zjte9XMUccQK0W+DMv 75qkGxXyGd8Q3LWvVYvKaKJCXX34xhcT7lGY7r3XK7Jcq7hfMv/HJb23Se/tvWrG3Kkg SYuvhZVjkp8yUzr1+7NQg3XW0rCQHNH8qxA1MnY1W/eK54HEz1FoRGpQ+Yur8/uax+q4 uToXF2ZqZXaGnbomD7q2Di99A4LP3WX8uFxW6tSIKAQWH2HPb8Th+yaBI+qzfmkGXGDH 9qWRksA2mdttX9dR/uTRMElQ145RfWj2FwWjikfQuPo2VGvgerafoyhcAb+yxYEes1Au /NVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=yfXbK+ehjb3x3tftRCKApX1xRkjQHv0ANTDTDP3NxOc=; b=T/SLENaUP1SLcjWBq/fjfhoMFYitEMcizbMcOjwNRNyeihuTJ/z4ysZjSzHa3B8AhZ Od/Y1m0zzX8AcmIsnM0HT8C0kX5/Rs3Lswd/UzDHZsh997wguZp7bBBBQw17ACCPuysx 3pJMD9S2XYPyTV1Gwzitt6BoW1aGnMLwn5Q69HJLHaXfPMcBPSGb2+VqZQPAm7C28MaW +iKS4UA3I/cpkmPPczDxJNuEtMbFpXcpDeGUTe1O2uZhAa3iFxh/RWBgTn621THLT4ky yFjl/ITZXgsWiiJ2dYLfLBnrE2GLCxlg6+jjdoi/MGD5LmtQhukFRmlCj+UYJsQ8ID7a oWPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=LP5ajRRn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o10-20020a1709026b0a00b0019ceb61f48csi7431601plk.60.2023.04.03.04.26.14; Mon, 03 Apr 2023 04:26:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=LP5ajRRn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232401AbjDCLVc (ORCPT + 99 others); Mon, 3 Apr 2023 07:21:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232278AbjDCLVa (ORCPT ); Mon, 3 Apr 2023 07:21:30 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AE3211641 for ; Mon, 3 Apr 2023 04:21:23 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id q19so25885684wrc.5 for ; Mon, 03 Apr 2023 04:21:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1680520882; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yfXbK+ehjb3x3tftRCKApX1xRkjQHv0ANTDTDP3NxOc=; b=LP5ajRRnzT235CHmQ0lWGzS01yRL1tgN2As0C6a9k+8kESyhDzgjyXI8/BDjLJaUTJ WsvByzsfaG8Sorgy//fxlbYOVC0mNesRhPJwZdh9m0lkowm6Q44RL+WC5zrfnawtMqAp spVLCXyWFMFo1ZXSL+bQvrMPVbziP+EyTRhcA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680520882; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yfXbK+ehjb3x3tftRCKApX1xRkjQHv0ANTDTDP3NxOc=; b=6LJglmMSOrmTapPc+0zZXF5a8d0dfg0QF48caXiBIT4qCKqlyQveH1S0s5mUVxkOmQ JVlkOG8ErkVHt3WoenToUTzlKezyWBvvqpNWMimSxrbFDpNYJ3ODB/cBbRHGI4uOdvg3 UcSqUdMsJBsJ9sU+AWiBrdRxhKXMHLUU0b2Ngg1ilqBD2+Yq8Sum5njZ4vW4p1/ytcZY R44CLUnvkexSL4WEaMTHKoBkmvklUguoATVPQ3sUP6M2KfR4tNVyK24pNoCS3PJBAbeA E4QOj3e2WDLFdeSy2Tszh6sCcyTrqsvAwtxeIMTFwu8e4Dsqe0GGMIVdhcBYdxN4SJKA secA== X-Gm-Message-State: AAQBX9ckNV1INsfkCoKiotwOJd6wBbs1A5l3Ex8mU/q4XZhfz5H/1SEQ o9a/nSvGsgOkjt+eZRLK4cnl9g== X-Received: by 2002:adf:e90c:0:b0:2cf:eeae:88c3 with SMTP id f12-20020adfe90c000000b002cfeeae88c3mr28245477wrm.32.1680520881678; Mon, 03 Apr 2023 04:21:21 -0700 (PDT) Received: from revest.zrh.corp.google.com ([2a00:79e0:9d:6:b5a2:4ffd:8524:ac1]) by smtp.gmail.com with ESMTPSA id u13-20020adfeb4d000000b002daeb108304sm9510031wrn.33.2023.04.03.04.21.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Apr 2023 04:21:21 -0700 (PDT) From: Florent Revest To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org Cc: catalin.marinas@arm.com, will@kernel.org, rostedt@goodmis.org, mhiramat@kernel.org, mark.rutland@arm.com, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kpsingh@kernel.org, jolsa@kernel.org, xukuohai@huaweicloud.com, lihuafei1@huawei.com, Florent Revest Subject: [PATCH v4 0/4] Add ftrace direct call for arm64 Date: Mon, 3 Apr 2023 13:20:55 +0200 Message-Id: <20230403112059.2749695-1-revest@chromium.org> X-Mailer: git-send-email 2.40.0.423.gd6c402a77b-goog MIME-Version: 1.0 X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762154184256427583?= X-GMAIL-MSGID: =?utf-8?q?1762154184256427583?= This series adds ftrace direct call support to arm64. This makes BPF tracing programs (fentry/fexit/fmod_ret/lsm) work on arm64. It is meant to be taken by the arm64 tree but it depends on the trace-direct-v6.3-rc3 tag of the linux-trace tree: git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git That tag was created by Steven Rostedt so the arm64 tree can pull the prior work this depends on. [1] Thanks to the ftrace refactoring under that tag, an ftrace_ops backing a ftrace direct call will only ever point to *one* direct call. This means we can look up the direct called trampoline address stored in the ops from the ftrace_caller trampoline in the case when the destination would be out of reach of a BL instruction at the ftrace callsite. This fixes limitations of previous attempts such as [2]. This series has been tested on arm64 with: 1- CONFIG_FTRACE_SELFTEST 2- samples/ftrace/*.ko (cf: patch 3) 3- tools/testing/selftests/bpf/test_progs (cf: patch 4) Changes since v3 [3]: - Added "BTI C" instructions at the beginning of each ftrace direct call sample - Added Mark Rutland's Acked-by to patch 2 1: https://lore.kernel.org/all/ZB2Nl7fzpHoq5V20@FVFF77S0Q05N/ 2: https://lore.kernel.org/all/20220913162732.163631-1-xukuohai@huaweicloud.com/ 3: https://lore.kernel.org/bpf/20230324171451.2752302-1-revest@chromium.org/ Florent Revest (4): arm64: ftrace: Add direct call support arm64: ftrace: Simplify get_ftrace_plt arm64: ftrace: Add direct call trampoline samples support selftests/bpf: Update the tests deny list on aarch64 arch/arm64/Kconfig | 6 ++ arch/arm64/include/asm/ftrace.h | 22 +++++ arch/arm64/kernel/asm-offsets.c | 6 ++ arch/arm64/kernel/entry-ftrace.S | 90 ++++++++++++++++---- arch/arm64/kernel/ftrace.c | 46 +++++++--- samples/ftrace/ftrace-direct-modify.c | 32 +++++++ samples/ftrace/ftrace-direct-multi-modify.c | 36 ++++++++ samples/ftrace/ftrace-direct-multi.c | 22 +++++ samples/ftrace/ftrace-direct-too.c | 25 ++++++ samples/ftrace/ftrace-direct.c | 23 +++++ tools/testing/selftests/bpf/DENYLIST.aarch64 | 82 ++---------------- 11 files changed, 288 insertions(+), 102 deletions(-)