mbox series

[0/2] perf top: Add --branch-history option

Message ID 20230330131833.12864-1-adrian.hunter@intel.com
Headers
Series perf top: Add --branch-history option |

Message

Adrian Hunter March 30, 2023, 1:18 p.m. UTC 
  Hi

Here are small patches related to option --branch-history.

Note, currently --branch-history is broken due to patch
"perf report: append inlines to non-dwarf callchains" so
that needs to be reverted / fixed beforehand.


Adrian Hunter (2):
      perf top: Add --branch-history option
      perf symbol: Remove unused branch_callstack

 tools/perf/Documentation/perf-top.txt |  4 ++++
 tools/perf/builtin-top.c              | 17 +++++++++++++++++
 tools/perf/util/symbol_conf.h         |  1 -
 3 files changed, 21 insertions(+), 1 deletion(-)


Regards
Adrian

Comments

Arnaldo Carvalho de Melo March 30, 2023, 9:14 p.m. UTC | #1 
Em Thu, Mar 30, 2023 at 04:18:31PM +0300, Adrian Hunter escreveu:
> Hi
> 
> Here are small patches related to option --branch-history.
> 
> Note, currently --branch-history is broken due to patch
> "perf report: append inlines to non-dwarf callchains" so
> that needs to be reverted / fixed beforehand.

Thanks, applied.

- Arnaldo

 
> 
> Adrian Hunter (2):
>       perf top: Add --branch-history option
>       perf symbol: Remove unused branch_callstack
> 
>  tools/perf/Documentation/perf-top.txt |  4 ++++
>  tools/perf/builtin-top.c              | 17 +++++++++++++++++
>  tools/perf/util/symbol_conf.h         |  1 -
>  3 files changed, 21 insertions(+), 1 deletion(-)
> 
> 
> Regards
> Adrian
Andi Kleen March 31, 2023, 2:17 p.m. UTC | #2 
On 3/30/2023 2:14 PM, Arnaldo Carvalho de Melo wrote:
> Em Thu, Mar 30, 2023 at 04:18:31PM +0300, Adrian Hunter escreveu:
>> Hi
>>
>> Here are small patches related to option --branch-history.
>>
>> Note, currently --branch-history is broken due to patch
>> "perf report: append inlines to non-dwarf callchains" so
>> that needs to be reverted / fixed beforehand.
> Thanks, applied.


How about the revert to fix it too?


-Andi
Arnaldo Carvalho de Melo April 3, 2023, 8:32 p.m. UTC | #3 
Em Fri, Mar 31, 2023 at 07:17:08AM -0700, Andi Kleen escreveu:
> 
> On 3/30/2023 2:14 PM, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Mar 30, 2023 at 04:18:31PM +0300, Adrian Hunter escreveu:
> > > Hi
> > > 
> > > Here are small patches related to option --branch-history.
> > > 
> > > Note, currently --branch-history is broken due to patch
> > > "perf report: append inlines to non-dwarf callchains" so
> > > that needs to be reverted / fixed beforehand.
> > Thanks, applied.
> 
> 
> How about the revert to fix it too?

Since there was no discussion on this or a proposal to a fix, I'm
reverting it now.

- Arnaldo