From patchwork Thu Mar 30 08:39:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sit, Michael Wei Hong" X-Patchwork-Id: 7446 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp976187vqo; Thu, 30 Mar 2023 01:52:07 -0700 (PDT) X-Google-Smtp-Source: AKy350bF/nRIw9lLVqCQOkpP6yqF1a5N5UY+cm1V2Pm21Iu9dgQGPncstk9lBPEvolV4VB/Su1JV X-Received: by 2002:aa7:c1d7:0:b0:4fa:ba31:6c66 with SMTP id d23-20020aa7c1d7000000b004faba316c66mr22772457edp.42.1680166326992; Thu, 30 Mar 2023 01:52:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680166326; cv=none; d=google.com; s=arc-20160816; b=rxh7N9yqDh3I0t5QDrXM0HE5XRYcGRB7QUVM2pKQZLYz5GJMKaYXHS3FZiBi2vaWvq r6VN4YAMBOvENwBgKIcoj2hY6zrplx7S8u5CHgQ/5zeOltC8V231Cy/wUNM0OxK2v6M4 nEknNRypEbeQTVhJU3BrJ4V91BRHO2Q81umqmmduVKS98tn79ST7vBGCX79pJDQ3nqbS cRRt9Rkpy+yH3vIi/8qPUQkDkKbrz20knFFdZKCfcKcb2xvJ4JTkx/SrLZKhK/OtXwmj ryU5V5rXdFiA7GbmhJV4xHMluItlX/vFJRzyU7f7pSrA0FYktwrHCAPpa/T+L9uLfvbi +3Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=TNI3ilnXmo5sivI7Jb9k5ONpAJA4023BeZALswwq1EM=; b=HBmS4/zHs5qsQuUwVqFVQ07oj8apEYBr/rH4ZGH7q1Unif/NtLqpw/Ezc9yjFASu20 MXlL9Nu5RmxoIdEDcIRhJWzO+nxogQBBOZKm2qlI5XJRXJTY8j1otPoxETt6WbiN18Uu K0uvGcVMYyoS1VsB03mA+bcwfGNFej/2wgINjUv2shKMyrkHD0CRdQO1yOpuMNLZNfCM cKKFmQGLZJZR2LbHuMLEex9lBvrUhw8QdWMQQWdHdJTdodPnKzwFEZVmSv+ZXHgIGBqO 20Kzqx9d3NhowY/GSTvhrYh126u2T7btupuakwBpU5HwsNWTyZBHnkG8o2OZruI5BzC3 IhYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JzOZt2KA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w25-20020a50fa99000000b004af50024631si38647636edr.433.2023.03.30.01.51.41; Thu, 30 Mar 2023 01:52:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JzOZt2KA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229812AbjC3Ikz (ORCPT + 99 others); Thu, 30 Mar 2023 04:40:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229680AbjC3Ikx (ORCPT ); Thu, 30 Mar 2023 04:40:53 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85FCB5B92; Thu, 30 Mar 2023 01:40:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680165652; x=1711701652; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=E/3JzKj/ftYcVD0rt0pT36PrSlnk43aIECQPEWDRFIQ=; b=JzOZt2KAvux5JvhmzLaD49g9OsmPW1NlqS614U/OhUtOKB0ucZmwGVZb DQM0qYQ261UnYGAKP6QYC+jxAmbesyRwBuLWy/f8CPV0woDtn8apC0/PP XvuLiybS6AEOqRp/uCSziOSvQGYLJrAkiXCRi9U4mnt6gvM+53ykOnwz7 Bmsj9Rl4nZdNaVEyCOvNYfiXh71eF0Y8ZGdMACBd2mAtv7jy74HjPfhxf dsGlzedwvC961EtrystnMTBFzD3333Wr9JyV+cJvb/evW30WneRY3F1Yv dkuUfqZ1AKdoQlclVoq6Uxg0QQ6RzZxCY617n55me/f5WSCrD0E9xc7TT A==; X-IronPort-AV: E=McAfee;i="6600,9927,10664"; a="343559359" X-IronPort-AV: E=Sophos;i="5.98,303,1673942400"; d="scan'208";a="343559359" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2023 01:40:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10664"; a="684618810" X-IronPort-AV: E=Sophos;i="5.98,303,1673942400"; d="scan'208";a="684618810" Received: from mike-ilbpg1.png.intel.com ([10.88.227.76]) by orsmga002.jf.intel.com with ESMTP; 30 Mar 2023 01:40:46 -0700 From: Michael Sit Wei Hong To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Ong Boon Leong , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux@armlinux.org.uk, hkallweit1@gmail.com, andrew@lunn.ch Cc: Looi Hong Aun , Voon Weifeng , Lai Peter Jun Ann Subject: [PATCH net v4 0/3] Fix PHY handle no longer parsing Date: Thu, 30 Mar 2023 16:39:57 +0800 Message-Id: <20230330084000.3292487-1-michael.wei.hong.sit@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.0 required=5.0 tests=AC_FROM_MANY_DOTS, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761782086707877486?= X-GMAIL-MSGID: =?utf-8?q?1761782086707877486?= After the fixed link support was introduced, it is observed that PHY no longer attach to the MAC properly. So we introduce a helper function to determine if the MAC should expect to connect to a PHY and proceed accordingly. Michael Sit Wei Hong (3): net: phylink: add phylink_expects_phy() method net: stmmac: check if MAC needs to attach to a PHY net: stmmac: remove redundant fixup to support fixed-link mode .../net/ethernet/stmicro/stmmac/dwmac-intel.c | 1 - .../net/ethernet/stmicro/stmmac/stmmac_main.c | 4 +++- drivers/net/phy/phylink.c | 17 +++++++++++++++++ include/linux/phylink.h | 1 + 4 files changed, 21 insertions(+), 2 deletions(-) v2: Initialize fwnode before using the variable v3: Introduced phylink_expects_phy() method as suggested by Russell King remove xpcs_an_inband fixup instead of moving the fixed-link check as suggested by Andrew Lunn v4: Modify phylink_expects_phy() to check for more complete set of conditions when no PHY is needed and return false if met.