mbox series

[0/2] rpmsg: glink: Wait for intent after intent request

Message ID 20230327144617.3134175-1-quic_bjorande@quicinc.com
Headers
Series rpmsg: glink: Wait for intent after intent request |

Message

Bjorn Andersson March 27, 2023, 2:46 p.m. UTC 
  When written it was assumed that upon requesting an intent, the intent
would arrive followed by an intent request acknowledgement. But this is
not always the case, in which case the current implementation would
request yet another intent and when that is acknowledged find the first
received intent - if the remote didn't run out of memory and failed the
second request...

Bjorn Andersson (2):
  rpmsg: glink: Transition intent request signaling to wait queue
  rpmsg: glink: Wait for intent, not just request ack

 drivers/rpmsg/qcom_glink_native.c | 37 ++++++++++++++++++++++---------
 1 file changed, 26 insertions(+), 11 deletions(-)

Comments

Chris Lew April 7, 2023, 10:35 p.m. UTC | #1 
On 3/27/2023 7:46 AM, Bjorn Andersson wrote:
> When written it was assumed that upon requesting an intent, the intent
> would arrive followed by an intent request acknowledgement. But this is
> not always the case, in which case the current implementation would
> request yet another intent and when that is acknowledged find the first
> received intent - if the remote didn't run out of memory and failed the
> second request...
> 
> Bjorn Andersson (2):
>    rpmsg: glink: Transition intent request signaling to wait queue
>    rpmsg: glink: Wait for intent, not just request ack
> 
>   drivers/rpmsg/qcom_glink_native.c | 37 ++++++++++++++++++++++---------
>   1 file changed, 26 insertions(+), 11 deletions(-)
> 

Reviewed-by: Chris Lew <quic_clew@quicinc.com>
Bjorn Andersson April 18, 2023, 4:09 p.m. UTC | #2 
On Mon, 27 Mar 2023 07:46:15 -0700, Bjorn Andersson wrote:
> When written it was assumed that upon requesting an intent, the intent
> would arrive followed by an intent request acknowledgement. But this is
> not always the case, in which case the current implementation would
> request yet another intent and when that is acknowledged find the first
> received intent - if the remote didn't run out of memory and failed the
> second request...
> 
> [...]

Applied, thanks!

[1/2] rpmsg: glink: Transition intent request signaling to wait queue
      commit: c09c7a59bfdd9a5d02a75ab640ed73ad56b3d1bc
[2/2] rpmsg: glink: Wait for intent, not just request ack
      commit: 62efe3ed777c180a924a8576ca0b5a1a55eba9ae

Best regards,