mbox series

[0/2] block: null_blk: make fault-injection configurable via configfs

Message ID 20230327143733.14599-1-akinobu.mita@gmail.com
Headers
Series block: null_blk: make fault-injection configurable via configfs |

Message

Akinobu Mita March 27, 2023, 2:37 p.m. UTC 
  This patch set makes null_blk driver-specific fault-injection dynamically
configurable per device via configfs.

Since the null_blk driver supports configuration such as device creation
via configfs, it is natural to configure fault-injection via configfs as
well.

Currently, only the debugfs interface is provided for dynamically
configuring fault-injection, so this introduces a compatible interface via
configfs.

Akinobu Mita (2):
  fault-inject: allow configuration via configfs
  block: null_blk: make fault-injection dynamically configurable per
    device

 .../fault-injection/fault-injection.rst       |   8 +
 drivers/block/null_blk/Kconfig                |   2 +-
 drivers/block/null_blk/main.c                 |  93 +++++++--
 drivers/block/null_blk/null_blk.h             |   7 +-
 include/linux/fault-inject.h                  |  22 ++
 lib/Kconfig.debug                             |  13 +-
 lib/fault-inject.c                            | 191 ++++++++++++++++++
 7 files changed, 312 insertions(+), 24 deletions(-)

Comments

Christoph Hellwig March 27, 2023, 10:13 p.m. UTC | #1 
On Mon, Mar 27, 2023 at 11:37:31PM +0900, Akinobu Mita wrote:
> This patch set makes null_blk driver-specific fault-injection dynamically
> configurable per device via configfs.
> 
> Since the null_blk driver supports configuration such as device creation
> via configfs, it is natural to configure fault-injection via configfs as
> well.
> 
> Currently, only the debugfs interface is provided for dynamically
> configuring fault-injection, so this introduces a compatible interface via
> configfs.

Oh, nice.  Can you also update blktests to take advantage of this and
not require built-in null_blk for fault injection tests?
Chaitanya Kulkarni March 27, 2023, 10:18 p.m. UTC | #2 
On 3/27/23 15:13, Christoph Hellwig wrote:
> On Mon, Mar 27, 2023 at 11:37:31PM +0900, Akinobu Mita wrote:
>> This patch set makes null_blk driver-specific fault-injection dynamically
>> configurable per device via configfs.
>>
>> Since the null_blk driver supports configuration such as device creation
>> via configfs, it is natural to configure fault-injection via configfs as
>> well.
>>
>> Currently, only the debugfs interface is provided for dynamically
>> configuring fault-injection, so this introduces a compatible interface via
>> configfs.
> Oh, nice.  Can you also update blktests to take advantage of this and
> not require built-in null_blk for fault injection tests?

+1 on blktests, please CC me when you do.

-ck
Jens Axboe April 13, 2023, 1:39 p.m. UTC | #3 
On Mon, 27 Mar 2023 23:37:31 +0900, Akinobu Mita wrote:
> This patch set makes null_blk driver-specific fault-injection dynamically
> configurable per device via configfs.
> 
> Since the null_blk driver supports configuration such as device creation
> via configfs, it is natural to configure fault-injection via configfs as
> well.
> 
> [...]

Applied, thanks!

[1/2] fault-inject: allow configuration via configfs
      commit: 4668c7a2940d134bea50058e138591b97485c5da
[2/2] block: null_blk: make fault-injection dynamically configurable per device
      commit: bb4c19e030f45c5416f1eb4daa94fbaf7165e9ea

Best regards,