From patchwork Mon Mar 27 03:13:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?TW91ZHkgSG8gKOS9leWul+WOnyk=?= X-Patchwork-Id: 7230 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1246514vqo; Sun, 26 Mar 2023 20:25:31 -0700 (PDT) X-Google-Smtp-Source: AKy350ZHjOkZfIrwsutF7FIOcocE3DssdahoegqIU4aPAOQCvu/Df7wsV0eVuYdvPz5m2RFkjSJp X-Received: by 2002:a17:907:d30e:b0:922:78e2:7680 with SMTP id vg14-20020a170907d30e00b0092278e27680mr11735078ejc.52.1679887531635; Sun, 26 Mar 2023 20:25:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679887531; cv=none; d=google.com; s=arc-20160816; b=fdKdhpjjoRlMKGI8lBxFH6kjtFhyNiLAAbQGifizh1qiMNj1z+8oLaP5m89b+CSerc YJM05w3Y8BdnY0K1/1FBgb9YUMJBBp+JJ5+T2VNJfHGQhe39owk1gVHiJM4Du4VGL6mF iuVofhDNqoHCGMxo9X7QJ24a7IA2G3C6imqf0+H0bt+0u4EsteqUHLCCxCwWau8HkEqy YihQFCqa6KZcj60QrhCj/XPmhdRiHQs+s4zqhhGpBDO3xWHM2wvi1CleecGdLxXvgpvy neXpCEkfC8ZrKPfBer3VUxHipnI87FwD5wsAKOi0lAZr7orBiQE92tJkdqUFduptaDGf 9vUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from :dkim-signature; bh=3QuPkgIznm4nWBAocITY94rL4F1zaTiEbdhOnBCyYOE=; b=qEagr+JlKPDdDHLw9RgXMRRtxkQpbbieNIzVbVCzmt/PD0Sglgr7dc27yBwQ9Xhrzt n1whKjNdS88OsMu9rmPCR0yTrnybAn7cCDLWyBFlWbZhF6c3SKunmhCgir228ERJ2+Al LBa5zYfOG43tjQsvKaA16XuUdoI84mK+yaO0VSpXq/Cwu4c+AsUZmb3xrn0YXEDKBLve +Du1Z1ZwVskxn2yf1aff7swftjBHgT675WUyM+0QLUtL1SH/vumANZee070UL3YUtiMC f1rBobmwsoFjKPFbOZYWEC9VxZBzEU5rm7VND9mWxy+bZ316BBKylZUereiQEt71JjwT Z5tA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=iSDvsJgN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lf14-20020a170906ae4e00b009315b84b4dasi26176600ejb.600.2023.03.26.20.25.08; Sun, 26 Mar 2023 20:25:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=iSDvsJgN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232043AbjC0DOz (ORCPT + 99 others); Sun, 26 Mar 2023 23:14:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232277AbjC0DOG (ORCPT ); Sun, 26 Mar 2023 23:14:06 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2661B524E; Sun, 26 Mar 2023 20:13:48 -0700 (PDT) X-UUID: 5da368bacc4d11edb6b9f13eb10bd0fe-20230327 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=3QuPkgIznm4nWBAocITY94rL4F1zaTiEbdhOnBCyYOE=; b=iSDvsJgN1mc4XM2Skr2DeqMOX2TQ9KQ+44q8x0zkwU6v/+acBt5mFGzpiLQj0EMfXUlUJMa3Ae73YYll5ieU9X/fAF3gVEa0uSijmFWiJiaciL+cwaPsBTRmenPnmCY6UKmXAirtyDGo3+AM22Hr0ZFH3EZcnXfWsrmVbYbGA8M=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.22,REQID:f9205ddb-857b-4be7-acba-e50fb2a4c324,IP:0,U RL:0,TC:0,Content:-25,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:-25 X-CID-META: VersionHash:120426c,CLOUDID:b598fef6-ddba-41c3-91d9-10eeade8eac7,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-UUID: 5da368bacc4d11edb6b9f13eb10bd0fe-20230327 Received: from mtkmbs13n2.mediatek.inc [(172.21.101.108)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1632168806; Mon, 27 Mar 2023 11:13:37 +0800 Received: from mtkmbs13n2.mediatek.inc (172.21.101.108) by mtkmbs13n2.mediatek.inc (172.21.101.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.25; Mon, 27 Mar 2023 11:13:36 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs13n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.25 via Frontend Transport; Mon, 27 Mar 2023 11:13:35 +0800 From: Moudy Ho To: Mauro Carvalho Chehab , Matthias Brugger , Hans Verkuil , Ping-Hsun Wu CC: , , , , , Moudy Ho Subject: [PATCH v7 00/12] Add support for multiple chips Date: Mon, 27 Mar 2023 11:13:23 +0800 Message-ID: <20230327031335.9663-1-moudy.ho@mediatek.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 X-MTK: N X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS, UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761489748417822164?= X-GMAIL-MSGID: =?utf-8?q?1761489748417822164?= Changes since v6: - Rebase on media_stage tree - Fix smatch error: "drivers/media/platform/mediatek/mdp3/mdp_cfg_data.c:452 mdp_cfg_get_id_public() error: 'mdp_dev' dereferencing possible ERR_PTR()" Changes since v5: - Rebase on linux-next. - Integrate the chip configuration into a source file called "mdp_cfg_data.c" instead of a header file. - Fix undefined reference to __udividi3 caused by patch [1/12]. - Fix parentheses issue reported by check script. - Fix compilation and smatch errors Changes since v4: - Rebase on linux-next. - Fix potential frame size overflow in "mtk-mdp3-regs.c". - Fix OOB in MDP3 component clocks in "mtk-mdp3-comp.*". - Reconfigure the shared memory between MDP3 kerenl and SCP. Changes since v3: - Rebase on linux-next. - In the file "mtk-mdp3-m2m.c", use the limited resolution defined by each platform to replace the default format. - Add platform ID in driver data, and refine shared memory structure preprocessing. - Simplify the way to get mutex ID in function "mdp_path_subfrm_require". Changes since v2: - Depend on : [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=687004 - Split the shared memory header(mtk-img-ipi.h) by preprocessing instead, and classify the generic parts into "mtk-mdp3-type.h", and move chip-specific parts to"mt8183/mdp3-comp-mt8183.h". Changes since v1: - Depend on : [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=687004 - For hardware-specific structures in the shared memory header(mtk-img-ipi.h), split the relevant functions and structure definitions. Hi, To support multiple chips, a chip configuration header file needs to be created and the relevant information split and moved into it. The v4l2-compliance test results list is as follows: v4l2-compliance 1.23.0-4942, 32 bits, 32-bit time_t v4l2-compliance SHA: 4cf258c24026 2022-07-28 15:43:45 Compliance test for mtk-mdp3 device /dev/video0: Driver Info: Driver name : mtk-mdp3 Card type : MediaTek MDP3 Bus info : platform:14001000.dma-controlle Driver version : 6.2.0 Capabilities : 0x84204000 Video Memory-to-Memory Multiplanar Streaming Extended Pix Format Device Capabilities Device Caps : 0x04204000 Video Memory-to-Memory Multiplanar Streaming Extended Pix Format Required ioctls: test VIDIOC_QUERYCAP: OK test invalid ioctls: OK Allow for multiple opens: test second /dev/video0 open: OK test VIDIOC_QUERYCAP: OK test VIDIOC_G/S_PRIORITY: OK test for unlimited opens: OK Debug ioctls: test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported) Input ioctls: test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported) test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported) Inputs: 0 Audio Inputs: 0 Tuners: 0 Output ioctls: test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported) Outputs: 0 Audio Outputs: 0 Modulators: 0 Input/Output configuration ioctls: test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported) Control ioctls: test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK test VIDIOC_QUERYCTRL: OK test VIDIOC_G/S_CTRL: OK test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 4 Private Controls: 0 Format ioctls: test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK test VIDIOC_TRY_FMT: OK test VIDIOC_S_FMT: OK test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK test Composing: OK test Scaling: OK Codec ioctls: test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) Buffer ioctls: test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK test Requests: OK (Not Supported) test TIME32/64: OK Test input 0: Streaming ioctls: test read/write: OK (Not Supported) test blocking wait: OK (snip) test MMAP (no poll): OK (snip) test MMAP (select): OK (snip) test MMAP (epoll): OK test USERPTR (no poll): OK (Not Supported) test USERPTR (select): OK (Not Supported) test DMABUF: Cannot test, specify --expbuf-device Stream using all formats: (snip) Total for mtk-mdp3 device /dev/video0: 1174, Succeeded: 1174, Failed: 0, Warnings: 0 Moudy Ho (12): media: platform: mtk-mdp3: fix potential frame size overflow in mdp_try_fmt_mplane() media: platform: mtk-mdp3: add files for chip configuration media: platform: mtk-mdp3: chip config split about component settings media: platform: mtk-mdp3: chip config split about subcomponents media: platform: mtk-mdp3: chip config split about color format media: platform: mtk-mdp3: chip config split about resolution limitations media: platform: mtk-mdp3: chip config split about pipe info media: platform: mtk-mdp3: extend mdp_color format for compressed mode media: platform: mtk-mdp3: dynamically allocate component clocks media: platform: mtk-mdp3: Split general definitions used in MDP3 media: platform: mtk-mdp3: decompose hardware-related information in shared memory media: platform: mtk-mdp3: reconfigure shared memory drivers/media/platform/mediatek/mdp3/Makefile | 2 +- .../platform/mediatek/mdp3/mdp_cfg_data.c | 453 +++++++++++++++ .../platform/mediatek/mdp3/mdp_sm_mt8183.h | 144 +++++ .../platform/mediatek/mdp3/mtk-img-ipi.h | 189 +----- .../platform/mediatek/mdp3/mtk-mdp3-cfg.h | 20 + .../platform/mediatek/mdp3/mtk-mdp3-cmdq.c | 148 +++-- .../platform/mediatek/mdp3/mtk-mdp3-comp.c | 539 +++++++++++------- .../platform/mediatek/mdp3/mtk-mdp3-comp.h | 24 +- .../platform/mediatek/mdp3/mtk-mdp3-core.c | 48 +- .../platform/mediatek/mdp3/mtk-mdp3-core.h | 18 +- .../platform/mediatek/mdp3/mtk-mdp3-m2m.c | 28 +- .../platform/mediatek/mdp3/mtk-mdp3-m2m.h | 1 - .../platform/mediatek/mdp3/mtk-mdp3-regs.c | 293 +--------- .../platform/mediatek/mdp3/mtk-mdp3-regs.h | 214 +++---- .../platform/mediatek/mdp3/mtk-mdp3-type.h | 53 ++ .../platform/mediatek/mdp3/mtk-mdp3-vpu.c | 193 +++---- .../platform/mediatek/mdp3/mtk-mdp3-vpu.h | 29 +- 17 files changed, 1429 insertions(+), 967 deletions(-) create mode 100644 drivers/media/platform/mediatek/mdp3/mdp_cfg_data.c create mode 100644 drivers/media/platform/mediatek/mdp3/mdp_sm_mt8183.h create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-cfg.h create mode 100644 drivers/media/platform/mediatek/mdp3/mtk-mdp3-type.h