mbox series

[v1,0/1] Implement DMIC support in WM8903

Message ID 20230325083643.7575-1-clamor95@gmail.com
Headers
Series Implement DMIC support in WM8903 |

Message

Svyatoslav Ryhel March 25, 2023, 8:36 a.m. UTC 
  According to comments in wm8903, driver lacks DMIC support.
My wm8903 based devices (ASUS TF300T and TF101) require DMIC
support for correct internal mic work. I have used downstream
sources to implement DMIC input support for this driver and
I can confirm that internal mic now works as intended.

Svyatoslav Ryhel (1):
  ASoC: wm8903: implement DMIC support

 sound/soc/codecs/wm8903.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Charles Keepax March 27, 2023, 8:33 a.m. UTC | #1 
On Sat, Mar 25, 2023 at 10:36:42AM +0200, Svyatoslav Ryhel wrote:
> According to comments in wm8903, driver lacks DMIC support.

Which comments? I am having some difficulty finding these?

Thanks,
Charles
Svyatoslav Ryhel March 27, 2023, 8:38 a.m. UTC | #2 
пн, 27 бер. 2023 р. о 11:33 Charles Keepax <ckeepax@opensource.cirrus.com> пише:
>
> On Sat, Mar 25, 2023 at 10:36:42AM +0200, Svyatoslav Ryhel wrote:
> > According to comments in wm8903, driver lacks DMIC support.
>
> Which comments? I am having some difficulty finding these?
>

Lines 10-12

* TODO:
* - TDM mode configuration.
* - Digital microphone support.

> Thanks,
> Charles
Charles Keepax March 27, 2023, 10:03 a.m. UTC | #3 
On Mon, Mar 27, 2023 at 11:38:10AM +0300, Svyatoslav Ryhel wrote:
> пн, 27 бер. 2023 р. о 11:33 Charles Keepax <ckeepax@opensource.cirrus.com> пише:
> >
> > On Sat, Mar 25, 2023 at 10:36:42AM +0200, Svyatoslav Ryhel wrote:
> > > According to comments in wm8903, driver lacks DMIC support.
> >
> > Which comments? I am having some difficulty finding these?
> >
> 
> Lines 10-12
> 
> * TODO:
> * - TDM mode configuration.
> * - Digital microphone support.
> 

Oops... thanks, I think that comment should have been removed
in this patch:

commit 97945c46a23d ("ASoC: WM8903: Implement DMIC support")

Thanks,
Charles