Message ID | 20230324021420.73401-1-cai.huoqing@linux.dev |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp96668wrt; Thu, 23 Mar 2023 19:26:35 -0700 (PDT) X-Google-Smtp-Source: AKy350ZCjeTcqRy9ubW1vjSKjnu+aPbTzcQeMch15bp08duJqnYEt4m7AeaWQMiRdSI0HkSDeVwC X-Received: by 2002:a17:906:94c2:b0:932:d2bb:4fd with SMTP id d2-20020a17090694c200b00932d2bb04fdmr1088981ejy.58.1679624795558; Thu, 23 Mar 2023 19:26:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679624795; cv=none; d=google.com; s=arc-20160816; b=MoSfJPA/GD5xcxh18v3SYBn3w+BrSzozF8boU2dl3T9qPIyaiuPWSwE0zDRd+eRmRm +Z9Rv65GFf0tYp7pt+/7sbvsWU1/eL85V+PZ7t18Pynuts1PJ6oq3KOdtv285VlRPVle lLkXP52s2LZFpyb/+DSJWb6dYLgPfOL5Vbg7v792h8/3aJBcaQZP+Uqo4BFpRKAaUlfA C1XWprPMNPPKbi8DcjxHWLJmnLuDrTYNyOHyyHaoUDjv5G36VtWwDZ3ADbWAjS7JWn5u jBMbN//hKmqGM0OZ4+p014RhH1+rrVuBtDqTM1UMLlp4WP1BcA1Y2h49iU20HpbmMPKS VZcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=cnkaeNTG6HWrKe4B22XDrTgrH+xGhdfzP0gfBo97fsM=; b=DnGpgj6iBcBh/ubNNnM6qOLGF7YdUrBo83PCdy2fjKQmLSeyx2Sy8XoqeWnR5DikcO ahCtOJFO0iMs4lY9+Lw/ts58h1mfXsYw/Vu0F/KNys9KdfwCGRiX7DTT88cL5pDvCuSJ KJA+inSmXb7sqcNDUFavGr1cp14FNka35I9Hjp/36laEyxditKajtNtzySNiSRzrdJet 7XB1ezkh1Wf2B7rY62V6YuiUnM99Mq4zfVaBK2AYdJkb8aVb9ERTWH3t0oSSZXHz5RNu gM/VQYQ8aLCXxz4Wjcvl/kTlCwOeJP+E7HNxecsK22+v1n2zK26wFnV76gn5Bk1PmjRm Hbcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=BsKkqckL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kz9-20020a17090777c900b008c35025ce33si18904708ejc.838.2023.03.23.19.26.12; Thu, 23 Mar 2023 19:26:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=BsKkqckL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231267AbjCXCPO (ORCPT <rfc822;ezelljr.billy@gmail.com> + 99 others); Thu, 23 Mar 2023 22:15:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231143AbjCXCPK (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 23 Mar 2023 22:15:10 -0400 Received: from out-40.mta0.migadu.com (out-40.mta0.migadu.com [IPv6:2001:41d0:1004:224b::28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D4D02B2BE for <linux-kernel@vger.kernel.org>; Thu, 23 Mar 2023 19:14:44 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1679624071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=cnkaeNTG6HWrKe4B22XDrTgrH+xGhdfzP0gfBo97fsM=; b=BsKkqckLblVInK3bx8vmVGrTpUNBI/tzKGZtNsGC4d3FwlwY40O+zdan9yLkqI6gdhpp8E fhFtDCj1YAliUOudrRvyNAjYHFN3Mdw/oHJZ/bOreKpNyWaZvYGurvXIWy4WUJKiVO+zWm q/uMm+uBIiXab/x3JIyE1d3Fu7bfMaA= From: Cai Huoqing <cai.huoqing@linux.dev> To: fancer.lancer@gmail.com Cc: Cai Huoqing <cai.huoqing@linux.dev>, Gustavo Pimentel <gustavo.pimentel@synopsys.com>, Vinod Koul <vkoul@kernel.org>, Jingoo Han <jingoohan1@gmail.com>, Lorenzo Pieralisi <lpieralisi@kernel.org>, =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= <kw@linux.com>, Rob Herring <robh@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, linux-pci@vger.kernel.org Subject: [PATCH v9 0/4] dmaengine: dw-edma: Add support for native HDMA Date: Fri, 24 Mar 2023 10:14:14 +0800 Message-Id: <20230324021420.73401-1-cai.huoqing@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761213722668727261?= X-GMAIL-MSGID: =?utf-8?q?1761214249496377983?= |
Series |
dmaengine: dw-edma: Add support for native HDMA
|
|
Message
Cai Huoqing
March 24, 2023, 2:14 a.m. UTC
Add support for HDMA NATIVE, as long the IP design has set
the compatible register map parameter-HDMA_NATIVE,
which allows compatibility for native HDMA register configuration.
The HDMA Hyper-DMA IP is an enhancement of the eDMA embedded-DMA IP.
And the native HDMA registers are different from eDMA,
so this patch add support for HDMA NATIVE mode.
HDMA write and read channels operate independently to maximize
the performance of the HDMA read and write data transfer over
the link When you configure the HDMA with multiple read channels,
then it uses a round robin (RR) arbitration scheme to select
the next read channel to be serviced.The same applies when
youhave multiple write channels.
The native HDMA driver also supports a maximum of 16 independent
channels (8 write + 8 read), which can run simultaneously.
Both SAR (Source Address Register) and DAR (Destination Address Register)
are aligned to byte.
Cai Huoqing (1):
dmaengine: dw-edma: Add support for native HDMA
Cai huoqing (3):
dmaengine: dw-edma: Rename dw_edma_core_ops structure to
dw_edma_plat_ops
dmaengine: dw-edma: Create a new dw_edma_core_ops structure to
abstract controller operation
dmaengine: dw-edma: Add HDMA DebugFS support
Tested-by: Serge Semin <fancer.lancer@gmail.com>
v8->v9:
[3/4]
1.Drop an empty line.
[4/4]
2.Update commit log.
3.Remove unused macro
v8 link:
https://lore.kernel.org/lkml/20230323034944.78357-1-cai.huoqing@linux.dev/
drivers/dma/dw-edma/Makefile | 8 +-
drivers/dma/dw-edma/dw-edma-core.c | 86 ++----
drivers/dma/dw-edma/dw-edma-core.h | 58 ++++
drivers/dma/dw-edma/dw-edma-pcie.c | 4 +-
drivers/dma/dw-edma/dw-edma-v0-core.c | 85 +++++-
drivers/dma/dw-edma/dw-edma-v0-core.h | 14 +-
drivers/dma/dw-edma/dw-hdma-v0-core.c | 296 +++++++++++++++++++
drivers/dma/dw-edma/dw-hdma-v0-core.h | 17 ++
drivers/dma/dw-edma/dw-hdma-v0-debugfs.c | 170 +++++++++++
drivers/dma/dw-edma/dw-hdma-v0-debugfs.h | 22 ++
drivers/dma/dw-edma/dw-hdma-v0-regs.h | 129 ++++++++
drivers/pci/controller/dwc/pcie-designware.c | 2 +-
include/linux/dma/edma.h | 7 +-
13 files changed, 807 insertions(+), 91 deletions(-)
create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-core.c
create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-core.h
create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-debugfs.c
create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-debugfs.h
create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-regs.h
Comments
Hi Vinod On Fri, Mar 24, 2023 at 10:14:14AM +0800, Cai Huoqing wrote: > Add support for HDMA NATIVE, as long the IP design has set > the compatible register map parameter-HDMA_NATIVE, > which allows compatibility for native HDMA register configuration. > > The HDMA Hyper-DMA IP is an enhancement of the eDMA embedded-DMA IP. > And the native HDMA registers are different from eDMA, > so this patch add support for HDMA NATIVE mode. > > HDMA write and read channels operate independently to maximize > the performance of the HDMA read and write data transfer over > the link When you configure the HDMA with multiple read channels, > then it uses a round robin (RR) arbitration scheme to select > the next read channel to be serviced.The same applies when > youhave multiple write channels. > > The native HDMA driver also supports a maximum of 16 independent > channels (8 write + 8 read), which can run simultaneously. > Both SAR (Source Address Register) and DAR (Destination Address Register) > are aligned to byte. > > Cai Huoqing (1): > dmaengine: dw-edma: Add support for native HDMA > > Cai huoqing (3): > dmaengine: dw-edma: Rename dw_edma_core_ops structure to > dw_edma_plat_ops > dmaengine: dw-edma: Create a new dw_edma_core_ops structure to > abstract controller operation > dmaengine: dw-edma: Add HDMA DebugFS support > > Tested-by: Serge Semin <fancer.lancer@gmail.com> I finished the patchset review and testing. Could you have a look at the series. If you are ok with what it does please merge in. -Serge(y) > > v8->v9: > [3/4] > 1.Drop an empty line. > [4/4] > 2.Update commit log. > 3.Remove unused macro > > v8 link: > https://lore.kernel.org/lkml/20230323034944.78357-1-cai.huoqing@linux.dev/ > > drivers/dma/dw-edma/Makefile | 8 +- > drivers/dma/dw-edma/dw-edma-core.c | 86 ++---- > drivers/dma/dw-edma/dw-edma-core.h | 58 ++++ > drivers/dma/dw-edma/dw-edma-pcie.c | 4 +- > drivers/dma/dw-edma/dw-edma-v0-core.c | 85 +++++- > drivers/dma/dw-edma/dw-edma-v0-core.h | 14 +- > drivers/dma/dw-edma/dw-hdma-v0-core.c | 296 +++++++++++++++++++ > drivers/dma/dw-edma/dw-hdma-v0-core.h | 17 ++ > drivers/dma/dw-edma/dw-hdma-v0-debugfs.c | 170 +++++++++++ > drivers/dma/dw-edma/dw-hdma-v0-debugfs.h | 22 ++ > drivers/dma/dw-edma/dw-hdma-v0-regs.h | 129 ++++++++ > drivers/pci/controller/dwc/pcie-designware.c | 2 +- > include/linux/dma/edma.h | 7 +- > 13 files changed, 807 insertions(+), 91 deletions(-) > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-core.c > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-core.h > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-debugfs.c > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-debugfs.h > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-regs.h > > -- > 2.34.1 >
On Fri, Mar 24, 2023 at 10:44:58AM +0300, Serge Semin wrote: > Hi Vinod > > On Fri, Mar 24, 2023 at 10:14:14AM +0800, Cai Huoqing wrote: > > Add support for HDMA NATIVE, as long the IP design has set > > the compatible register map parameter-HDMA_NATIVE, > > which allows compatibility for native HDMA register configuration. > > > > The HDMA Hyper-DMA IP is an enhancement of the eDMA embedded-DMA IP. > > And the native HDMA registers are different from eDMA, > > so this patch add support for HDMA NATIVE mode. > > > > HDMA write and read channels operate independently to maximize > > the performance of the HDMA read and write data transfer over > > the link When you configure the HDMA with multiple read channels, > > then it uses a round robin (RR) arbitration scheme to select > > the next read channel to be serviced.The same applies when > > youhave multiple write channels. > > > > The native HDMA driver also supports a maximum of 16 independent > > channels (8 write + 8 read), which can run simultaneously. > > Both SAR (Source Address Register) and DAR (Destination Address Register) > > are aligned to byte. > > > > Cai Huoqing (1): > > dmaengine: dw-edma: Add support for native HDMA > > > > Cai huoqing (3): > > dmaengine: dw-edma: Rename dw_edma_core_ops structure to > > dw_edma_plat_ops > > dmaengine: dw-edma: Create a new dw_edma_core_ops structure to > > abstract controller operation > > dmaengine: dw-edma: Add HDMA DebugFS support > > > > Tested-by: Serge Semin <fancer.lancer@gmail.com> > > I finished the patchset review and testing. Could you have a look at > the series. If you are ok with what it does please merge in. @Vinod, merge window will supposedly be in the next week. Could you give your resolution about this series? -Serge(y) > > -Serge(y) > > > > > v8->v9: > > [3/4] > > 1.Drop an empty line. > > [4/4] > > 2.Update commit log. > > 3.Remove unused macro > > > > v8 link: > > https://lore.kernel.org/lkml/20230323034944.78357-1-cai.huoqing@linux.dev/ > > > > drivers/dma/dw-edma/Makefile | 8 +- > > drivers/dma/dw-edma/dw-edma-core.c | 86 ++---- > > drivers/dma/dw-edma/dw-edma-core.h | 58 ++++ > > drivers/dma/dw-edma/dw-edma-pcie.c | 4 +- > > drivers/dma/dw-edma/dw-edma-v0-core.c | 85 +++++- > > drivers/dma/dw-edma/dw-edma-v0-core.h | 14 +- > > drivers/dma/dw-edma/dw-hdma-v0-core.c | 296 +++++++++++++++++++ > > drivers/dma/dw-edma/dw-hdma-v0-core.h | 17 ++ > > drivers/dma/dw-edma/dw-hdma-v0-debugfs.c | 170 +++++++++++ > > drivers/dma/dw-edma/dw-hdma-v0-debugfs.h | 22 ++ > > drivers/dma/dw-edma/dw-hdma-v0-regs.h | 129 ++++++++ > > drivers/pci/controller/dwc/pcie-designware.c | 2 +- > > include/linux/dma/edma.h | 7 +- > > 13 files changed, 807 insertions(+), 91 deletions(-) > > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-core.c > > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-core.h > > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-debugfs.c > > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-debugfs.h > > create mode 100644 drivers/dma/dw-edma/dw-hdma-v0-regs.h > > > > -- > > 2.34.1 > >
On 24-03-23, 10:14, Cai Huoqing wrote: > Add support for HDMA NATIVE, as long the IP design has set > the compatible register map parameter-HDMA_NATIVE, > which allows compatibility for native HDMA register configuration. > > The HDMA Hyper-DMA IP is an enhancement of the eDMA embedded-DMA IP. > And the native HDMA registers are different from eDMA, > so this patch add support for HDMA NATIVE mode. > > HDMA write and read channels operate independently to maximize > the performance of the HDMA read and write data transfer over > the link When you configure the HDMA with multiple read channels, > then it uses a round robin (RR) arbitration scheme to select > the next read channel to be serviced.The same applies when > youhave multiple write channels. > > The native HDMA driver also supports a maximum of 16 independent > channels (8 write + 8 read), which can run simultaneously. > Both SAR (Source Address Register) and DAR (Destination Address Register) > are aligned to byte. It fails to apply, pls rebase and resend