[v1,00/14] extcon: Core cleanups and documentation fixes

  A few fixes to the documentation and some cleanups against extcon core
module.

Andy Shevchenko (14):
  extcon: Fix kernel doc of property fields to avoid warnings
  extcon: Fix kernel doc of property capability fields to avoid warnings
  extcon: Use DECLARE_BITMAP() to declare bit arrays
  extcon: use sysfs_emit() to instead of sprintf()
  extcon: Amend kernel documentation of struct extcon_dev
  extcon: Allow name to be assigned outside of the framework
  extcon: Use unique number for the extcon device ID
  extcon: Switch to use kasprintf_strarray()
  extcon: Use device_match_of_node() helper
  extcon: use dev_of_node(dev) instead of dev->of_node
  extcon: Remove dup device name in the message and unneeded error check
  extcon: Use sizeof(*pointer) instead of sizeof(type)
  extcon: Drop unneeded assignments
  extcon: Use positive conditional in ternary operator

 drivers/extcon/extcon.c | 126 +++++++++++++++++++++-------------------
 drivers/extcon/extcon.h |   9 ++-
 2 files changed, 71 insertions(+), 64 deletions(-)
  

On Wed, Mar 22, 2023 at 04:39:51PM +0200, Andy Shevchenko wrote:
> A few fixes to the documentation and some cleanups against extcon core
> module.

Anything I should do with the series?
Any comments on it?
  

Hi Andy Shevchenko
> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Thursday, March 30, 2023 7:12 PM
> To: Bumwoo Lee <bw365.lee@samsung.com>; linux-kernel@vger.kernel.org
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>; Chanwoo Choi
> <cw00.choi@samsung.com>
> Subject: Re: [PATCH v1 00/14] extcon: Core cleanups and documentation
> fixes
> 
> On Wed, Mar 22, 2023 at 04:39:51PM +0200, Andy Shevchenko wrote:
> > A few fixes to the documentation and some cleanups against extcon core
> > module.
> 
> Anything I should do with the series?
> Any comments on it?
> 
> --
> With Best Regards,
> Andy Shevchenko
> 

Looks fine to me.

Acked-by: Bumwoo Lee <bw365.lee@samsung.com>

MR. Chanwoo, Would you please take a look at this patch series.
  

Hi,

I recommend that use the "./scripts/get_maintainer.pl" script
to get the accurate maintainer list to send the patches.


On 23. 3. 22. 23:39, Andy Shevchenko wrote:
> A few fixes to the documentation and some cleanups against extcon core
> module.
> 
> Andy Shevchenko (14):
>   extcon: Fix kernel doc of property fields to avoid warnings
>   extcon: Fix kernel doc of property capability fields to avoid warnings
>   extcon: Use DECLARE_BITMAP() to declare bit arrays
>   extcon: use sysfs_emit() to instead of sprintf()
>   extcon: Amend kernel documentation of struct extcon_dev
>   extcon: Allow name to be assigned outside of the framework
>   extcon: Use unique number for the extcon device ID
>   extcon: Switch to use kasprintf_strarray()
>   extcon: Use device_match_of_node() helper
>   extcon: use dev_of_node(dev) instead of dev->of_node
>   extcon: Remove dup device name in the message and unneeded error check
>   extcon: Use sizeof(*pointer) instead of sizeof(type)
>   extcon: Drop unneeded assignments
>   extcon: Use positive conditional in ternary operator
> 
>  drivers/extcon/extcon.c | 126 +++++++++++++++++++++-------------------
>  drivers/extcon/extcon.h |   9 ++-
>  2 files changed, 71 insertions(+), 64 deletions(-)
>
  

On Mon, Apr 03, 2023 at 10:58:20PM +0900, Chanwoo Choi wrote:
> Hi,
> 
> I recommend that use the "./scripts/get_maintainer.pl" script
> to get the accurate maintainer list to send the patches.

That's what I'm using. What's wrong in your opinion with the Cc and/or To
lists?

> On 23. 3. 22. 23:39, Andy Shevchenko wrote:
> > A few fixes to the documentation and some cleanups against extcon core
> > module.
> > 
> > Andy Shevchenko (14):
> >   extcon: Fix kernel doc of property fields to avoid warnings
> >   extcon: Fix kernel doc of property capability fields to avoid warnings
> >   extcon: Use DECLARE_BITMAP() to declare bit arrays
> >   extcon: use sysfs_emit() to instead of sprintf()
> >   extcon: Amend kernel documentation of struct extcon_dev
> >   extcon: Allow name to be assigned outside of the framework
> >   extcon: Use unique number for the extcon device ID
> >   extcon: Switch to use kasprintf_strarray()
> >   extcon: Use device_match_of_node() helper
> >   extcon: use dev_of_node(dev) instead of dev->of_node
> >   extcon: Remove dup device name in the message and unneeded error check
> >   extcon: Use sizeof(*pointer) instead of sizeof(type)
> >   extcon: Drop unneeded assignments
> >   extcon: Use positive conditional in ternary operator
  

Hi,

On 23. 3. 31. 09:48, Bumwoo Lee wrote:
> Hi Andy Shevchenko
>> -----Original Message-----
>> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> Sent: Thursday, March 30, 2023 7:12 PM
>> To: Bumwoo Lee <bw365.lee@samsung.com>; linux-kernel@vger.kernel.org
>> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>; Chanwoo Choi
>> <cw00.choi@samsung.com>
>> Subject: Re: [PATCH v1 00/14] extcon: Core cleanups and documentation
>> fixes
>>
>> On Wed, Mar 22, 2023 at 04:39:51PM +0200, Andy Shevchenko wrote:
>>> A few fixes to the documentation and some cleanups against extcon core
>>> module.
>>
>> Anything I should do with the series?
>> Any comments on it?
>>
>> --
>> With Best Regards,
>> Andy Shevchenko
>>
> 
> Looks fine to me.
> 
> Acked-by: Bumwoo Lee <bw365.lee@samsung.com>
> 
> MR. Chanwoo, Would you please take a look at this patch series.
> 

Actually, Acked tag will be replied by Maintainer or the driver owner.
If you want to review the mailing list patch, I think that Reviewed-by tag is proper.

Unfortunately, I could not see the any review comment from you even if this patchset
have the some review contents. Also you didn't review the any patches of extcon before.

I'm always welcome for many reviewers in order to improve the linux kernel.
But, in this case, I'm not sure that you are reviewing this patchset.

So that I'm sorry that I cannot take your acked-tag.
  

Hi

> -----Original Message-----
> From: Chanwoo Choi <cwchoi00@gmail.com>
> Sent: Thursday, April 6, 2023 8:17 AM
> To: Bumwoo Lee <bw365.lee@samsung.com>; 'Andy Shevchenko'
> <andriy.shevchenko@linux.intel.com>; linux-kernel@vger.kernel.org
> Cc: 'MyungJoo Ham' <myungjoo.ham@samsung.com>; 'Chanwoo Choi'
> <cw00.choi@samsung.com>
> Subject: Re: [PATCH v1 00/14] extcon: Core cleanups and documentation
> fixes
> 
> Hi,
> 
> On 23. 3. 31. 09:48, Bumwoo Lee wrote:
> > Hi Andy Shevchenko
> >> -----Original Message-----
> >> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >> Sent: Thursday, March 30, 2023 7:12 PM
> >> To: Bumwoo Lee <bw365.lee@samsung.com>; linux-kernel@vger.kernel.org
> >> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>; Chanwoo Choi
> >> <cw00.choi@samsung.com>
> >> Subject: Re: [PATCH v1 00/14] extcon: Core cleanups and documentation
> >> fixes
> >>
> >> On Wed, Mar 22, 2023 at 04:39:51PM +0200, Andy Shevchenko wrote:
> >>> A few fixes to the documentation and some cleanups against extcon
> >>> core module.
> >>
> >> Anything I should do with the series?
> >> Any comments on it?
> >>
> >> --
> >> With Best Regards,
> >> Andy Shevchenko
> >>
> >
> > Looks fine to me.
> >
> > Acked-by: Bumwoo Lee <bw365.lee@samsung.com>
> >
> > MR. Chanwoo, Would you please take a look at this patch series.
> >
> 
> Actually, Acked tag will be replied by Maintainer or the driver owner.
> If you want to review the mailing list patch, I think that Reviewed-by tag
> is proper.
> 

OK.
Thank you for your detail guidance. I will follow this guidance on next time.

> Unfortunately, I could not see the any review comment from you even if
> this patchset have the some review contents. Also you didn't review the
> any patches of extcon before.
> 
> I'm always welcome for many reviewers in order to improve the linux kernel.
> But, in this case, I'm not sure that you are reviewing this patchset.
> 
> So that I'm sorry that I cannot take your acked-tag.
> 

I agree your comment.
Thank you~

> --
> Best Regards,
> Samsung Electronics
> Chanwoo Choi
  

On Thu, Apr 06, 2023 at 08:17:19AM +0900, Chanwoo Choi wrote:
> On 23. 3. 31. 09:48, Bumwoo Lee wrote:

...

> > Looks fine to me.
> > 
> > Acked-by: Bumwoo Lee <bw365.lee@samsung.com>
> > 
> > MR. Chanwoo, Would you please take a look at this patch series.
> 
> Actually, Acked tag will be replied by Maintainer or the driver owner.  If
> you want to review the mailing list patch, I think that Reviewed-by tag is
> proper.
> 
> Unfortunately, I could not see the any review comment from you even if this
> patchset have the some review contents. Also you didn't review the any
> patches of extcon before.
> 
> I'm always welcome for many reviewers in order to improve the linux kernel.
> But, in this case, I'm not sure that you are reviewing this patchset.
> 
> So that I'm sorry that I cannot take your acked-tag. 

I probably need to update this in the v3 of the rest of the patches I have sent
as v2. Btw, can you review those before, so if any comments I can address in
v3?