From patchwork Wed Mar 22 14:12:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 7039 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2375092wrt; Wed, 22 Mar 2023 07:35:17 -0700 (PDT) X-Google-Smtp-Source: AK7set8T/t/Pqtk5/jVBp+pTdmMohmO6nKY2zedQyWDgr3L6yrLPzV3zTNFMoFCiheow3nyhKPGb X-Received: by 2002:a17:902:e5cd:b0:19f:8bbf:9c56 with SMTP id u13-20020a170902e5cd00b0019f8bbf9c56mr3522774plf.3.1679495717537; Wed, 22 Mar 2023 07:35:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679495717; cv=none; d=google.com; s=arc-20160816; b=BNZXt4zr702KkzgIfySUV74YWxwhA/FGj2CrwNB3tD/yN4drIQ2XeeiQkuIO14Saay gKiMzo1s3enaHRxFY/8rsbt41g4OmdjcILzan1FYF3uOaNzdM0g3odVv5NhhveHkj4+D KHObcGSLiJAHD5f2+tcO42kr+PzQBC7IIqg1AmQ+Ov/Gx2Bfvxhb1MGP5bdOsj4u6Yu/ 8vmfEMNd3jxy7W40Pj5orFWK0Om8vAoJ+twD7/9TWkclPG6VGHMJbqFMMEWHbtkC4RKt b+kiChBnh995muKwMGKO6HsjplKQ13F+CNgtAAalI9ZgUzf8cCD2mgHtaWMEMRKOkum1 3BTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=laZUPrnq0eeRxCNdMeZ8wRouf7gFuXINnBMR0Hcz1RA=; b=EcsGh3Wux0KfsPWmncTHaCWWVvNu9b8dEC+YOrisPnOZ8y5FA3fXiePunalOHPo73f JUOxRctIHTZUE0l97mbTy2pmuNlxkXjGX78k82gnup4g/kdObWhCMQME09ahKBWsDO0x SQ3TBZIzWR7o086OP9xsN+sQnS99oFROuJGQ1KRUiFOL/FdAVqXHH88InG9R16zkrgYk 5HqIBo1VZv2qmzVPvO9nLHgxRLvvDrGH5Ht74Km+/DfjlDYZLKy3N9xLQKcy82oG7FGu T5n4p8MHYgRq5o/1ioGODD73M888uDvifACRO8On0ezcFFdiiANkPAOVihlbd88Byoqd rjuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=POU+yTTl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i10-20020a170902eb4a00b001968cbc67e2si15900270pli.583.2023.03.22.07.35.03; Wed, 22 Mar 2023 07:35:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=POU+yTTl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231309AbjCVOLi (ORCPT + 99 others); Wed, 22 Mar 2023 10:11:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230525AbjCVOLg (ORCPT ); Wed, 22 Mar 2023 10:11:36 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C30B60408; Wed, 22 Mar 2023 07:11:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679494296; x=1711030296; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=R/NM27p9IJi6tkU9vm19fosAfBY50JC5QYvv4nC1jcA=; b=POU+yTTlBSqr7o9NjYicgBJYMt3C/okMo5kemBzAdf8lfYRbm/tQstxU lSot/OI/5KRrXhayFZlROBR7aL7Idjwr1cGPQ6E1/Cmg4n+XUHqDfPMEM 6Ehl42TRviadSW/vha2vVjlVGxIeejvtfe2YkMiA8ACz0bArNwqp9l2BJ KM4ETa715kIEnEmMzZt+67HLT9rdpwhMTiofsb2Udj1ZrJCK5LcoB8jmm G6G+a8AvrKZJZoPwmiI7xTu+JE5d2aU5GSimQBHj3Q18bDgl3/2zdea37 RrjMGtgnUWwVol6Uo3tNPHGXmTCvV3N/M4zaZ9MVOImtw2wWlH7X8t4eI g==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="336725182" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="336725182" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 07:11:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="792574215" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="792574215" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga002.fm.intel.com with ESMTP; 22 Mar 2023 07:11:33 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 6D4D51CC; Wed, 22 Mar 2023 16:12:19 +0200 (EET) From: Andy Shevchenko To: Kees Cook , Greg Kroah-Hartman , Andy Shevchenko , Cezary Rojewski , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Theodore Ts'o" , Jan Kara , Andy Shevchenko , "Rafael J. Wysocki" Subject: [PATCH v1 0/3] lib/string_helpers et al.: Change return value of strreplace() Date: Wed, 22 Mar 2023 16:12:03 +0200 Message-Id: <20230322141206.56347-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761078901602604307?= X-GMAIL-MSGID: =?utf-8?q?1761078901602604307?= It's more convenient to have strreplace() to return the original pointer. This will help users to make their code better. The patch 1 kills the only user of the returned value of strreplace(), Patch 2 converts the return value of strreplace(). And patch 3 shows how it may be useful.That said, the series can be routed via fs tree, with or without the last patch. Andy Shevchenko (3): jbd2: Avoid printing out the boundary lib/string_helpers: Change returned value of the strreplace() kobject: Use return value of strreplace() fs/jbd2/journal.c | 5 ++--- include/linux/string.h | 2 +- lib/kobject.c | 3 +-- lib/string_helpers.c | 10 +++++++--- 4 files changed, 11 insertions(+), 9 deletions(-)