From patchwork Tue Mar 21 16:12:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 6950 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp1654561wrt; Tue, 21 Mar 2023 01:25:24 -0700 (PDT) X-Google-Smtp-Source: AK7set/u3fctDS67QW/F3sShBXybav4VFtvy6DoVM9VzEiFsvdvJ74HJIcFLULD9DAeVTWvNH7w3 X-Received: by 2002:a17:90b:1647:b0:23d:1b50:1ebe with SMTP id il7-20020a17090b164700b0023d1b501ebemr1733960pjb.27.1679387124135; Tue, 21 Mar 2023 01:25:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679387124; cv=none; d=google.com; s=arc-20160816; b=IknYy/r5E25gx3COtO9pLgiIc3CL4JqytGZavs7c0VmKsn10A1tXigeYZM49mQ0Aff 82BriFdiZNmOqDdV8VnaGZOnKtw3gL1tN4uoIdkjo/SYRgzHuEB3vBTe9zkt40Rm9b7B 0wymv30dpxhcNGFLWC0dKTc2arOMGAxMXppSa5nqGTcz+OpalY+Lcsl9w1kku2CtvoZl SkpfgNLxxUPt4aM31ZJEJc6hm07PpBP198ZcXssN4kc50l13XyVrnTzt8drdY5dMEOBt zjc6QhXXkEbQKhKm4iRNDfbGZMu20T5aNJymGLYVFH0EjqzB72fjASCiqNoKMcCMiNo0 S94g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=wjPza422snkf5Sr1koUWPmHCQO6NTMh7F3tG9+AspSI=; b=QLyU7PfqwTm939H1mAp3HTgrd+vXwV8sGFtfwpUYJDFLkq0a5U82AyWtFCxeLd4exj moRsTAvovSw1QjbYo4lUTAOmRh5fZCmecl8EqQ1lx8SHrgrlVnoPg7eVHketHUMEvbsM FMKJp5S7NvAUqYr/t6pAU5X8L+Hf5L4wYrcyWPQ1PQ69lQzrX3Wqiz1F4Eq9cF2Yh40M YiZyRwLbFMrH0FjzbWj5TdT1wWQvf8jReTAI16swJIy0PCxOWttL5G/WGNdF64FmNIcN d4c7Ju36mqmFj8Mv7tusSMVLf3Sxqo/Qjl+R/VZqG+6yuip05E8DOpelS4fHyzGmfMxu CkZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e13-20020a170902cf4d00b0019e29ce6975si11645402plg.202.2023.03.21.01.25.10; Tue, 21 Mar 2023 01:25:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230468AbjCUIJj (ORCPT + 99 others); Tue, 21 Mar 2023 04:09:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230189AbjCUIJb (ORCPT ); Tue, 21 Mar 2023 04:09:31 -0400 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEB5330E89; Tue, 21 Mar 2023 01:09:27 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4Pgklk6nx4z4f3p7j; Tue, 21 Mar 2023 16:09:22 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgDnnbEzZhlk+NQhFw--.4478S2; Tue, 21 Mar 2023 16:09:24 +0800 (CST) From: Kemeng Shi To: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ojaswin@linux.ibm.com, shikemeng@huaweicloud.com Subject: [PATCH 0/8] Some fixes and cleanup to mballoc Date: Wed, 22 Mar 2023 00:12:12 +0800 Message-Id: <20230321161220.418652-1-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 X-CM-TRANSID: gCh0CgDnnbEzZhlk+NQhFw--.4478S2 X-Coremail-Antispam: 1UD129KBjvdXoW7Jry7Cw17WFW5ZryfCr1fXrb_yoWkuwc_ua 4jyrykKFWxJ3Wfua9YgFySvFy8Kr4xtr1jqFyqqrs3Zr17X3ZrAa1kArW3urn3Wr45Aa43 JrnrXr18JFn7XjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbxxFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M28lY4IEw2IIxx k0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK 6xIIjxv20xvEc7CjxVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7 xvwVC2z280aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40E FcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr 0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8v x2IErcIFxwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F4 0E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1l IxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxV AFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6rW3Jr0E3s1lIxAIcVC2z280aVAFwI0_ Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjTRCA pnUUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760965033112016329?= X-GMAIL-MSGID: =?utf-8?q?1760965033112016329?= We use cluster unit and block unit for different structure members. For example, in struct ext4_prealloc_space, pa_lstart and pa_pstart are in block unit while pa_len and pa_free are in cluster unit; in struct ext4_free_extent, fe_logical is in block unit while fe_start and fe_len are in cluster unit. The first five patches fix wrong unit use in mballoc. The rest is random bugfix and cleanup to mballoc, More details can be found in respective patches. Besides, "kvm-xfstest smoke" passes all test. Thanks! Kemeng Shi (8): ext4: fix wrong unit use in ext4_mb_normalize_request ext4: fix unit mismatch in ext4_mb_new_blocks_simple ext4: fix wrong unit use in ext4_mb_new_inode_pa ext4: fix wrong unit use in ext4_mb_find_by_goal ext4: treat stripe in block unit ext4: add EXT4_MB_HINT_GOAL_ONLY test in ext4_mb_use_preallocated ext4: remove ext4_block_group and ext4_block_group_offset declaration ext4: try all groups in ext4_mb_new_blocks_simple fs/ext4/ext4.h | 4 --- fs/ext4/mballoc.c | 75 +++++++++++++++++++++++++++++++++++------------ fs/ext4/super.c | 13 ++++++++ 3 files changed, 70 insertions(+), 22 deletions(-)