From patchwork Tue Mar 21 07:42:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leonardo Bras Soares Passos X-Patchwork-Id: 6949 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp1644250wrt; Tue, 21 Mar 2023 00:57:31 -0700 (PDT) X-Google-Smtp-Source: AK7set9yfP+QLkSewyJ4zbeRc5gwJBID+eWcyxsS2kAeJZbPn6b+sZqkeWV8m6VUDNwQnr0KjxGX X-Received: by 2002:a05:6a20:b1aa:b0:da:39a5:6e66 with SMTP id ee42-20020a056a20b1aa00b000da39a56e66mr1228453pzb.18.1679385451343; Tue, 21 Mar 2023 00:57:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679385451; cv=none; d=google.com; s=arc-20160816; b=ARh6noqkXTXILJdUQCgBfT8N8KL3za9k2OgtFL1JHQWPTFImJurHImOc25OCP076qe HZCp2cDAEQPdxvoTKPATS8xObA36xSG/Ol57GbMwTlYoFCcF1SKtD6Vx7OFD6SXHd6Qy xjG7M9QAW1vaMGLGzFWUY8A2Pj/P8shlec0HdEqfldY+d3a9i87ocMeYAyVUQXMhwl/v 2rfhtSNnfodhEyPH9G/aO6hV7V09jMo3Gj8Bv13h2yw2WXfNEr8BfjVtJ/Xxv6RUB3lz yZVnXtTkw60+eYL6TdP/k2GaVD+I3ob3jpsuXvUujgY8VdLLeJcA4y/hj9aqzv8OuDqu rVZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ESJ/1knv++fPH2odQdRy7nTNYhZrFIAGHXT1ZfrTzlo=; b=QhNdGss6NA6lSSsikmXOK+Z6hC0A6qLPlZEW32L5hk7CnjyqCoue42vSubGO1IWwgP 95jP7pZucj01IMpbaNjm9nI3b34areihELY2qlgyXIZO0nhEgb2pa+eus7bLX6mo2gbt cywBfgo1chSaJyW+yaXnT21pmjU0iudGdN8odL663c1vZXx76ypKu+eOdCAJmScBg7jO JP7EFmh/F2FsJCmzXL+aFfJ0ULD9xzW2GqqWz4PcroKdD5gc3BC+qLtN4ssz05yCwWgl ZtvarXuN14z9Fp2Ew6M9Fmzsd2uKHDcvHvelTwbn15uzO2mTJpPOCfb9Opp1++NvRm3y MtVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gkfwV7KV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x71-20020a62864a000000b006233c7e8887si12663877pfd.90.2023.03.21.00.57.17; Tue, 21 Mar 2023 00:57:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gkfwV7KV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229739AbjCUHns (ORCPT + 99 others); Tue, 21 Mar 2023 03:43:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229550AbjCUHnr (ORCPT ); Tue, 21 Mar 2023 03:43:47 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50A101AD for ; Tue, 21 Mar 2023 00:43:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679384584; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ESJ/1knv++fPH2odQdRy7nTNYhZrFIAGHXT1ZfrTzlo=; b=gkfwV7KV0c8hW95vzSGtj1sQ/DVJHlv7DX+3yNT7zSsaZrJEG4gaDSVBvKjWjsBQcm9KO/ tfCJ1A5Y3IFhrrWrgtkrxjGqCDHITaEhbe80wk1wBxwBkrvrduJ0NZBCPBW3g+NhveMpUr U/WDAFzOVFrlKzq3OilVycfbFOrWkaE= Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-122-HbYgTY3aPMSZbSmRDEYyCw-1; Tue, 21 Mar 2023 03:43:02 -0400 X-MC-Unique: HbYgTY3aPMSZbSmRDEYyCw-1 Received: by mail-ot1-f72.google.com with SMTP id c17-20020a056830315100b00698878489e5so6694562ots.12 for ; Tue, 21 Mar 2023 00:43:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679384582; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ESJ/1knv++fPH2odQdRy7nTNYhZrFIAGHXT1ZfrTzlo=; b=vJVWsW9bYI4LroRzSXziLWmae+DXwOEicl/7OYSQrosAzb1Y1509ckZe+qIf6amZo+ 5l4xuYgW1NgujNH6T7nQuob5eVlN/azJ35LEhT56f6HadN/mbLbbNWLtkvuXb6jZKcSh Zevx7I7tj2UMXVz91lwlKGAD4C+h9FXDZFWVSDWTaY7q1BVXA9PphXiy7lMjTGBIZTNT HydvANJ/TDPXIkHYg60QPHsI4ZrQD7rcEtnFD0Vlvo/M1NbuyaAOHmkfwhp+8GC8LU8E rpZ37gwGbfV904rFyhooMiIMmIR+epGNBdzTHL27AjfbQmS0gtMA3f/cE7IvISu45cA6 acww== X-Gm-Message-State: AO0yUKVkgccGGqey2+FLDEDOUgDo+ueeh2RYrOJuznh6ZzApBkL6hbHJ H+sKRbVoNDkCXdMu9mKYLyxtA70np91Zr2ovaLgTOSJHjXCvjxxsfyiRHtzuZquwPRQMBD3oMYU S7Fgy7h+oz5V+FAtAx72evTVr X-Received: by 2002:a05:6870:4248:b0:17a:a3f9:9f5d with SMTP id v8-20020a056870424800b0017aa3f99f5dmr604194oac.29.1679384582157; Tue, 21 Mar 2023 00:43:02 -0700 (PDT) X-Received: by 2002:a05:6870:4248:b0:17a:a3f9:9f5d with SMTP id v8-20020a056870424800b0017aa3f99f5dmr604184oac.29.1679384581888; Tue, 21 Mar 2023 00:43:01 -0700 (PDT) Received: from localhost.localdomain ([179.111.176.145]) by smtp.gmail.com with ESMTPSA id az15-20020a05687c230f00b0016a37572d17sm4047729oac.2.2023.03.21.00.42.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 00:43:01 -0700 (PDT) From: Leonardo Bras To: Paul Walmsley , Palmer Dabbelt , Albert Ou , Leonardo Bras , Guo Ren Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RESEND RFC PATCH v2 0/6] Deduplicating RISCV cmpxchg.h macros Date: Tue, 21 Mar 2023 04:42:43 -0300 Message-Id: <20230321074249.2221674-1-leobras@redhat.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760958782918332017?= X-GMAIL-MSGID: =?utf-8?q?1760963279161252973?= Re-sending, since previous send did not work on patchwork. While studying riscv's cmpxchg.h file, I got really interested in understanding how RISCV asm implemented the different versions of {cmp,}xchg. When I understood the pattern, it made sense for me to remove the duplications and create macros to make it easier to understand what exactly changes between the versions: Instruction sufixes & barriers. I split those changes in 3 levels for each cmpxchg and xchg, resulting a total of 6 patches. I did this so it becomes easier to review and remove the last levels if desired, but I have no issue squashing them if it's better. Please provide comments. Thanks! Leo Changes since v1: - Fixed patch 4/6 suffix from 'w.aqrl' to '.w.aqrl', to avoid build error Leonardo Bras (6): riscv/cmpxchg: Deduplicate cmpxchg() asm functions riscv/cmpxchg: Deduplicate cmpxchg() macros riscv/cmpxchg: Deduplicate arch_cmpxchg() macros riscv/cmpxchg: Deduplicate xchg() asm functions riscv/cmpxchg: Deduplicate xchg() macros riscv/cmpxchg: Deduplicate arch_xchg() macros arch/riscv/include/asm/cmpxchg.h | 316 +++++++------------------------ 1 file changed, 64 insertions(+), 252 deletions(-)