From patchwork Tue Mar 21 06:34:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leonardo Bras Soares Passos X-Patchwork-Id: 6947 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp1620341wrt; Mon, 20 Mar 2023 23:46:03 -0700 (PDT) X-Google-Smtp-Source: AK7set+pUtENJrHixJzLFRfu+X2R/8vK806Cq9LWuHjDXnT5doJbyV5g2w9daxuHE0uxM4ePUlUz X-Received: by 2002:a17:902:c745:b0:1a0:67fb:444b with SMTP id q5-20020a170902c74500b001a067fb444bmr11023308plq.2.1679381163324; Mon, 20 Mar 2023 23:46:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679381163; cv=none; d=google.com; s=arc-20160816; b=JCYHq+r68CeDDDUR18XRDArpV+roO1XE2AIRMnRLDFkE1H3+hJJsAM9pFs2M7hQ1TQ gRRd1bT9c1fuL7PkLAk7cWQdfgJi9BMjhQJz+oqk4TG0AiJVTDHVHh+kOoxe16EyxN9M uzADZfeYl3KAvP6yUHNEJzVBg80hUUUQrTuR15SKRH+C3yBbKC9EYfyqCgl2sHxzTL28 R6HS7p/WRxinU9OKWtKiGlL8aQ4Ce+v2u21Iy0PtA7ij5PiRX0vftYbWD2ITWh5k7JZh RxeI17wN5F7R1vzEyM+32z3a9Ubs9RRcpikaECOpquoUST4H37P3mNmdnFZJuQ42xZqQ 3XFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=QE3XU3Zue9M7HDU7dSkC4z4rXd/9VbR7G9gpQxcbxKY=; b=U4zbx3WMF0aQgjVLaDZsiUVdPalMuA1+wU825KLyGoCtk38EUt7uCPWsdm2UlrAIAa pxlW7qBmci849yWhfBe+AwVXBxC1sjiSY8bYj9wHr+zqL0FYUz5Qd0a2xHwFBW6AT5Kp J1ezzRCzFh2w/uIxqc3Dc7Gt7RNAptBP88a0FdClP4h83HUpt5vUT12FafeZO7V26Npa dhJ/QY6o0rWLS7LFyjYnuqt8a79fk3VGPLnhp2x8xq2uJeb2p01Upw/Tk2GAQ/1Vb1jx 6i1qglrj4t37KyFApuM+3Vp8djFUPeELND/3s3k5Pl3/pUoBmYjA2qBAzIfBSDYg/heJ YGTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="jCiPA/hm"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x10-20020a170902ec8a00b001893c960ac9si13025714plg.533.2023.03.20.23.45.50; Mon, 20 Mar 2023 23:46:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="jCiPA/hm"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230239AbjCUGfx (ORCPT + 99 others); Tue, 21 Mar 2023 02:35:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230195AbjCUGfv (ORCPT ); Tue, 21 Mar 2023 02:35:51 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BEA3118 for ; Mon, 20 Mar 2023 23:34:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679380496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=QE3XU3Zue9M7HDU7dSkC4z4rXd/9VbR7G9gpQxcbxKY=; b=jCiPA/hm5vzKJ69rmIsOy0pDW0cADhSKKzgrJX3dWFmUq7ClV/zgZjHNRR4PtuLdoRv+ah ibNliyPzEBCmkhY+LGkJs3GBlRZMcbHhPwLiQRYYrN8NXme9xSZgLB1RDDvqj4UfFSgHm7 6SaFnRzajJM77+ZMcJMH3P7F2/RJipc= Received: from mail-oa1-f69.google.com (mail-oa1-f69.google.com [209.85.160.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-660-cCHRiT0kMW-KOMbOqbxbCQ-1; Tue, 21 Mar 2023 02:34:54 -0400 X-MC-Unique: cCHRiT0kMW-KOMbOqbxbCQ-1 Received: by mail-oa1-f69.google.com with SMTP id 586e51a60fabf-172cafd4245so8286194fac.21 for ; Mon, 20 Mar 2023 23:34:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679380494; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QE3XU3Zue9M7HDU7dSkC4z4rXd/9VbR7G9gpQxcbxKY=; b=oSKfMLqnU0EEFCTz0f9bsC3dg0uOq/QGvAYkVb+rIMBMo5CnXE8x2ErFM8ki+JZwKD NAAQd+3pjITOgi2ghu8yjyxLdC8Bemk76SusXgY1Tin1G/zBXzmymTVVGJvp5MH1Uv/R YrxaGeQfljp2zbgBN06R+ISjpuOpkWjkWka2MgcNdCLAc8HKJV6s9xswPTcGdzw4x47o BlWjRx7iqU8bQiu8aWummB6rB8TvPxwrn0V1bsdOKdBxjf8xBKJ/vprpF8ezh9DgmVjd SUGF85OCKwgud45RGCAkYPb2hM/ss7MiSok2L/rqI8N0l6ja914mNFpOjYVCnicqON1h hsEQ== X-Gm-Message-State: AO0yUKUrj3EdkybfVWmPtt6p/6Tet1RzjJKWNdmOXzWtwB0xl6eaOuLH PIc5VEPFx+eRGgDvQNztYlACMsflCoHYa1Vvs3m6cPkChOYSV1RIWuSDpcSx1BvejwjHIFXimXG +dLSOtzHiQZffGi+77vhuOGic X-Received: by 2002:a9d:3e10:0:b0:69f:1577:d8e9 with SMTP id a16-20020a9d3e10000000b0069f1577d8e9mr450789otd.8.1679380493869; Mon, 20 Mar 2023 23:34:53 -0700 (PDT) X-Received: by 2002:a9d:3e10:0:b0:69f:1577:d8e9 with SMTP id a16-20020a9d3e10000000b0069f1577d8e9mr450782otd.8.1679380493648; Mon, 20 Mar 2023 23:34:53 -0700 (PDT) Received: from localhost.localdomain ([2804:1b3:a801:b074:274d:d04e:badc:c89f]) by smtp.gmail.com with ESMTPSA id y75-20020a4a454e000000b005293e9a12f5sm4545147ooa.45.2023.03.20.23.34.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 23:34:53 -0700 (PDT) From: Leonardo Bras To: Paul Walmsley , Palmer Dabbelt , Albert Ou , Leonardo Bras , Guo Ren Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v2 0/6] Deduplicating RISCV cmpxchg.h macros Date: Tue, 21 Mar 2023 03:34:25 -0300 Message-Id: <20230321063430.2218795-1-leobras@redhat.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760958782918332017?= X-GMAIL-MSGID: =?utf-8?q?1760958782918332017?= While studying riscv's cmpxchg.h file, I got really interested in understanding how RISCV asm implemented the different versions of {cmp,}xchg. When I understood the pattern, it made sense for me to remove the duplications and create macros to make it easier to understand what exactly changes between the versions: Instruction sufixes & barriers. I split those changes in 3 levels for each cmpxchg and xchg, resulting a total of 6 patches. I did this so it becomes easier to review and remove the last levels if desired, but I have no issue squashing them if it's better. Please provide comments. Thanks! Leo Changes since v1: - Fixed patch 4/6 suffix from 'w.aqrl' to '.w.aqrl', to avoid build error Leonardo Bras (6): riscv/cmpxchg: Deduplicate cmpxchg() asm functions riscv/cmpxchg: Deduplicate cmpxchg() macros riscv/cmpxchg: Deduplicate arch_cmpxchg() macros riscv/cmpxchg: Deduplicate xchg() asm functions riscv/cmpxchg: Deduplicate xchg() macros riscv/cmpxchg: Deduplicate arch_xchg() macros arch/riscv/include/asm/cmpxchg.h | 316 +++++++------------------------ 1 file changed, 64 insertions(+), 252 deletions(-)