mbox series

[0/3] arm64: dts: qcom: sc8280xp-pmics: fix sdam 'reg' property

Message ID 20230320135710.1989-1-johan+linaro@kernel.org
Headers
Series arm64: dts: qcom: sc8280xp-pmics: fix sdam 'reg' property |

Message

Johan Hovold March 20, 2023, 1:57 p.m. UTC 
  This series addresses the dt-schema validation warnings that were
introduced when enabling the PMIC SDAM block (and RTC) on sc8280xp.

I guess this should go through the nvmem, qcom, and mfd trees,
respectively.

Johan


Johan Hovold (3):
  dt-bindings: nvmem: qcom,spmi-sdam: fix example 'reg' property
  arm64: dts: qcom: sc8280xp-pmics: fix sdam 'reg' property
  dt-bindings: mfd: qcom,spmi-pmic: add nvram function

 .../bindings/mfd/qcom,spmi-pmic.yaml          |  4 +++
 .../bindings/nvmem/qcom,spmi-sdam.yaml        | 31 +++++++++++--------
 arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi  |  2 +-
 3 files changed, 23 insertions(+), 14 deletions(-)

Comments

Konrad Dybcio March 20, 2023, 2:05 p.m. UTC | #1 
On 20.03.2023 14:57, Johan Hovold wrote:
> The SPMI PMIC register region width is fixed and should not be encoded
> in the devicetree.
> 
> Fixes: 42f45cc655d0 ("arm64: dts: qcom: sc8280xp-pmics: add pmk8280 sdam nvram")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
> index 1411edd42b25..c35e7f6bd657 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
> @@ -107,7 +107,7 @@ pmk8280_rtc: rtc@6100 {
>  
>  		pmk8280_sdam_6: nvram@8500 {
>  			compatible = "qcom,spmi-sdam";
> -			reg = <0x8500 0x100>;
> +			reg = <0x8500>;
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  			ranges = <0 0x8500 0x100>;
Bjorn Andersson March 24, 2023, 6:34 p.m. UTC | #2 
On Mon, 20 Mar 2023 14:57:07 +0100, Johan Hovold wrote:
> This series addresses the dt-schema validation warnings that were
> introduced when enabling the PMIC SDAM block (and RTC) on sc8280xp.
> 
> I guess this should go through the nvmem, qcom, and mfd trees,
> respectively.
> 
> Johan
> 
> [...]

Applied, thanks!

[2/3] arm64: dts: qcom: sc8280xp-pmics: fix sdam 'reg' property
      commit: 1681ce3735483ab6897e403a20a7faf5c34c1f09

Best regards,