Message ID | 20230317233338.424864-1-andi.shyti@kernel.org |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp43245wrt; Fri, 17 Mar 2023 16:44:43 -0700 (PDT) X-Google-Smtp-Source: AK7set/vLwNhf9f/+kGtrQIeY57n3hwlGIJZWkl8JQl4tSA59IY9rjv2OFdwWHDW5cNcGIkTgNoI X-Received: by 2002:a17:902:868b:b0:199:3f82:ef62 with SMTP id g11-20020a170902868b00b001993f82ef62mr9171353plo.5.1679096683162; Fri, 17 Mar 2023 16:44:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679096683; cv=none; d=google.com; s=arc-20160816; b=NmoM0ALSFJaPYbIOqJcUKMc9+skOuy1TqqhqzkWQKEL8ambSxnH7Ff3tDrkR+DCgWt U/ciIsN5OIkca9NDbpHijf/8KVn5mrh6YddSz506j8F4tR+dX+ULY6HWAdkR8hceLP+7 Q+JeUMjP7ij28oPDJGcn1TyTQd0V2aowEKGXMZi+8+N8DXxdjGZcpxPuiD5Q2FehSf81 Pz7XluPNyNdGm5IuFz1biHfX7kmrI6oGYdoU9mX1WUMXaNik85w/b1EPQLbshqafYHul /omj6lhhvGMlp/1s4Z+uN+mKhhxqpZEKtSWiygtdStby69m7IYgnOMOA1KB1Jw4XMqQG 1zFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=yABfEg0txrL3cHCBvyGAySZNPkiAffzyhPfmRjdpnfY=; b=FepWad8GO+seQcowvje/X9rm4y19AwXfelc8QXYn7iTzQrcfOhvat/bJ51Df5m5YXR SkLQKeXpbfCZVz79MmjoIyzYv+UiifoyxGbdcMu/W7SZYxoWlvPwVrSwtWjPrvAVrcxp aAbw7GsgsW3JVI5uLIzUjaNbFavWWiKQv+cgD0TOoMPYwsuIHS9AgKCO7JOxdgw2leNF ut+FWIUakDhFelgyzI8EQRbdIRzOWN3YyZIneqRuxVxkCFMbNIYDdoz/fzfMQagixZrS 3DxZNr1HkhKSf+qrPCORMm/vNdiK5nkojnxNg13S17nQ4+pHp/EisyPFaEu2MckYUHxy /s9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="X/lv161a"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w11-20020a17090abc0b00b00233c73769dfsi8727885pjr.120.2023.03.17.16.44.30; Fri, 17 Mar 2023 16:44:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="X/lv161a"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230116AbjCQXeA (ORCPT <rfc822;chrisfriedt@gmail.com> + 99 others); Fri, 17 Mar 2023 19:34:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229866AbjCQXd6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 17 Mar 2023 19:33:58 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36FDE2BEF1; Fri, 17 Mar 2023 16:33:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 93E14B8271A; Fri, 17 Mar 2023 23:33:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D65FFC433EF; Fri, 17 Mar 2023 23:33:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679096033; bh=9prhwRKhzG2EriELrZKrFDwG1YyNTCyqWnQwXfavk0U=; h=From:To:Cc:Subject:Date:From; b=X/lv161amq/lnmmvbUSTTL6jY5rEQoF1flM1svRuRvYRctUrDUCYI0g6lOaM8c3jz /FEbH2bDlORF2PVFD/FR3CBYugEx0bW5dV34NXVBz0VXf05w0JvE3sTZAE19p7tJ8D ytBmlvDz/tWYzrrun7PREYDO/9x+oc5xlky5qhBsGbMHjIoSCm9TiAUs2RC6yWOLAO 3e7xV1jN4992gC/V4W89zdSPZe4Jk9U7TWJcKH30vWGLKhqXAe/vXcIiMe99c9lrk0 wQABPmdq+oFT/HEg9F94l65mvNrN8sKzzqc+otuMO+EITFQUb1ozudlMuE61M03L9V rJqUippVZynuQ== From: Andi Shyti <andi.shyti@kernel.org> To: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Wolfram Sang <wsa@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Chris Packham <chris.packham@alliedtelesis.co.nz>, Ryan Chen <ryan_chen@aspeedtech.com>, Andi Shyti <andi.shyti@kernel.org> Subject: [PATCH v5 0/3] Add the clock stretching i2c property Date: Sat, 18 Mar 2023 00:33:35 +0100 Message-Id: <20230317233338.424864-1-andi.shyti@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760660483749331230?= X-GMAIL-MSGID: =?utf-8?q?1760660483749331230?= |
Series |
Add the clock stretching i2c property
|
|
Message
Andi Shyti
March 17, 2023, 11:33 p.m. UTC
Hello, fter a discussion between Krzysztof and Ryan[1], it has become apparent that the i2c binding is lacking the definition of a property that needs to be added at a more generic level. This property is also used by the mpc i2c controller, which has been updated in the second patch. The DTS schema has been applied in commit c83dd2cb836e ("schemas: i2c: Add the clock stretching property"). Thanks Krzysztof, Chris and Rob for the reviews. Thank you, Andi [1] https://lore.kernel.org/all/c41ee6b5-ddb4-1253-de54-a295b3bab2cc@linaro.org/ Changelog ========= v4 -> v5: - Add the clock stretching i2c property - Added r-b from Rob Herring in Patch 1 and from Krzysztof in Patch 3. v3 -> v4: - Replaced "i2c-scl-clk-low-timeout-ms" with "i2c-scl-clk-low-timeout-us". Use microseconds instead of milliseconds. - Add tags from Chris. v2 -> v3: - Chris recommended to use of_property_read_u32() instead of of_get_property(). Because there were two use of it I added the suggested cleanup in a separate patch. v1 -> v2: - Removed the binding patch and send through a different channel - To ensure back compatibility, which was broken in v1, the legacy "fsl,timeout" has not been removed and marked as deprecated. In the driver the that property is checked anyway as a fallback in case the main i2c-scl-clk-low-timeout-ms is missing. Andi Shyti (3): dt-bindings: i2c: mpc: Mark "fsl,timeout" as deprecated i2c: mpc: Use of_property_read_u32 instead of of_get_property i2c: mpc: Use i2c-scl-clk-low-timeout-us i2c property .../devicetree/bindings/i2c/i2c-mpc.yaml | 3 +- drivers/i2c/busses/i2c-mpc.c | 35 ++++++++++++------- 2 files changed, 25 insertions(+), 13 deletions(-)
Comments
> The DTS schema has been applied in commit c83dd2cb836e ("schemas: > i2c: Add the clock stretching property"). Everyone, A general remark: If bindings for the dtschema are added, please include the linux-i2c mailing list. This binding is OK, but it would be good to have the discussion also here for additional input.
Hi Wolfram, On Wed, Mar 29, 2023 at 09:06:43PM +0200, Wolfram Sang wrote: > > > The DTS schema has been applied in commit c83dd2cb836e ("schemas: > > i2c: Add the clock stretching property"). > > Everyone, A general remark: If bindings for the dtschema are added, > please include the linux-i2c mailing list. This binding is OK, but it > would be good to have the discussion also here for additional input. Thanks for letting me know. It's actually my mistake, as I didn't check how to properly distribute the patch to all relevant parties. Regarding dtschema patches, they are typically submitted as GitHub pull requests. How should I send it to the linux-i2c? Should I also send it to the mailing list like any other patch? (This might make the code review process somewhat confusing, though). Thanks, Andi