mbox series

[0/2] KVM: x86: Fix kvm/queue breakage on clang

Message ID 20230315191128.1407655-1-seanjc@google.com
Headers
Series KVM: x86: Fix kvm/queue breakage on clang |

Message

Sean Christopherson March 15, 2023, 7:11 p.m. UTC 
  Fix clang build errors for patches sitting kvm/queue.  Ideally, these
fixes will be squashed before the buggy commits make their way to kvm/next.
If you do fixup kvm/queue, the VMX commit also has a bad SOB chain; Jim
either needs to be listed as the author or his SOB needs to be deleted.

Sean Christopherson (2):
  KVM: VMX: Drop unprotected-by-braces variable declaration in
    case-statement
  KVM: SVM: Drop unprotected-by-braces variable declaration in
    case-statement

 arch/x86/kvm/svm/svm.c | 5 ++---
 arch/x86/kvm/vmx/vmx.c | 4 +---
 2 files changed, 3 insertions(+), 6 deletions(-)


base-commit: 95b9779c1758f03cf494e8550d6249a40089ed1c

Comments

Emanuele Giuseppe Esposito March 16, 2023, 12:07 p.m. UTC | #1 
Am 15/03/2023 um 20:11 schrieb Sean Christopherson:
> Fix clang build errors for patches sitting kvm/queue.  Ideally, these
> fixes will be squashed before the buggy commits make their way to kvm/next.
> If you do fixup kvm/queue, the VMX commit also has a bad SOB chain; Jim
> either needs to be listed as the author or his SOB needs to be deleted.
> 
> Sean Christopherson (2):
>   KVM: VMX: Drop unprotected-by-braces variable declaration in
>     case-statement
>   KVM: SVM: Drop unprotected-by-braces variable declaration in
>     case-statement
> 
>  arch/x86/kvm/svm/svm.c | 5 ++---
>  arch/x86/kvm/vmx/vmx.c | 4 +---
>  2 files changed, 3 insertions(+), 6 deletions(-)
> 
> 
> base-commit: 95b9779c1758f03cf494e8550d6249a40089ed1c

Note to self: compile patches also with clang, since gcc didn't complain
about missing brackets in a switch case.

Reviewed-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Paolo Bonzini March 16, 2023, 2:26 p.m. UTC | #2 
On 3/15/23 20:11, Sean Christopherson wrote:
> Fix clang build errors for patches sitting kvm/queue.  Ideally, these
> fixes will be squashed before the buggy commits make their way to kvm/next.
> If you do fixup kvm/queue, the VMX commit also has a bad SOB chain; Jim
> either needs to be listed as the author or his SOB needs to be deleted.

I added it as Co-developed-by and squashed the patches.

Paolo