mbox series

[net-next,v4,0/4] net: dsa: mv88e6xxx: accelerate C45 scan

Message ID 20230315163846.3114-1-klaus.kudielka@gmail.com
Headers
Series net: dsa: mv88e6xxx: accelerate C45 scan |

Message

Klaus Kudielka March 15, 2023, 4:38 p.m. UTC 
  Starting with commit 1a136ca2e089 ("net: mdio: scan bus based on bus
capabilities for C22 and C45"), mdiobus_scan_bus_c45() is being called on
buses with MDIOBUS_NO_CAP. On a Turris Omnia (Armada 385, 88E6176 switch),
this causes a significant increase of boot time, from 1.6 seconds, to 6.3
seconds. The boot time stated here is until start of /init.

Further testing revealed that the C45 scan is indeed expensive (around
2.7 seconds, due to a huge number of bus transactions), and called twice.

Two things were suggested:
(1) to move the expensive call of mv88e6xxx_mdios_register() from
    mv88e6xxx_probe() to mv88e6xxx_setup().
(2) to mask apparently non-existing phys during probing.

Before that:
Patch #1 prepares the driver to handle the movement of
mv88e6xxx_mdios_register() to mv88e6xxx_setup() for cross-chip DSA trees.
Patch #2 is preparatory code movement, without functional change.

With those changes, boot time on the Turris Omnia is back to normal.

Link: https://lore.kernel.org/lkml/449bde236c08d5ab5e54abd73b645d8b29955894.camel@gmail.com/

v2:
Add cover letter
Extend the cleanup in mv88e6xxx_setup() to remove the mdio bus on failure 
Add patch "mask apparently non-existing phys during probing"

v3:
Add patch "don't dispose of Global2 IRQ mappings from mdiobus code"

v4:
Resubmit, this time hopefully with all subject prefixes correct
 
Klaus Kudielka (3):
  net: dsa: mv88e6xxx: re-order functions
  net: dsa: mv88e6xxx: move call to mv88e6xxx_mdios_register()
  net: dsa: mv88e6xxx: mask apparently non-existing phys during probing

Vladimir Oltean (1):
  net: dsa: mv88e6xxx: don't dispose of Global2 IRQ mappings from
    mdiobus code

 drivers/net/dsa/mv88e6xxx/chip.c    | 381 ++++++++++++++--------------
 drivers/net/dsa/mv88e6xxx/global2.c |  20 +-
 2 files changed, 196 insertions(+), 205 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org March 18, 2023, 5:40 a.m. UTC | #1 
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 15 Mar 2023 17:38:42 +0100 you wrote:
> Starting with commit 1a136ca2e089 ("net: mdio: scan bus based on bus
> capabilities for C22 and C45"), mdiobus_scan_bus_c45() is being called on
> buses with MDIOBUS_NO_CAP. On a Turris Omnia (Armada 385, 88E6176 switch),
> this causes a significant increase of boot time, from 1.6 seconds, to 6.3
> seconds. The boot time stated here is until start of /init.
> 
> Further testing revealed that the C45 scan is indeed expensive (around
> 2.7 seconds, due to a huge number of bus transactions), and called twice.
> 
> [...]

Here is the summary with links:
  - [net-next,v4,1/4] net: dsa: mv88e6xxx: don't dispose of Global2 IRQ mappings from mdiobus code
    https://git.kernel.org/netdev/net-next/c/b1a2de9ccfe6
  - [net-next,v4,2/4] net: dsa: mv88e6xxx: re-order functions
    https://git.kernel.org/netdev/net-next/c/f1bee740fa82
  - [net-next,v4,3/4] net: dsa: mv88e6xxx: move call to mv88e6xxx_mdios_register()
    https://git.kernel.org/netdev/net-next/c/2cb0658d4f88
  - [net-next,v4,4/4] net: dsa: mv88e6xxx: mask apparently non-existing phys during probing
    https://git.kernel.org/netdev/net-next/c/2c7e46edbd03

You are awesome, thank you!