mbox series

[v9,0/3] Add support for NXP bluetooth chipsets

Message ID 20230313140924.3104691-1-neeraj.sanjaykale@nxp.com
Headers
Series Add support for NXP bluetooth chipsets |

Message

Neeraj Sanjay Kale March 13, 2023, 2:09 p.m. UTC 
  This patch adds a driver for NXP bluetooth chipsets.

The driver is based on H4 protocol, and uses serdev APIs. It supports host
to chip power save feature, which is signalled by the host by asserting
break over UART TX lines, to put the chip into sleep state.

To support this feature, break_ctl has also been added to serdev-tty along
with a new serdev API serdev_device_break_ctl().

This driver is capable of downloading firmware into the chip over UART.

The document specifying device tree bindings for this driver is also
included in this patch series.

Neeraj Sanjay Kale (3):
  serdev: Add method to assert break signal over tty UART port
  dt-bindings: net: bluetooth: Add NXP bluetooth support
  Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets

 .../net/bluetooth/nxp,88w8987-bt.yaml         |   46 +
 MAINTAINERS                                   |    7 +
 drivers/bluetooth/Kconfig                     |   12 +
 drivers/bluetooth/Makefile                    |    1 +
 drivers/bluetooth/btnxpuart.c                 | 1293 +++++++++++++++++
 drivers/tty/serdev/core.c                     |   17 +-
 drivers/tty/serdev/serdev-ttyport.c           |   16 +-
 include/linux/serdev.h                        |    6 +
 8 files changed, 1393 insertions(+), 5 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
 create mode 100644 drivers/bluetooth/btnxpuart.c

Comments

Ilpo Järvinen March 13, 2023, 2:30 p.m. UTC | #1 
On Mon, 13 Mar 2023, Neeraj sanjay kale wrote:

> > 
> > Thanks, looks okay to me except this one I just noticed while preparing this
> > email:
> > 
> > > +MODULE_DESCRIPTION("NXP Bluetooth Serial driver v1.0 ");
> > 
> > I don't think version numbers belong to the module description.
> > 
> I was asked to remove the MODULE_VERSION("v1.0") line in my v2 patch, hence kept it in the description.
> https://patchwork.kernel.org/project/bluetooth/patch/20230130180504.2029440-4-neeraj.sanjaykale@nxp.com/
> 
> Please suggest me the right way to put the version string in this driver.

I think Leon meant you should just drop the version altogether (since this 
is new code).