Message ID | 20230310164549.22133-1-andriy.shevchenko@linux.intel.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp981695wrd; Fri, 10 Mar 2023 08:56:06 -0800 (PST) X-Google-Smtp-Source: AK7set8XyYhZQrMxWAn9V1+DmOTP/N2Hxugp/wgc+aIlk3A7hma6owSyJkpeCUiHQc5bzCyZzkba X-Received: by 2002:a05:6a20:441d:b0:ce:2fb4:5fc4 with SMTP id ce29-20020a056a20441d00b000ce2fb45fc4mr30407307pzb.38.1678467366052; Fri, 10 Mar 2023 08:56:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678467366; cv=none; d=google.com; s=arc-20160816; b=ZxdvceiVfhC77TMjmAe7+EWa2k8Ds5vRvxDeq1QkXruXoRM8FI5IyC6CDIm4l4Ppnh 6SlzHcNwglREiQwNPq7EzWNlVBJDAoAlmKk8A+WVR7Tgu+pF6dQpEntMsLHc+wipSz2r yg18jCcvGZTnc78VFaBz5IMfo0G1MuOXjbY7F4NkuHiLrV4/KCnK3KdQAVCDmNmowwPg q+r1ZaDl2vCJiwc9rgz9Zz6u6KMEd7vhrvIaNofKuL+A6eNUb4bHjyaElMlGSUUNtJTa qxm1Z0PsMkLWIu/bFFftfBxLF9+jqfq9mhmm9PioftXUps6d4XFC8nc7vCaxTtRp6jn5 vvuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=Qpjq9iU94e+g/25lUqDUxbv3P3N/xQVUpMdMPNQI7k4=; b=Vi1AmRlzo4VKPwg4c7I3vDZR4c5PqEhqmLjHYV8dn5g8WhVVz9Nmpu/1US/y/CH+A6 RtmxBHz1rybdvhx7ztwsqe4podeI2UViiiOpIPP58uZSi0//esbQOpjx/DxWdCOQXar7 8hOMNT5Z1UT8sAMY0orU6t2OSl1E+O7S2Y5HwnzgFRA0l06Y6LptjwYfe9SwAKovjdYz dnyiWNQDDPGCb50ldoEHlJRYjXSWua0uZ0j7BEMljXI0SBYkSTwBKW9n1GfQ87EO8K2P 34FISkRLyU3YsmCqxJ+fBuwGOBnGiHVTnyE8X2PRvu836rs5p89eopNJv7x0U2GNKU5B KR8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=De8azeCb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q10-20020a65624a000000b004fbacd1a872si167513pgv.853.2023.03.10.08.55.51; Fri, 10 Mar 2023 08:56:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=De8azeCb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231551AbjCJQup (ORCPT <rfc822;carlos.wei.hk@gmail.com> + 99 others); Fri, 10 Mar 2023 11:50:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231408AbjCJQuJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 10 Mar 2023 11:50:09 -0500 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB00A12CBA2; Fri, 10 Mar 2023 08:47:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678466833; x=1710002833; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=3DsGu1jwco8wmdWAk/QWXYjdi9zG7FhO1g6n5CcqOjE=; b=De8azeCbnLdsZf8XeiS5QKsQ7KsKdl3XIvH65ywgzFNVG14HJFwrAjBu I8Fhm3oLm7lBLpkGMnH8odAgByCBZRQeu3Ot45rkon3SlXymLesDs9jvQ SI7jOlgRWmrL8ehWsQaUbH1A6U7CRkOlmNMwQ/uGnS7rVKrTKft0i97Qr LX5WWniQNKkdPupCethuX8CKameviPCUjyljGyfuFtxHu79MAQBoRYdPf AoFFa6sE7oyiRY5Fk3ASYEqvr9BJK8qQZLf10u3hCUrRoz1DKrDu+YePe io4WNv/wxsaKA13smPo/2AmLR+MsIIzB8DyNfC8ao9Idi1QdMH5oDD3N3 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10645"; a="320621127" X-IronPort-AV: E=Sophos;i="5.98,250,1673942400"; d="scan'208";a="320621127" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2023 08:45:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10645"; a="746778622" X-IronPort-AV: E=Sophos;i="5.98,250,1673942400"; d="scan'208";a="746778622" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 10 Mar 2023 08:45:08 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 050B6143; Fri, 10 Mar 2023 18:45:52 +0200 (EET) From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Jens Axboe <axboe@kernel.dk>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 0/9] pktdvd: Clean up the driver Date: Fri, 10 Mar 2023 18:45:40 +0200 Message-Id: <20230310164549.22133-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760000596801790330?= X-GMAIL-MSGID: =?utf-8?q?1760000596801790330?= |
Series |
pktdvd: Clean up the driver
|
|
Message
Andy Shevchenko
March 10, 2023, 4:45 p.m. UTC
Some cleanups to the recently resurrected driver. v2: - added tags (Greg) Andy Shevchenko (9): pktcdvd: Get rid of custom printing macros pktcdvd: replace sscanf() by kstrtoul() pktcdvd: use sysfs_emit() to instead of scnprintf() pktcdvd: Get rid of pkt_seq_show() forward declaration pktcdvd: Drop redundant castings for sector_t pktcdvd: Use DEFINE_SHOW_ATTRIBUTE() to simplify code pktcdvd: Use put_unaligned_be16() and get_unaligned_be16() pktcdvd: Get rid of redundant 'else' pktcdvd: Sort headers drivers/block/pktcdvd.c | 525 +++++++++++++++++------------------ include/linux/pktcdvd.h | 1 - include/uapi/linux/pktcdvd.h | 1 + 3 files changed, 257 insertions(+), 270 deletions(-)
Comments
On Fri, Mar 10, 2023 at 06:45:40PM +0200, Andy Shevchenko wrote: > Some cleanups to the recently resurrected driver. Anybody to pick this up, please? > v2: > - added tags (Greg) > > Andy Shevchenko (9): > pktcdvd: Get rid of custom printing macros > pktcdvd: replace sscanf() by kstrtoul() > pktcdvd: use sysfs_emit() to instead of scnprintf() > pktcdvd: Get rid of pkt_seq_show() forward declaration > pktcdvd: Drop redundant castings for sector_t > pktcdvd: Use DEFINE_SHOW_ATTRIBUTE() to simplify code > pktcdvd: Use put_unaligned_be16() and get_unaligned_be16() > pktcdvd: Get rid of redundant 'else' > pktcdvd: Sort headers > > drivers/block/pktcdvd.c | 525 +++++++++++++++++------------------ > include/linux/pktcdvd.h | 1 - > include/uapi/linux/pktcdvd.h | 1 + > 3 files changed, 257 insertions(+), 270 deletions(-) > > -- > 2.39.1 >
On 6/6/23 8:58 AM, Andy Shevchenko wrote: > On Fri, Mar 10, 2023 at 06:45:40PM +0200, Andy Shevchenko wrote: >> Some cleanups to the recently resurrected driver. > > Anybody to pick this up, please? I can pick it up, I'm assuming this is all untested?
On Tue, Jun 06, 2023 at 02:23:03PM -0600, Jens Axboe wrote: > On 6/6/23 8:58 AM, Andy Shevchenko wrote: > > On Fri, Mar 10, 2023 at 06:45:40PM +0200, Andy Shevchenko wrote: > >> Some cleanups to the recently resurrected driver. > > > > Anybody to pick this up, please? > > I can pick it up, I'm assuming this is all untested? Compile tested only. So I assume the answer is yes, untested.
On 6/7/23 2:08 PM, Andy Shevchenko wrote: > On Tue, Jun 06, 2023 at 02:23:03PM -0600, Jens Axboe wrote: >> On 6/6/23 8:58 AM, Andy Shevchenko wrote: >>> On Fri, Mar 10, 2023 at 06:45:40PM +0200, Andy Shevchenko wrote: >>>> Some cleanups to the recently resurrected driver. >>> >>> Anybody to pick this up, please? >> >> I can pick it up, I'm assuming this is all untested? > > Compile tested only. So I assume the answer is yes, untested. I'd be surprised if you said you actually ran it. Series looks sane, I'll get it applied. Thanks.
On Fri, 10 Mar 2023 18:45:40 +0200, Andy Shevchenko wrote: > Some cleanups to the recently resurrected driver. > > v2: > - added tags (Greg) > > Andy Shevchenko (9): > pktcdvd: Get rid of custom printing macros > pktcdvd: replace sscanf() by kstrtoul() > pktcdvd: use sysfs_emit() to instead of scnprintf() > pktcdvd: Get rid of pkt_seq_show() forward declaration > pktcdvd: Drop redundant castings for sector_t > pktcdvd: Use DEFINE_SHOW_ATTRIBUTE() to simplify code > pktcdvd: Use put_unaligned_be16() and get_unaligned_be16() > pktcdvd: Get rid of redundant 'else' > pktcdvd: Sort headers > > [...] Applied, thanks! [1/9] pktcdvd: Get rid of custom printing macros commit: 3a41db531e5124adaa3a9ab9ca0c724aee85b10c [2/9] pktcdvd: replace sscanf() by kstrtoul() commit: 1a0ddd56e545b743af510b5a1b8dbdfe7d35cd3b [3/9] pktcdvd: use sysfs_emit() to instead of scnprintf() commit: 3bb5746c26cdfcc354af4867c02f1e0ec1131a62 [4/9] pktcdvd: Get rid of pkt_seq_show() forward declaration commit: f023faaa988671f0f1d1a965dc5d7e61d0f5e65e [5/9] pktcdvd: Drop redundant castings for sector_t commit: 93c8f6f38be67e30adf8d8eb5e7e9ccb89326119 [6/9] pktcdvd: Use DEFINE_SHOW_ATTRIBUTE() to simplify code commit: 80d994d2a71f88e0809dcaccef2259c791d2e3ef [7/9] pktcdvd: Use put_unaligned_be16() and get_unaligned_be16() commit: 046636a4bac575aff78e44c7e1cff84c83a345a9 [8/9] pktcdvd: Get rid of redundant 'else' commit: 6a5945a8eb5a626afe6feb341824e7e1d007c8ff [9/9] pktcdvd: Sort headers commit: 7da15fb0318f18398feea2848d099a8d0d7b5965 Best regards,