From patchwork Thu Mar 9 14:42:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Ceresoli X-Patchwork-Id: 6364 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp340907wrd; Thu, 9 Mar 2023 07:07:08 -0800 (PST) X-Google-Smtp-Source: AK7set8DurkmJ8Z/vPfP3dq8lG3cviC/PNvkYlVdkn/383A3so3kNYDGA53Rps/HkuvZzVnFWrfc X-Received: by 2002:a92:b512:0:b0:316:b0bb:3d99 with SMTP id f18-20020a92b512000000b00316b0bb3d99mr12780231ile.22.1678374428294; Thu, 09 Mar 2023 07:07:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678374428; cv=none; d=google.com; s=arc-20160816; b=QZR2LE3ZtTX6GuXa7FOAmC4IofGXgaegvj0TunxxFJl3IGPXT0FgXjOa9Zc+kK3jvb W34ZGJbW5+/Wbq0tBd/KbZgOJFClAQAzq2K9QsSExRH0a2I2O6FA/beuhP+EKffVxHxz pTDd81uuqgUzpsXNRfMwsx3JOeVJFQpribVWNwygOVnTgKChovJ0fyrH7loNJUfQF0zQ TuO1Be3XKqFyrnvsQrQ09Wd9iKH15qolG/aQPrN0Dcxc03EuOMEdB+PKyJUGCAC8oUFo kvAXdGrPqlFwiFQjxzUesfIrCwDMOTmK/F1/l1u9HKtWXycgxZ5BX7q4XCzbpIROtg3y Td/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=fFIStvzjG6NFefixEztuAuCcY8eOY+sEQukOjltysug=; b=X3iVDNwa5RwvGPDURvOuEmyqR48nk/HeGSj7G07M09F/jLhFkun40jY83hEctanNFj uKmIZ0y0x1du4jemMR9b9ISSkkUTrD9rjFBe7FXPaDAyhwunwgi8oCBhY4QH9u2NsCPa /XmXiyr3ryqmU6121mmhdfLEWxftBYwvzkqDANIQOBe7qMzu8ZCw5B6inPdZcLerTFm5 bf9/an/9xR9zv9uQievcMKiZdcVxqRNYypbwZzzfmzH1mGQXz6uY03hR8GT5oV3D/lJt 2QTHTAitVoPDgfQ9Ukyx3bH6oHaq/YALmU0qFJ0pZ+IwZ/uTQEl06WYoNbH7q+iyLNei dEBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=PeCyW8tg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l1-20020a922901000000b00310a52b83b6si17221744ilg.98.2023.03.09.07.06.53; Thu, 09 Mar 2023 07:07:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=PeCyW8tg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231665AbjCIOnq (ORCPT + 99 others); Thu, 9 Mar 2023 09:43:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231361AbjCIOnk (ORCPT ); Thu, 9 Mar 2023 09:43:40 -0500 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E02E5CEEA; Thu, 9 Mar 2023 06:43:27 -0800 (PST) Received: from booty.fritz.box (unknown [77.244.183.192]) (Authenticated sender: luca.ceresoli@bootlin.com) by mail.gandi.net (Postfix) with ESMTPA id 64356FF80F; Thu, 9 Mar 2023 14:43:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1678373006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=fFIStvzjG6NFefixEztuAuCcY8eOY+sEQukOjltysug=; b=PeCyW8tgxjY2dKQEMWmCSKW5UVU3QiP+ZraVzWeU0N8mkuStAsGb9KQUsgiYSsdY60ojoF vPq7xZWv2B+g9BKQiSv3nRaQEOCyM6MR723MczDp3uBMCPJWTc7OXAvmILZjKk3MzHeaGs NyLwtyJKRdZTGnTvOvWt8z53POXxiE7M1ZIZ3b/ssKEQ6dbOyvUMqG8LGaFlG54nfxiJf6 XGXlUv7JWtg6P/F42Pn4mCXidRBrY5K9dA+QKSOnf1NGfB7oIhKbGfTFVNuv3iVySmg0YF JJe9luaAn5YulUBB+DprrP8DY5GO4rfqLgL7/mVPImmK5yhdDoEkJMVDYyA//g== From: Luca Ceresoli To: Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Mauro Carvalho Chehab , Greg Kroah-Hartman , Dmitry Osipenko , Hans Verkuil Cc: Luca Ceresoli , linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Thomas Petazzoni , Paul Kocialkowski , Richard Leitner Subject: [RESEND PATCH v4 00/21] Add Tegra20 parallel video input capture Date: Thu, 9 Mar 2023 15:42:59 +0100 Message-Id: <20230309144320.2937553-1-luca.ceresoli@bootlin.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759903144425741854?= X-GMAIL-MSGID: =?utf-8?q?1759903144425741854?= TL;DR: Resending this series with Rob's review tag added. Now all DT patches have at least a reviewed-by tag from Rob or Krzysztof, all the driver patches have one from Dmitry. Full details follow. Tegra20 and other Tegra SoCs have a video input (VI) peripheral that can receive from either MIPI CSI-2 or parallel video (called respectively "CSI" and "VIP" in the documentation). The kernel currently has a staging driver for Tegra210 CSI capture. This patch set adds support for Tegra20 VIP capture. Unfortunately I had no real documentation available to base this work on. I only had a working downstream 3.1 kernel, so I started with the driver found there and heavily reworked it to fit into the mainline tegra-video driver structure. The existing code appears written with the intent of being modular and allow adding new input mechanisms and new SoCs while keeping a unique VI core module. However its modularity and extensibility was not enough to add Tegra20 VIP support, so I added some hooks to turn hard-coded behaviour into per-SoC or per-bus customizable code. There are also a fix, some generic cleanups and DT bindings. Quick tour of the patches: * Device tree bindings 01. dt-bindings: display: tegra: add Tegra20 VIP 02. dt-bindings: display: tegra: vi: add 'vip' property and example * A fix 03. staging: media: tegra-video: fix .vidioc_enum_fmt_vid_cap to return all formats * Minor improvements to logging, comments, cleanups 04. staging: media: tegra-video: improve documentation of tegra_video_format fields 05. staging: media: tegra-video: document tegra_channel_get_remote_source_subdev 06. staging: media: tegra-video: fix typos in comment 07. staging: media: tegra-video: improve error messages 08. staging: media: tegra-video: slightly simplify cleanup on errors 09. staging: media: tegra-video: move private struct declaration to C file 10. staging: media: tegra-video: move tegra210_csi_soc to C file 11. staging: media: tegra-video: remove unneeded include * Preparation to make the VI module generic enough to host Tegra20 and VIP 12. staging: media: tegra-video: Kconfig: allow TPG only on Tegra210 13. staging: media: tegra-video: move tegra_channel_fmt_align to a per-soc op 14. staging: media: tegra-video: move default format to soc-specific data 15. staging: media: tegra-video: move MIPI calibration calls from VI to CSI 16. staging: media: tegra-video: add a per-soc enable/disable op 17. staging: media: tegra-video: move syncpt init/free to a per-soc op 18. staging: media: tegra-video: add syncpts for Tegra20 to struct tegra_vi 19. staging: media: tegra-video: add hooks for planar YUV and H/V flip 20. staging: media: tegra-video: add H/V flip controls * Implementation of VIP and Tegra20 21. staging: media: tegra-video: add support for Tegra20 parallel input Enjoy! Changed in RESEND,v4: - add Rob's review tag on patch 2 Changed in v4: - fixed the leftovers after the removal of 'channel@0' in DT - added review tags by Dimtry Changed in v3: - removed the 'channel@0' node from the device tree representation of vip - squashed the last two patches (VIP + T20) into one - small cleanups - rebase on v6.2-rc1 Changed in v2: - improved dt-bindings patches based on reviews - removed patches 3 and 4 adding DT labels without a mainline user - two small fixes to the last patch [v4] https://lore.kernel.org/linux-tegra/20230130141603.323221-1-luca.ceresoli@bootlin.com/ [v3] https://lore.kernel.org/linux-media/20221229133205.981397-1-luca.ceresoli@bootlin.com/ [v2] https://lore.kernel.org/linux-tegra/20221222100328.6e341874@booty/T/#t [v1] https://lore.kernel.org/linux-tegra/20221124155634.5bc2a423@booty/T/#t Luca Luca Ceresoli (21): dt-bindings: display: tegra: add Tegra20 VIP dt-bindings: display: tegra: vi: add 'vip' property and example staging: media: tegra-video: fix .vidioc_enum_fmt_vid_cap to return all formats staging: media: tegra-video: improve documentation of tegra_video_format fields staging: media: tegra-video: document tegra_channel_get_remote_source_subdev staging: media: tegra-video: fix typos in comment staging: media: tegra-video: improve error messages staging: media: tegra-video: slightly simplify cleanup on errors staging: media: tegra-video: move private struct declaration to C file staging: media: tegra-video: move tegra210_csi_soc to C file staging: media: tegra-video: remove unneeded include staging: media: tegra-video: Kconfig: allow TPG only on Tegra210 staging: media: tegra-video: move tegra_channel_fmt_align to a per-soc op staging: media: tegra-video: move default format to soc-specific data staging: media: tegra-video: move MIPI calibration calls from VI to CSI staging: media: tegra-video: add a per-soc enable/disable op staging: media: tegra-video: move syncpt init/free to a per-soc op staging: media: tegra-video: add syncpts for Tegra20 to struct tegra_vi staging: media: tegra-video: add hooks for planar YUV and H/V flip staging: media: tegra-video: add H/V flip controls staging: media: tegra-video: add support for Tegra20 parallel input .../display/tegra/nvidia,tegra20-vi.yaml | 59 ++ .../display/tegra/nvidia,tegra20-vip.yaml | 41 ++ MAINTAINERS | 3 + drivers/staging/media/tegra-video/Kconfig | 1 + drivers/staging/media/tegra-video/Makefile | 2 + drivers/staging/media/tegra-video/csi.c | 48 ++ drivers/staging/media/tegra-video/csi.h | 4 - drivers/staging/media/tegra-video/tegra20.c | 661 ++++++++++++++++++ drivers/staging/media/tegra-video/tegra210.c | 97 ++- drivers/staging/media/tegra-video/vi.c | 321 ++------- drivers/staging/media/tegra-video/vi.h | 75 +- drivers/staging/media/tegra-video/video.c | 5 + drivers/staging/media/tegra-video/video.h | 2 +- drivers/staging/media/tegra-video/vip.c | 290 ++++++++ drivers/staging/media/tegra-video/vip.h | 68 ++ 15 files changed, 1387 insertions(+), 290 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vip.yaml create mode 100644 drivers/staging/media/tegra-video/tegra20.c create mode 100644 drivers/staging/media/tegra-video/vip.c create mode 100644 drivers/staging/media/tegra-video/vip.h