From patchwork Wed Mar 8 15:58:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abel Vesa X-Patchwork-Id: 6311 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp426759wrd; Wed, 8 Mar 2023 08:16:02 -0800 (PST) X-Google-Smtp-Source: AK7set/0bte0Le+nNjmOC6uDRP6QzUeQ0LauS/rS3eRe5xxIMQaS4oEnKiS7ceOG7kVYmVtxgJLH X-Received: by 2002:a05:6a20:698b:b0:cd:1808:87bb with SMTP id t11-20020a056a20698b00b000cd180887bbmr17409077pzk.7.1678292161760; Wed, 08 Mar 2023 08:16:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678292161; cv=none; d=google.com; s=arc-20160816; b=U5p5wsS/sh0shM2VEmaes9ZdMM4U8C+MQx3TllE1cr/arbKbuKu+wb37AeyiEi2OYF m/33vSK9pXPnCyWfOaaS0GDBvAJ5ENAj68ICdIWfohBz4k4gp5hfCDVMh9rgaEmlsZOS wJrvW8gfYbqNAMQTgnbkRkJ1AwcaKWKRU9Z+nDhkG7TVi7JpeIUwohTriM6AwDXr7sOb ZlxDUw3fc006mW945XcNWc32wqaiitOMao0s9x4lI0INP5EQrCsbE3B7MXdC/DKxbvDf 7PwYm4DnQhjErRuheTBfNc386aPUhsdc0pj+bIc7YuunNIsa4R4xkOUiEVABNmlNeV5q 1D3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=T5JFu944VlLvwqNSsdE85tDBaxtEQbqvWWGACaI1P34=; b=MAOWio32DecZqaIZjBH1GBjDPByvQxgSsgCkFDrBpFbCDstpaGqClj5ym6PGwBodNk 5ceAJ485YZEY3179Di04YxaqA/cD0hYo42R13rbhdYFBawhVNAraz4AOcPT3al82gyRZ UV5lOQho5orhjje22A/tL1NFo5/23mWlcYP2g5wgz9iW4ZEWqEMs0i140ri1MZ04GkFm BgMH+mzhRD0yUXiZr+hwQd3EoNpFHYy53LL18Tm0DIZrHFRALY/JfLEsg3zeSQJnF3PZ 7HjON5qflnsaPJqarGdng6/cOpAPVzU8tcO2AHT0h+30/5Rgv/a7WihKvnqi3HHyUmWg rpSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Cs38mQ7H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 145-20020a630297000000b0050726756ee8si12072204pgc.93.2023.03.08.08.15.46; Wed, 08 Mar 2023 08:16:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Cs38mQ7H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232312AbjCHQAQ (ORCPT + 99 others); Wed, 8 Mar 2023 11:00:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232315AbjCHP7g (ORCPT ); Wed, 8 Mar 2023 10:59:36 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F5C68B33F for ; Wed, 8 Mar 2023 07:59:08 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id ay29-20020a05600c1e1d00b003e9f4c2b623so1649093wmb.3 for ; Wed, 08 Mar 2023 07:59:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678291147; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=T5JFu944VlLvwqNSsdE85tDBaxtEQbqvWWGACaI1P34=; b=Cs38mQ7Hzy6NxzN0rw7/y88YnnIDhIAuRTXJu6qG97obQbgcYrjupSnC4l7N+mQmF3 0Zp0FSEG4C5QNIllix0Pq/SC9NT7/CTPoTpFQd/o10bJB7yOCWAJKl6ujghc1QtX5t17 f59ued4d/wvE0bjnUGbBvSbaXrLOF4xGbS1ouemYCfePszZYi0XPs5XLvtZz1dkM298j 7g9zMkw6Clxh2Au5OoKnld95SrNuIINJ/KIagvdnmqUvn/Z+Sq2bakqGP5a5R5dirDgt SP6tVIl/ktAXf+wy4cFn+dUmv82yeHN5uFPNnhOIoytgYXYNKbjAb/TccB21ER15ZRJ2 fK4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678291147; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=T5JFu944VlLvwqNSsdE85tDBaxtEQbqvWWGACaI1P34=; b=OdtZT7vobXUHk5hFPaQTlVAhKpcRJWg2ixgoZGztP/wpdmqevn0Kqj7RfnGRBhZujr tjJnLbobNtS2vTBORA9+jQayuQPrkaLcdAoCjYeegN1zNR8Y55/5Ky/ArmAomtR11PzY 6SAunYMz1Pra+VUZfz0YfUvYy+3/Bf8C5jqBwWS8Sh+xgpzKM3YCzpfKUdJaSLAyoyOi xbHV3+aN8Zh3daDU9YgouO4UnXNehwcEEGJcoSeBZnFJeiG1+OWFZwVykEbR2GXhXNUW JbwDusoirr0Q8AeaIC7zdzOoeyqoai/BhlaH2iKZvgjrtZtMu8cMUXDzMeL5wldYb5dV /lVQ== X-Gm-Message-State: AO0yUKXio/fx93fUwhxjx19ALmhIrjX0cwZkkP4moPwx5cnoV8Zju97m dj4yHCLsqzA1o4pZDSNVKyg1UQ== X-Received: by 2002:a05:600c:4511:b0:3ea:e554:7808 with SMTP id t17-20020a05600c451100b003eae5547808mr16689893wmo.19.1678291146902; Wed, 08 Mar 2023 07:59:06 -0800 (PST) Received: from hackbox.lan ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id 16-20020a05600c229000b003eb2e33f327sm2548430wmf.2.2023.03.08.07.59.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 07:59:06 -0800 (PST) From: Abel Vesa To: Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , Alim Akhtar , Avri Altman , Bart Van Assche , Adrian Hunter , "James E . J . Bottomley" , "Martin K . Petersen" Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, Linux Kernel Mailing List , linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org Subject: [RFC PATCH v2 0/7] Add dedicated Qcom ICE driver Date: Wed, 8 Mar 2023 17:58:31 +0200 Message-Id: <20230308155838.1094920-1-abel.vesa@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759816881899210973?= X-GMAIL-MSGID: =?utf-8?q?1759816881899210973?= As both SDCC and UFS drivers use the ICE with duplicated implementation, while none of the currently supported platforms make use concomitantly of the same ICE IP block instance, the new SM8550 allows both UFS and SDCC to do so. In order to support such scenario, there is a need for a unified implementation and a devicetree node to be shared between both types of storage devices. So lets drop the duplicate implementation of the ICE from both SDCC and UFS and make it a dedicated (soc) driver. Also, switch all UFS and SDCC devicetree nodes to use the new ICE approach. See each individual patch for changelogs. The v1 is here: https://lore.kernel.org/all/20230214120253.1098426-1-abel.vesa@linaro.org/ Abel Vesa (7): dt-bindings: soc: qcom: Add schema for Inline Crypto Engine dt-bindings: ufs: qcom: Add ICE phandle and drop core clock dt-bindings: mmc: sdhci-msm: Add ICE phandle and drop core clock soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicated driver scsi: ufs: ufs-qcom: Switch to the new ICE API mmc: sdhci-msm: Switch to the new ICE API arm64: dts: qcom: Add the Inline Crypto Engine nodes .../devicetree/bindings/mmc/sdhci-msm.yaml | 9 +- .../soc/qcom/qcom,inline-crypto-engine.yaml | 42 +++ .../devicetree/bindings/ufs/qcom,ufs.yaml | 14 +- arch/arm64/boot/dts/qcom/sdm630.dtsi | 18 +- arch/arm64/boot/dts/qcom/sdm670.dtsi | 15 +- arch/arm64/boot/dts/qcom/sdm845.dtsi | 21 +- arch/arm64/boot/dts/qcom/sm6115.dtsi | 37 ++- arch/arm64/boot/dts/qcom/sm6350.dtsi | 31 +- arch/arm64/boot/dts/qcom/sm8150.dtsi | 21 +- arch/arm64/boot/dts/qcom/sm8450.dtsi | 22 +- drivers/mmc/host/Kconfig | 2 +- drivers/mmc/host/sdhci-msm.c | 257 ++------------- drivers/soc/qcom/Kconfig | 6 + drivers/soc/qcom/Makefile | 1 + drivers/soc/qcom/ice.c | 301 ++++++++++++++++++ drivers/ufs/host/Kconfig | 2 +- drivers/ufs/host/Makefile | 1 - drivers/ufs/host/ufs-qcom-ice.c | 244 -------------- drivers/ufs/host/ufs-qcom.c | 50 ++- drivers/ufs/host/ufs-qcom.h | 30 +- include/soc/qcom/ice.h | 65 ++++ 21 files changed, 608 insertions(+), 581 deletions(-) create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,inline-crypto-engine.yaml create mode 100644 drivers/soc/qcom/ice.c delete mode 100644 drivers/ufs/host/ufs-qcom-ice.c create mode 100644 include/soc/qcom/ice.h