mbox series

[v1,00/25] Update Colibri iMX8X Devicetrees

Message ID 20230308125300.58244-1-dev@pschenker.ch
Headers
Series Update Colibri iMX8X Devicetrees |

Message

Philippe Schenker March 8, 2023, 12:52 p.m. UTC 
  From: Philippe Schenker <philippe.schenker@toradex.com>

This patch series does update the device-trees for Colibri iMX8X to the
latest state of development.

Adds the Carrier Board device-trees for:

- Aster
- Iris
- Iris v2

It as well changes ordering to be alphabetically and changes the
pinmuxing bracket format together with some minor fixes.


Philippe Schenker (25):
  arm64: dts: colibri-imx8x: Prepare for qxp and dx variants
  arm64: dts: colibri-imx8x: Update spdx license
  arm64: dts: colibri-imx8x: Sort properties
  arm64: dts: colibri-imx8x: Use new bracket format
  arm64: dts: colibri-imx8x: Add atmel pinctrl groups
  arm64: dts: colibri-imx8x: Add pinctrl group for csi_mclk
  arm64: dts: colibri-imx8x: Split pinctrl_hog1
  arm64: dts: colibri-imx8x: Correct pull on lcdif
  arm64: dts: colibri-imx8x: Add separate pinctrl group for cs2
  arm64: dts: colibri-imx8x: Add pinctrl group for hdmi hpd
  arm64: dts: colibri-imx8x: Sort fec1 node alphabetically
  arm64: dts: colibri-imx8x: Add SPI
  arm64: dts: colibri-imx8x: Add gpio-line-names
  arm64: dts: colibri-imx8x: Disable touchscreen by default
  arm64: dts: colibri-imx8x: Add jpegenc/dec
  arm64: dts: colibri-imx8x: Add colibri pwm b, c, d
  arm64: dts: colibri-imx8x: eval: Add spi-to-can
  arm64: dts: colibri-imx8x: Add no-1-8-v to sd-card
  arm64: dts: colibri-imx8x: Set thermal thresholds
  arm64: dts: colibri-imx8x: Move gpio-keys to som level
  arm64: dts: colibri-imx8x: Add todo comments
  dt-bindings: arm: fsl: Add colibri-imx8x carrier boards
  arm64: dts: colibri-imx8x: Add aster carrier board
  arm64: dts: colibri-imx8x: Add iris carrier board
  arm64: dts: colibri-imx8x: Add iris v2 carrier board

 .../devicetree/bindings/arm/fsl.yaml          |   5 +-
 arch/arm64/boot/dts/freescale/Makefile        |   3 +
 .../dts/freescale/imx8qxp-colibri-aster.dts   |  16 +
 .../dts/freescale/imx8qxp-colibri-eval-v3.dts |   6 +-
 .../freescale/imx8qxp-colibri-eval-v3.dtsi    |  62 --
 .../dts/freescale/imx8qxp-colibri-iris-v2.dts |  16 +
 .../dts/freescale/imx8qxp-colibri-iris.dts    |  16 +
 .../boot/dts/freescale/imx8qxp-colibri.dtsi   | 592 +------------
 .../dts/freescale/imx8x-colibri-aster.dtsi    |  44 +
 .../dts/freescale/imx8x-colibri-eval-v3.dtsi  |  91 ++
 .../dts/freescale/imx8x-colibri-iris-v2.dtsi  |  45 +
 .../dts/freescale/imx8x-colibri-iris.dtsi     | 115 +++
 .../boot/dts/freescale/imx8x-colibri.dtsi     | 776 ++++++++++++++++++
 13 files changed, 1132 insertions(+), 655 deletions(-)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8qxp-colibri-aster.dts
 delete mode 100644 arch/arm64/boot/dts/freescale/imx8qxp-colibri-eval-v3.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/imx8qxp-colibri-iris-v2.dts
 create mode 100644 arch/arm64/boot/dts/freescale/imx8qxp-colibri-iris.dts
 create mode 100644 arch/arm64/boot/dts/freescale/imx8x-colibri-aster.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/imx8x-colibri-iris-v2.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/imx8x-colibri-iris.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/imx8x-colibri.dtsi

Comments

Krzysztof Kozlowski March 8, 2023, 1 p.m. UTC | #1 
On 08/03/2023 13:52, Philippe Schenker wrote:
> From: Philippe Schenker <philippe.schenker@toradex.com>
> 
> Add mcp2515 spi-to-can to &lpspi2.
> 
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
> ---
> 
>  .../dts/freescale/imx8x-colibri-eval-v3.dtsi  | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi b/arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi
> index 625d2caaf5d1..e7e3cf462408 100644
> --- a/arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8x-colibri-eval-v3.dtsi

There is no such file.

> @@ -11,6 +11,13 @@ aliases {
>  		rtc1 = &rtc;
>  	};
>  
> +	/* fixed crystal dedicated to mcp25xx */
> +	clk16m: clock-16mhz-fixed {

Drop "fixed".

> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <16000000>;
> +	};
> +
>  	gpio-keys {
>  		compatible = "gpio-keys";
>  		pinctrl-names = "default";
> @@ -44,6 +51,18 @@ rtc_i2c: rtc@68 {
>  /* Colibri SPI */
>  &lpspi2 {
>  	status = "okay";
> +
> +	mcp2515: can@0 {
> +		compatible = "microchip,mcp2515";
> +		reg = <0>;
> +		interrupt-parent = <&lsio_gpio3>;
> +		interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
> +		pinctrl-0 = <&pinctrl_can_int>;
> +		pinctrl-names = "default";
> +		clocks = <&clk16m>;

You just sorted all nodes in previous patches and add something
unsorted? What is then the style of order? Random name?

> +		spi-max-frequency = <10000000>;
> +		status = "okay";

Why do you need it?

> +	};
>  };
>  
>  /* Colibri UART_B */

Best regards,
Krzysztof