mbox series

[v2,0/8] platform/x86: ISST: Use TPMI interface

Message ID 20230308070642.1727167-1-srinivas.pandruvada@linux.intel.com
Headers
Series platform/x86: ISST: Use TPMI interface |

Message

srinivas pandruvada March 8, 2023, 7:06 a.m. UTC 
  This series implements TPMI as Intel Speed Select Technology (Intel SST)
HW interface. TPMI has several advantages for Intel SST. This replaces
legacy mailbox and MMIO with architectural interface over TPMI.

This improves performance for HPC type applications. One single IOCTL command
replaces 10s of IOCTLs for mailboxes. This allowed to offer many more
performance levels and SST configurations.

This series depends on previously posted series:
- platform/x86/intel: Intel TPMI enumeration driver

Change History
v2
- Rebased on top of review-hans branch of platform-drivers-x86
- Removed patches which are already present in this branch from the last review
So number of patches are reduced from 12 to 8.
- Rework patch for MSR 0x54 support
- Use suggestion from Hans for suspend/resume callbacks
- Add Reviewed-by and Test-by tags


Srinivas Pandruvada (8):
  platform/x86: ISST: Add support for MSR 0x54
  platform/x86: ISST: Enumerate TPMI SST and create framework
  platform/x86: ISST: Parse SST MMIO and update instance
  platform/x86: ISST: Add SST-CP support via TPMI
  platform/x86: ISST: Add SST-PP support via TPMI
  platform/x86: ISST: Add SST-BF support via TPMI
  platform/x86: ISST: Add SST-TF support via TPMI
  platform/x86: ISST: Add suspend/resume callbacks

 .../x86/intel/speed_select_if/Kconfig         |    4 +
 .../x86/intel/speed_select_if/Makefile        |    2 +
 .../intel/speed_select_if/isst_if_common.c    |   28 +
 .../x86/intel/speed_select_if/isst_tpmi.c     |   72 +
 .../intel/speed_select_if/isst_tpmi_core.c    | 1438 +++++++++++++++++
 .../intel/speed_select_if/isst_tpmi_core.h    |   18 +
 include/uapi/linux/isst_if.h                  |  303 ++++
 7 files changed, 1865 insertions(+)
 create mode 100644 drivers/platform/x86/intel/speed_select_if/isst_tpmi.c
 create mode 100644 drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
 create mode 100644 drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.h

Comments

Hans de Goede March 16, 2023, 2:20 p.m. UTC | #1 
Hi,

On 3/8/23 08:06, Srinivas Pandruvada wrote:
> This series implements TPMI as Intel Speed Select Technology (Intel SST)
> HW interface. TPMI has several advantages for Intel SST. This replaces
> legacy mailbox and MMIO with architectural interface over TPMI.
> 
> This improves performance for HPC type applications. One single IOCTL command
> replaces 10s of IOCTLs for mailboxes. This allowed to offer many more
> performance levels and SST configurations.
> 
> This series depends on previously posted series:
> - platform/x86/intel: Intel TPMI enumeration driver
> 
> Change History
> v2
> - Rebased on top of review-hans branch of platform-drivers-x86
> - Removed patches which are already present in this branch from the last review
> So number of patches are reduced from 12 to 8.
> - Rework patch for MSR 0x54 support
> - Use suggestion from Hans for suspend/resume callbacks
> - Add Reviewed-by and Test-by tags

Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans





> Srinivas Pandruvada (8):
>   platform/x86: ISST: Add support for MSR 0x54
>   platform/x86: ISST: Enumerate TPMI SST and create framework
>   platform/x86: ISST: Parse SST MMIO and update instance
>   platform/x86: ISST: Add SST-CP support via TPMI
>   platform/x86: ISST: Add SST-PP support via TPMI
>   platform/x86: ISST: Add SST-BF support via TPMI
>   platform/x86: ISST: Add SST-TF support via TPMI
>   platform/x86: ISST: Add suspend/resume callbacks
> 
>  .../x86/intel/speed_select_if/Kconfig         |    4 +
>  .../x86/intel/speed_select_if/Makefile        |    2 +
>  .../intel/speed_select_if/isst_if_common.c    |   28 +
>  .../x86/intel/speed_select_if/isst_tpmi.c     |   72 +
>  .../intel/speed_select_if/isst_tpmi_core.c    | 1438 +++++++++++++++++
>  .../intel/speed_select_if/isst_tpmi_core.h    |   18 +
>  include/uapi/linux/isst_if.h                  |  303 ++++
>  7 files changed, 1865 insertions(+)
>  create mode 100644 drivers/platform/x86/intel/speed_select_if/isst_tpmi.c
>  create mode 100644 drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
>  create mode 100644 drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.h
>