mbox series

[0/3] watchdog: Simplify using devm_watchdog_register_device()

Message ID 20230306170901.2232323-1-u.kleine-koenig@pengutronix.de
Headers
Series watchdog: Simplify using devm_watchdog_register_device() |

Message

Uwe Kleine-König March 6, 2023, 5:08 p.m. UTC 
  Hello,

this series converts three drivers to use
devm_watchdog_register_device(). This allows to drop their remove
callback.

Best regards
Uwe

Uwe Kleine-König (3):
  watchdog: bcm47xx: Simplify using devm_watchdog_register_device()
  watchdog: rn5t618: Simplify using devm_watchdog_register_device()
  watchdog: wm8350: Simplify using devm_watchdog_register_device()

 drivers/watchdog/bcm47xx_wdt.c | 12 +-----------
 drivers/watchdog/rn5t618_wdt.c | 12 +-----------
 drivers/watchdog/wm8350_wdt.c  |  9 +--------
 3 files changed, 3 insertions(+), 30 deletions(-)


base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6

Comments

Guenter Roeck March 6, 2023, 6:21 p.m. UTC | #1 
On 3/6/23 09:08, Uwe Kleine-König wrote:
> Hello,
> 
> this series converts three drivers to use
> devm_watchdog_register_device(). This allows to drop their remove
> callback.
> 

Side note: We could do more of the same by also replacing pm_runtime_enable()
with devm_pm_runtime_enable(), only I don't know if the additional
call to pm_runtime_dont_use_autosuspend() in its disable callback would
be a functional change. I also don't know if pm_runtime_put() in the remove
function is necessary or if it even makes sense. Any idea ?

Thanks,
Guenter

> Best regards
> Uwe
> 
> Uwe Kleine-König (3):
>    watchdog: bcm47xx: Simplify using devm_watchdog_register_device()
>    watchdog: rn5t618: Simplify using devm_watchdog_register_device()
>    watchdog: wm8350: Simplify using devm_watchdog_register_device()
> 
>   drivers/watchdog/bcm47xx_wdt.c | 12 +-----------
>   drivers/watchdog/rn5t618_wdt.c | 12 +-----------
>   drivers/watchdog/wm8350_wdt.c  |  9 +--------
>   3 files changed, 3 insertions(+), 30 deletions(-)
> 
> 
> base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6