From patchwork Mon Mar 6 06:57:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 6143 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1703614wrd; Sun, 5 Mar 2023 23:24:34 -0800 (PST) X-Google-Smtp-Source: AK7set8Whv9Vmim40zhBDIbejZx0U7WVM0PRHeQMRscVLDAYUXCVlN2Xmcb09Pl084k+gwu4+3lw X-Received: by 2002:aa7:ca54:0:b0:4af:5ff1:8756 with SMTP id j20-20020aa7ca54000000b004af5ff18756mr9101691edt.0.1678087474659; Sun, 05 Mar 2023 23:24:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678087474; cv=none; d=google.com; s=arc-20160816; b=E0WmV2jYrehKlzXe4B6UaDEMVVMTyYcxBNPkoP7qxMFknlKqOD5ggLO+y1vOy3aLFK 2TZL43ffnw6RN5/S1FQNravP0/UuN8owejZSgVge2lKwAGmmMXoDlrNxOAQNWGP7z2WK b6H1E1iMbm4iiRz8Q6g1KOuJzOc7HJoJ8mTy6Gr7tEGsztao35ollzi0UL3TrWJnsu2l 2VymE77svOwYoUEpBw1OIHEY3NIss2IWE45uycPEMEL+Zm0tOf1Tc0oIDc1dtJZ+hCkf H/6RhsHtM/eNnIx7vBrAJV4z476W48PlTwO8NgvA2nR1udMWsDoEX3a/HgIObmuXHiyo fOHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=OMpWhhpr4iAq8bXZzT58DUtejg8HELVw0VtiltTHoww=; b=gmdIf/6FjB5sN8VRRUTFWvfNqCHSDcOYY8v6uEfmHkUgzb5mhy0yRynjgctfRIQ/iM K6STX9o4s0NqaiWEbjZQFNeHdKpyk2NL7rmibPJ93jVS/8B0WXrs6k+LAWnsWUuJv+8y BgxLCKURwT9u/wgsaKzOL6So/ascencXi3B0ZSNFHz5FCkRztXer4HdWpsMTe2KiSSML F9/HzsWfYWpjXTAdv59MfJT9YlFvHJUXDitGL8Ub95GKmoBMBF7XJJmRFx8u9Hr53Vy5 pnjUyMNqZmzw182lXl0I+9uhN8wuGbkhZpXZ095w54IrOFktxn8aUL7ZG7QtKnsxq3TB xrdQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u13-20020a170906408d00b008d0dbf15be3si7238473ejj.676.2023.03.05.23.24.11; Sun, 05 Mar 2023 23:24:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229554AbjCFG6D (ORCPT + 99 others); Mon, 6 Mar 2023 01:58:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229510AbjCFG57 (ORCPT ); Mon, 6 Mar 2023 01:57:59 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC59B5BA3 for ; Sun, 5 Mar 2023 22:57:58 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZ4n1-0003SS-ND; Mon, 06 Mar 2023 07:57:44 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZ4mz-002BSE-UH; Mon, 06 Mar 2023 07:57:41 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZ4mz-002a93-9A; Mon, 06 Mar 2023 07:57:41 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Mark Brown , Shawn Guo , Sascha Hauer , Stefan Agner Cc: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/2] spi: imx: Fix cleanup in remove and convert to .remove_new() Date: Mon, 6 Mar 2023 07:57:31 +0100 Message-Id: <20230306065733.2170662-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=716; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=iiPlfkNGTQtHIdeLCyT911x4K26qGgM1r4nTBJQWiAs=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkBY7RTAkRL5NRvNzODTQz/oDx232L+yMCPvB+G /3cNhC3I1SJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAWO0QAKCRDB/BR4rcrs CTqTB/9WGavBEyJ/eKFU/UHp4ITgLOMqrkH3F7uS/dOK47YGSJlJZCziLGICdP4xF+roi5Ef9XN HPiLSdYK7kox26FREe0eHj+Jnr2/DRd/PUb5AnQ0pTOVFr1AQKQhQ6oyQwK7E6HLgjlc1tFrWmF SMnjnPIvenR8m2h9Ag/ka3nOep7ZYwU2u2AurLaGu1k8t635PK+sn+zMqaXetXDRCqjFAsCcMwH zaCkXZb/6I8OkDljDajb1yuvaAp3HaWgXNnhPMjxaiX901Chq3+TRMlSxDQ854h7AIEzWP1tJss aHX1L4DNRCRoJ5rMXjGr+gT8AtJDBjjkf/+pBizH69PDt3DG X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759602251731607480?= X-GMAIL-MSGID: =?utf-8?q?1759602251731607480?= From: Uwe Kleine-König Hello, this small series converts the spi-imx driver to .remove_new(). The motivation for this tree-wide effort are drivers that don't properly cleanup and return an error code. This is broken as this results in resource leaks. The spi-imx driver is such a driver. The idea is that if the remove callback returns void it's obvious that an early error return is wrong. Best regards Uwe Uwe Kleine-König (2): spi: imx: Don't skip cleanup in remove's error path spi: imx: Convert to platform remove callback returning void drivers/spi/spi-imx.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) base-commit: b01fe98d34f3bed944a93bd8119fed80c856fad8